You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/11/20 22:21:34 UTC

[jira] [Commented] (THRIFT-2796) Testcase for THRIFT-2793

    [ https://issues.apache.org/jira/browse/THRIFT-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220021#comment-14220021 ] 

ASF GitHub Bot commented on THRIFT-2796:
----------------------------------------

GitHub user magiconair opened a pull request:

    https://github.com/apache/thrift/pull/278

    THRIFT-2796: Added testcase for THRIFT-2793. Needs testing.

    I've tried compiling thrift tip on OSX Yosemite but I'm getting some compiler errors. Got a vagrant Ubuntu box but have other issues getting the build off the ground. 
    
    Maybe someone else can review the test case?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/magiconair/thrift THRIFT-2796

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/278.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #278
    
----
commit d131a5c165c7b198d3c85be7d0db68670e499eda
Author: Frank Schroeder <fr...@ebay.com>
Date:   2014-11-20T21:03:53Z

    THRIFT-2796: Added testcase for THRIFT-2793. Needs testing.

----


> Testcase for THRIFT-2793
> ------------------------
>
>                 Key: THRIFT-2796
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2796
>             Project: Thrift
>          Issue Type: Test
>          Components: Go - Compiler
>            Reporter: Jens Geyer
>             Fix For: 1.0
>
>
> Add test for THRIFT-2793 Go compiler produces uncompilable code



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)