You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/12 12:20:55 UTC

[GitHub] [flink] StephanEwen opened a new pull request #10162: [FLINK-14635][e2e tests] Use non-relocated imports for AWS SDK Kinesis classes in tests.

StephanEwen opened a new pull request #10162: [FLINK-14635][e2e tests] Use non-relocated imports for AWS SDK Kinesis classes in tests.
URL: https://github.com/apache/flink/pull/10162
 
 
   ## What is the purpose of the change
   
   This allows compiling the code base fully in the IDE again by changing the way that the AWS SDK classes are used in the `KinesisPubsubClient in the Kineses end-2-end test.
   
   Some imports were referring to relocated classes from the connector, which cannot be resolved in the IDE because no shading happens during compilation.
   
   ## Brief change log
   
     - Move the `KinesisPubsubClient` to `flink-connector-kinesis`
     - Export a test-jar with the test utils from `flink-connector-kinesis`
     - Add the test-jar to the Kinesis end-2-end test
     - There is a separate cleanup commit for some compiler warning and code inspections
   
   ## Verifying this change
   
   This changes a test which still runs and works.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **yes** (in a test)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services