You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by Guido Wimmel <gu...@gmx.net> on 2015/03/09 16:59:39 UTC
merging to master [was: (SYNCOPE-651) SyncopeUser:checkToken()
should fail if token is not set on user]
Hi,
anything special to be considered for merging to master, because of the code restructuring?
Cheers,
Guido
> Gesendet: Montag, 09. März 2015 um 16:52 Uhr
> Von: "ASF subversion and git services (JIRA)" <ji...@apache.org>
> An: dev@syncope.apache.org
> Betreff: [jira] [Commented] (SYNCOPE-651) SyncopeUser:checkToken() should fail if token is not set on user
>
>
> [ https://issues.apache.org/jira/browse/SYNCOPE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353137#comment-14353137 ]
>
> ASF subversion and git services commented on SYNCOPE-651:
> ---------------------------------------------------------
>
> Commit 3621adf44e6c76a4faefb9782f77d90a1707ac1e in syncope's branch refs/heads/1_2_X from [~wimmelg]
> [ https://git-wip-us.apache.org/repos/asf?p=syncope.git;h=3621adf ]
>
> [SYNCOPE-651] SyncopeUser:checkToken() should fail if token is not set on user
>
>
> > SyncopeUser:checkToken() should fail if token is not set on user
> > ----------------------------------------------------------------
> >
> > Key: SYNCOPE-651
> > URL: https://issues.apache.org/jira/browse/SYNCOPE-651
> > Project: Syncope
> > Issue Type: Improvement
> > Components: core
> > Affects Versions: 1.1.8, 1.2.2
> > Reporter: Guido Wimmel
> > Assignee: Guido Wimmel
> > Priority: Minor
> > Fix For: 1.1.9, 1.2.3, 2.0.0
> >
> >
> > Currently, SyncopeUser:checkToken(String token) always returns true if user.token==null (i.e., the token attribute is not set). This is counterintuitive if the token parameter is not null (as the token passed as a parameter is obviously not valid).
> > To make workflow implementations more robust, SyncopeUser:checkToken(String token) should return false if the token parameter is not null and user.token is null.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>
Re: merging to master [was: (SYNCOPE-651) SyncopeUser:checkToken()
should fail if token is not set on user]
Posted by Francesco Chicchiriccò <il...@apache.org>.
On 09/03/2015 16:59, Guido Wimmel wrote:
> Hi,
>
> anything special to be considered for merging to master, because of the code restructuring?
Since your changes are limited to SyncopeUser, nothing special - besides
the fact that the class is now named JPAUser and is located at
./core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/user/JPAUser.java
Regards.
>> Gesendet: Montag, 09. März 2015 um 16:52 Uhr
>> Von: "ASF subversion and git services (JIRA)" <ji...@apache.org>
>> An: dev@syncope.apache.org
>> Betreff: [jira] [Commented] (SYNCOPE-651) SyncopeUser:checkToken() should fail if token is not set on user
>>
>>
>> [ https://issues.apache.org/jira/browse/SYNCOPE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353137#comment-14353137 ]
>>
>> ASF subversion and git services commented on SYNCOPE-651:
>> ---------------------------------------------------------
>>
>> Commit 3621adf44e6c76a4faefb9782f77d90a1707ac1e in syncope's branch refs/heads/1_2_X from [~wimmelg]
>> [ https://git-wip-us.apache.org/repos/asf?p=syncope.git;h=3621adf ]
>>
>> [SYNCOPE-651] SyncopeUser:checkToken() should fail if token is not set on user
>>
>>
>>> SyncopeUser:checkToken() should fail if token is not set on user
>>> ----------------------------------------------------------------
>>>
>>> Key: SYNCOPE-651
>>> URL: https://issues.apache.org/jira/browse/SYNCOPE-651
>>> Project: Syncope
>>> Issue Type: Improvement
>>> Components: core
>>> Affects Versions: 1.1.8, 1.2.2
>>> Reporter: Guido Wimmel
>>> Assignee: Guido Wimmel
>>> Priority: Minor
>>> Fix For: 1.1.9, 1.2.3, 2.0.0
>>>
>>>
>>> Currently, SyncopeUser:checkToken(String token) always returns true if user.token==null (i.e., the token attribute is not set). This is counterintuitive if the token parameter is not null (as the token passed as a parameter is obviously not valid).
>>> To make workflow implementations more robust, SyncopeUser:checkToken(String token) should return false if the token parameter is not null and user.token is null.
--
Francesco Chicchiriccò
Tirasa - Open Source Excellence
http://www.tirasa.net/
Involved at The Apache Software Foundation:
member, Syncope PMC chair, Cocoon PMC, Olingo PMC
http://people.apache.org/~ilgrosso/