You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Siegfried Goeschl <si...@it20one.at> on 2004/11/03 11:05:22 UTC
[fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
Hi folks,
I fixed the following bugs in fulcrum-yaafi 1.0.3-dev
1) implementation not backward compatible to JDK 1.3.x
(ServiceComponentImpl.java)
cvs diff
src\java\org\apache\fulcrum\yaafi\framework\container\ServiceComponentImpl.java
(in directory W:\work\jakarta\jakarta-turbine-fulcrum\yaafi\)
Index:
src/java/org/apache/fulcrum/yaafi/framework/container/ServiceComponentImpl.java
===================================================================
RCS file:
/home/cvspublic/jakarta-turbine-fulcrum/yaafi/src/java/org/apache/fulcrum/yaafi/framework/container/ServiceComponentImpl.java,v
retrieving revision 1.1
diff -r1.1 ServiceComponentImpl.java
148c148
< throw new RuntimeException(msg,t);
---
> throw new RuntimeException(msg);
206c206
< throw new RuntimeException(msg,t);
---
> throw new RuntimeException(msg);
346c346
< throw new RuntimeException(msg,t);
---
> throw new RuntimeException(msg);
2) the components were not properly disposed (ServiceContainerImpl.java)
cvs diff
src\java\org\apache\fulcrum\yaafi\framework\container\ServiceContainerImpl.java
(in directory W:\work\jakarta\jakarta-turbine-fulcrum\yaafi\)
Index:
src/java/org/apache/fulcrum/yaafi/framework/container/ServiceContainerImpl.java
===================================================================
RCS file:
/home/cvspublic/jakarta-turbine-fulcrum/yaafi/src/java/org/apache/fulcrum/yaafi/framework/container/ServiceContainerImpl.java,v
retrieving revision 1.1
diff -r1.1 ServiceContainerImpl.java
536c536
<
---
> this.decommision( serviceComponent );
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
RE: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
Posted by Eric Pugh <ep...@upstate.com>.
But those of us who are Eclipse folks I think are locked in.. Although
lately I've been having no luck w/ patches via eclipse.. I'll try something
else..
Eric
> -----Original Message-----
> From: Henning P. Schmiedehausen [mailto:hps@intermeta.de]
> Sent: Thursday, November 04, 2004 1:32 AM
> To: turbine-dev@jakarta.apache.org
> Subject: Re: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
>
>
> "Eric Pugh" <ep...@upstate.com> writes:
>
> >I knew the diff file looked odd!
>
> That should be no problem to patch. Patch should be able to handle
> "regular" and unified diffs.
>
> Regards
> Henning
>
>
> >> -----Original Message-----
> >> From: Niclas Hedhman [mailto:niclas@hedhman.org]
> >> Sent: Wednesday, November 03, 2004 12:13 PM
> >> To: Turbine Developers List
> >> Subject: Re: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
> >>
> >>
> >> On Wednesday 03 November 2004 18:05, Siegfried Goeschl wrote:
> >>
> >> Use
> >> cvs diff -u
> >> so the output is in the "normal" format.
> >>
> >> Cheers
> >> Niclas
> >>
> >> --
> >> +------//-------------------+
> >> / http://www.bali.ac /
> >> / http://niclas.hedhman.org /
> >> +------//-------------------+
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> >> For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
>
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
>
> --
> Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
> hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/
>
> RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire
> Linux, Java, perl, Solaris -- Consulting, Training, Development
>
> What is more important to you...
> [ ] Product Security
> or [ ] Quality of Sales and Marketing Support
> -- actual question from a Microsoft customer survey
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
Re: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
Posted by "Henning P. Schmiedehausen" <hp...@intermeta.de>.
"Eric Pugh" <ep...@upstate.com> writes:
>I knew the diff file looked odd!
That should be no problem to patch. Patch should be able to handle
"regular" and unified diffs.
Regards
Henning
>> -----Original Message-----
>> From: Niclas Hedhman [mailto:niclas@hedhman.org]
>> Sent: Wednesday, November 03, 2004 12:13 PM
>> To: Turbine Developers List
>> Subject: Re: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
>>
>>
>> On Wednesday 03 November 2004 18:05, Siegfried Goeschl wrote:
>>
>> Use
>> cvs diff -u
>> so the output is in the "normal" format.
>>
>> Cheers
>> Niclas
>>
>> --
>> +------//-------------------+
>> / http://www.bali.ac /
>> / http://niclas.hedhman.org /
>> +------//-------------------+
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
>---------------------------------------------------------------------
>To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire
Linux, Java, perl, Solaris -- Consulting, Training, Development
What is more important to you...
[ ] Product Security
or [ ] Quality of Sales and Marketing Support
-- actual question from a Microsoft customer survey
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
RE: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
Posted by Eric Pugh <ep...@upstate.com>.
I knew the diff file looked odd!
> -----Original Message-----
> From: Niclas Hedhman [mailto:niclas@hedhman.org]
> Sent: Wednesday, November 03, 2004 12:13 PM
> To: Turbine Developers List
> Subject: Re: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
>
>
> On Wednesday 03 November 2004 18:05, Siegfried Goeschl wrote:
>
> Use
> cvs diff -u
> so the output is in the "normal" format.
>
> Cheers
> Niclas
>
> --
> +------//-------------------+
> / http://www.bali.ac /
> / http://niclas.hedhman.org /
> +------//-------------------+
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
Re: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
Posted by Niclas Hedhman <ni...@hedhman.org>.
On Wednesday 03 November 2004 18:05, Siegfried Goeschl wrote:
Use
cvs diff -u
so the output is in the "normal" format.
Cheers
Niclas
--
+------//-------------------+
/ http://www.bali.ac /
/ http://niclas.hedhman.org /
+------//-------------------+
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
Re: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
Posted by "Henning P. Schmiedehausen" <hp...@intermeta.de>.
Ben Gidley <bg...@gmail.com> writes:
>Just to chip in I think at least 1/2 of the teams I know of working
>with Turbine are using Weblogic 7 and that insists on Java 1.3. I am
>not sure how many other people this would be true for. I personally
>think it is not really that much of an issue to move 2.4 towards 1.4 -
>but it would be good to keep any patches to 2.3 at 1.3 level.
>That being said all of those teams are moving towards 2.4/Antelope
>which using 1.4 features - so they will hav resolve the issue by
>upgrading weblogic.
Hi,
2.3.x will definitely stay JDK 1.3 compatible. If it is not, it would
be a bug.
Knowing that there are products out there that insist on a given JDK
version helps us to make such decisions.
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire
Linux, Java, perl, Solaris -- Consulting, Training, Development
What is more important to you...
[ ] Product Security
or [ ] Quality of Sales and Marketing Support
-- actual question from a Microsoft customer survey
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
Re: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
Posted by Ben Gidley <bg...@gmail.com>.
Just to chip in I think at least 1/2 of the teams I know of working
with Turbine are using Weblogic 7 and that insists on Java 1.3. I am
not sure how many other people this would be true for. I personally
think it is not really that much of an issue to move 2.4 towards 1.4 -
but it would be good to keep any patches to 2.3 at 1.3 level.
That being said all of those teams are moving towards 2.4/Antelope
which using 1.4 features - so they will hav resolve the issue by
upgrading weblogic.
Ben
On Thu, 4 Nov 2004 13:45:36 +0100, Eric Pugh <ep...@upstate.com> wrote:
> I am pretty happy with setting the bar at Java 1.4. Does anyone out there
> use 1.3 still? I think espeically when we are adding new code, worrying
> about 1.3 doesn't seem to make sense.
>
>
>
>
> > -----Original Message-----
> > From: Henning P. Schmiedehausen [mailto:hps@intermeta.de]
> > Sent: Thursday, November 04, 2004 1:32 AM
> > To: turbine-dev@jakarta.apache.org
> > Subject: Re: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
> >
> >
> > Siegfried Goeschl <si...@it20one.at> writes:
> >
> > >Hi folks,
> >
> > >I fixed the following bugs in fulcrum-yaafi 1.0.3-dev
> >
> > >1) implementation not backward compatible to JDK 1.3.x
> > >(ServiceComponentImpl.java)
> >
> > Folks,
> >
> > while I really appreciate the effort to support JDK 1.3, we should
> > take a look ahead. 1.5 went gold a while ago and I do intend at some
> > point to start using its features.
> >
> > Is there any reason that we still actively support JDK 1.3 (any
> > platforms locked into 1.3? products requiring this?)? Or shouldn't we
> > at some point start to point out that Java 1.4 is around for four
> > years or so and use 1.4.x as our baseline.
> >
> > (On a only vaguely related side note: It is a sad thing that Maven
> > supports conditional compiling so terribly bad. I would love to see a
> > mainly 1.4 oriented code base with some 1.5 goodies compiled into it
> > conditionally. While this sucks in ant but is doable, in Maven this is
> > not only a nightmare but seems to be un-do-able. Even selecting JDKs
> > in maven is a real PITA.)
> >
> > Regards
> > Henning
> >
> >
> >
> >
> > >cvs diff
> > >src\java\org\apache\fulcrum\yaafi\framework\container\ServiceComp
> > onentImpl.java
> > >(in directory W:\work\jakarta\jakarta-turbine-fulcrum\yaafi\)
> > >Index:
> > >src/java/org/apache/fulcrum/yaafi/framework/container/ServiceComp
> > onentImpl.java
> > >===================================================================
> > >RCS file:
> > >/home/cvspublic/jakarta-turbine-fulcrum/yaafi/src/java/org/apache
> > /fulcrum/yaafi/framework/container/ServiceComponentImpl.java,v
> > >retrieving revision 1.1
> > >diff -r1.1 ServiceComponentImpl.java
> > >148c148
> > >< throw new RuntimeException(msg,t);
> > >---
> > > > throw new RuntimeException(msg);
> > >206c206
> > >< throw new RuntimeException(msg,t);
> > >---
> > > > throw new RuntimeException(msg);
> > >346c346
> > >< throw new RuntimeException(msg,t);
> > >---
> > > > throw new RuntimeException(msg);
> >
> > >2) the components were not properly disposed (ServiceContainerImpl.java)
> >
> > >cvs diff
> > >src\java\org\apache\fulcrum\yaafi\framework\container\ServiceCont
> > ainerImpl.java
> > >(in directory W:\work\jakarta\jakarta-turbine-fulcrum\yaafi\)
> > >Index:
> > >src/java/org/apache/fulcrum/yaafi/framework/container/ServiceCont
>
>
> > ainerImpl.java
> > >===================================================================
> > >RCS file:
> > >/home/cvspublic/jakarta-turbine-fulcrum/yaafi/src/java/org/apache
> > /fulcrum/yaafi/framework/container/ServiceContainerImpl.java,v
> > >retrieving revision 1.1
> > >diff -r1.1 ServiceContainerImpl.java
> > >536c536
> > ><
> > >---
> > > > this.decommision( serviceComponent );
> >
> >
> >
> >
> > >---------------------------------------------------------------------
> > >To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> > >For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
> >
> > --
> > Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
> > hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/
> >
> > RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire
> > Linux, Java, perl, Solaris -- Consulting, Training, Development
> >
> > What is more important to you...
> > [ ] Product Security
> > or [ ] Quality of Sales and Marketing Support
> > -- actual question from a Microsoft customer survey
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
>
>
--
Thanks
Ben
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
RE: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
Posted by Eric Pugh <ep...@upstate.com>.
Well.. If you where a user I might not worry so much about it.. But,
since you wrote Yaafi, then I have a different attitude. If you need 1.3
support in Yaafi, and wrote the darn thing, then I am happy to put the 1.3
stuff in.
Can you send a patch that takes into account my latest updates?
> -----Original Message-----
> From: Siegfried Goeschl [mailto:siegfried.goeschl@it20one.at]
> Sent: Thursday, November 04, 2004 2:16 PM
> To: Turbine Developers List
> Subject: Re: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
>
>
> Hi folks,
>
> I was just forced to go back to JDK 1.3.11 on one of my applications
> (for some rather obscure reason). Basically I don't mind if Turbine is
> expecting JDK 1.4 but for Fulcrum as reusable component library things
> might look different. And for YAAFI I don't see any good reason to
> introduce JDK 1.4 dependencies ... :-)
>
> Cheers,
>
> Siegfried Goeschl
>
> Eric Pugh wrote:
>
> >I am pretty happy with setting the bar at Java 1.4. Does anyone out
> there
> >use 1.3 still? I think espeically when we are adding new code,
> worrying
> >about 1.3 doesn't seem to make sense.
> >
> >
> >
> >
> >>-----Original Message-----
> >>From: Henning P. Schmiedehausen [mailto:hps@intermeta.de]
> >>Sent: Thursday, November 04, 2004 1:32 AM
> >>To: turbine-dev@jakarta.apache.org
> >>Subject: Re: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
> >>
> >>
> >>Siegfried Goeschl <si...@it20one.at> writes:
> >>
> >>
> >>
> >>>Hi folks,
> >>>
> >>>
> >>>I fixed the following bugs in fulcrum-yaafi 1.0.3-dev
> >>>
> >>>
> >>>1) implementation not backward compatible to JDK 1.3.x
> >>>(ServiceComponentImpl.java)
> >>>
> >>>
> >>Folks,
> >>
> >>while I really appreciate the effort to support JDK 1.3, we should
> >>take a look ahead. 1.5 went gold a while ago and I do intend at some
> >>point to start using its features.
> >>
> >>Is there any reason that we still actively support JDK 1.3 (any
> >>platforms locked into 1.3? products requiring this?)? Or shouldn't we
> >>at some point start to point out that Java 1.4 is around for four
> >>years or so and use 1.4.x as our baseline.
> >>
> >>(On a only vaguely related side note: It is a sad thing that Maven
> >>supports conditional compiling so terribly bad. I would love to see a
> >>mainly 1.4 oriented code base with some 1.5 goodies compiled into it
> >>conditionally. While this sucks in ant but is doable, in Maven this is
> >>not only a nightmare but seems to be un-do-able. Even selecting JDKs
> >>in maven is a real PITA.)
> >>
> >> Regards
> >> Henning
> >>
> >>
> >>
> >>
> >>
> >>
> >>>cvs diff
> >>>src\java\org\apache\fulcrum\yaafi\framework\container\ServiceComp
> >>>
> >>>
> >>onentImpl.java
> >>
> >>
> >>>(in directory W:\work\jakarta\jakarta-turbine-fulcrum\yaafi\)
> >>>Index:
> >>>src/java/org/apache/fulcrum/yaafi/framework/container/ServiceComp
> >>>
> >>>
> >>onentImpl.java
> >>
> >>
> >>>===================================================================
> >>>RCS file:
> >>>/home/cvspublic/jakarta-turbine-fulcrum/yaafi/src/java/org/apache
> >>>
> >>>
> >>/fulcrum/yaafi/framework/container/ServiceComponentImpl.java,v
> >>
> >>
> >>>retrieving revision 1.1
> >>>diff -r1.1 ServiceComponentImpl.java
> >>>148c148
> >>>< throw new RuntimeException(msg,t);
> >>>---
> >>>
> >>>
> >>>> throw new RuntimeException(msg);
> >>>>
> >>>>
> >>>206c206
> >>>< throw new RuntimeException(msg,t);
> >>>---
> >>>
> >>>
> >>>> throw new RuntimeException(msg);
> >>>>
> >>>>
> >>>346c346
> >>>< throw new RuntimeException(msg,t);
> >>>---
> >>>
> >>>
> >>>> throw new RuntimeException(msg);
> >>>>
> >>>>
> >>>2) the components were not properly disposed
> (ServiceContainerImpl.java)
> >>>
> >>>
> >>>cvs diff
> >>>src\java\org\apache\fulcrum\yaafi\framework\container\ServiceCont
> >>>
> >>>
> >>ainerImpl.java
> >>
> >>
> >>>(in directory W:\work\jakarta\jakarta-turbine-fulcrum\yaafi\)
> >>>Index:
> >>>src/java/org/apache/fulcrum/yaafi/framework/container/ServiceCont
> >>>
> >>>
> >>ainerImpl.java
> >>
> >>
> >>>===================================================================
> >>>RCS file:
> >>>/home/cvspublic/jakarta-turbine-fulcrum/yaafi/src/java/org/apache
> >>>
> >>>
> >>/fulcrum/yaafi/framework/container/ServiceContainerImpl.java,v
> >>
> >>
> >>>retrieving revision 1.1
> >>>diff -r1.1 ServiceContainerImpl.java
> >>>536c536
> >>><
> >>>---
> >>>
> >>>
> >>>> this.decommision( serviceComponent );
> >>>>
> >>>>
> >>
> >>
> >>
> >>
> >>>---------------------------------------------------------------------
> >>>To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> >>>For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
> >>>
> >>>
> >>--
> >>Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
> >>hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/
> >>
> >>RedHat Certified Engineer -- Jakarta Turbine Development -- hero for
> hire
> >> Linux, Java, perl, Solaris -- Consulting, Training, Development
> >>
> >>What is more important to you...
> >> [ ] Product Security
> >>or [ ] Quality of Sales and Marketing Support
> >> -- actual question from a Microsoft customer survey
> >>
> >>---------------------------------------------------------------------
> >>To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> >>For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
> >>
> >>
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
> >
> >
> >__________ NOD32 1.916 (20041103) Information __________
> >
> >Diese E-Mail wurde vom NOD32 Antivirus System gepruft
> >http://www.nod32.com
> >
> >
> >
> >
> >
>
>
> --
> Siegfried Goeschl
>
> IT20one GmbH
> Bandgasse 2/22
> 1070 Wien
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
Re: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
Posted by Siegfried Goeschl <si...@it20one.at>.
Hi folks,
I was just forced to go back to JDK 1.3.11 on one of my applications
(for some rather obscure reason). Basically I don't mind if Turbine is
expecting JDK 1.4 but for Fulcrum as reusable component library things
might look different. And for YAAFI I don't see any good reason to
introduce JDK 1.4 dependencies ... :-)
Cheers,
Siegfried Goeschl
Eric Pugh wrote:
>I am pretty happy with setting the bar at Java 1.4. Does anyone out there
>use 1.3 still? I think espeically when we are adding new code, worrying
>about 1.3 doesn't seem to make sense.
>
>
>
>
>>-----Original Message-----
>>From: Henning P. Schmiedehausen [mailto:hps@intermeta.de]
>>Sent: Thursday, November 04, 2004 1:32 AM
>>To: turbine-dev@jakarta.apache.org
>>Subject: Re: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
>>
>>
>>Siegfried Goeschl <si...@it20one.at> writes:
>>
>>
>>
>>>Hi folks,
>>>
>>>
>>>I fixed the following bugs in fulcrum-yaafi 1.0.3-dev
>>>
>>>
>>>1) implementation not backward compatible to JDK 1.3.x
>>>(ServiceComponentImpl.java)
>>>
>>>
>>Folks,
>>
>>while I really appreciate the effort to support JDK 1.3, we should
>>take a look ahead. 1.5 went gold a while ago and I do intend at some
>>point to start using its features.
>>
>>Is there any reason that we still actively support JDK 1.3 (any
>>platforms locked into 1.3? products requiring this?)? Or shouldn't we
>>at some point start to point out that Java 1.4 is around for four
>>years or so and use 1.4.x as our baseline.
>>
>>(On a only vaguely related side note: It is a sad thing that Maven
>>supports conditional compiling so terribly bad. I would love to see a
>>mainly 1.4 oriented code base with some 1.5 goodies compiled into it
>>conditionally. While this sucks in ant but is doable, in Maven this is
>>not only a nightmare but seems to be un-do-able. Even selecting JDKs
>>in maven is a real PITA.)
>>
>> Regards
>> Henning
>>
>>
>>
>>
>>
>>
>>>cvs diff
>>>src\java\org\apache\fulcrum\yaafi\framework\container\ServiceComp
>>>
>>>
>>onentImpl.java
>>
>>
>>>(in directory W:\work\jakarta\jakarta-turbine-fulcrum\yaafi\)
>>>Index:
>>>src/java/org/apache/fulcrum/yaafi/framework/container/ServiceComp
>>>
>>>
>>onentImpl.java
>>
>>
>>>===================================================================
>>>RCS file:
>>>/home/cvspublic/jakarta-turbine-fulcrum/yaafi/src/java/org/apache
>>>
>>>
>>/fulcrum/yaafi/framework/container/ServiceComponentImpl.java,v
>>
>>
>>>retrieving revision 1.1
>>>diff -r1.1 ServiceComponentImpl.java
>>>148c148
>>>< throw new RuntimeException(msg,t);
>>>---
>>>
>>>
>>>> throw new RuntimeException(msg);
>>>>
>>>>
>>>206c206
>>>< throw new RuntimeException(msg,t);
>>>---
>>>
>>>
>>>> throw new RuntimeException(msg);
>>>>
>>>>
>>>346c346
>>>< throw new RuntimeException(msg,t);
>>>---
>>>
>>>
>>>> throw new RuntimeException(msg);
>>>>
>>>>
>>>2) the components were not properly disposed (ServiceContainerImpl.java)
>>>
>>>
>>>cvs diff
>>>src\java\org\apache\fulcrum\yaafi\framework\container\ServiceCont
>>>
>>>
>>ainerImpl.java
>>
>>
>>>(in directory W:\work\jakarta\jakarta-turbine-fulcrum\yaafi\)
>>>Index:
>>>src/java/org/apache/fulcrum/yaafi/framework/container/ServiceCont
>>>
>>>
>>ainerImpl.java
>>
>>
>>>===================================================================
>>>RCS file:
>>>/home/cvspublic/jakarta-turbine-fulcrum/yaafi/src/java/org/apache
>>>
>>>
>>/fulcrum/yaafi/framework/container/ServiceContainerImpl.java,v
>>
>>
>>>retrieving revision 1.1
>>>diff -r1.1 ServiceContainerImpl.java
>>>536c536
>>><
>>>---
>>>
>>>
>>>> this.decommision( serviceComponent );
>>>>
>>>>
>>
>>
>>
>>
>>>---------------------------------------------------------------------
>>>To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
>>>For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
>>>
>>>
>>--
>>Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
>>hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/
>>
>>RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire
>> Linux, Java, perl, Solaris -- Consulting, Training, Development
>>
>>What is more important to you...
>> [ ] Product Security
>>or [ ] Quality of Sales and Marketing Support
>> -- actual question from a Microsoft customer survey
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
>>For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
>>
>>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
>
>
>__________ NOD32 1.916 (20041103) Information __________
>
>Diese E-Mail wurde vom NOD32 Antivirus System geprüft
>http://www.nod32.com
>
>
>
>
>
--
Siegfried Goeschl
IT20one GmbH
Bandgasse 2/22
1070 Wien
RE: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
Posted by Eric Pugh <ep...@upstate.com>.
I am pretty happy with setting the bar at Java 1.4. Does anyone out there
use 1.3 still? I think espeically when we are adding new code, worrying
about 1.3 doesn't seem to make sense.
> -----Original Message-----
> From: Henning P. Schmiedehausen [mailto:hps@intermeta.de]
> Sent: Thursday, November 04, 2004 1:32 AM
> To: turbine-dev@jakarta.apache.org
> Subject: Re: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
>
>
> Siegfried Goeschl <si...@it20one.at> writes:
>
> >Hi folks,
>
> >I fixed the following bugs in fulcrum-yaafi 1.0.3-dev
>
> >1) implementation not backward compatible to JDK 1.3.x
> >(ServiceComponentImpl.java)
>
> Folks,
>
> while I really appreciate the effort to support JDK 1.3, we should
> take a look ahead. 1.5 went gold a while ago and I do intend at some
> point to start using its features.
>
> Is there any reason that we still actively support JDK 1.3 (any
> platforms locked into 1.3? products requiring this?)? Or shouldn't we
> at some point start to point out that Java 1.4 is around for four
> years or so and use 1.4.x as our baseline.
>
> (On a only vaguely related side note: It is a sad thing that Maven
> supports conditional compiling so terribly bad. I would love to see a
> mainly 1.4 oriented code base with some 1.5 goodies compiled into it
> conditionally. While this sucks in ant but is doable, in Maven this is
> not only a nightmare but seems to be un-do-able. Even selecting JDKs
> in maven is a real PITA.)
>
> Regards
> Henning
>
>
>
>
> >cvs diff
> >src\java\org\apache\fulcrum\yaafi\framework\container\ServiceComp
> onentImpl.java
> >(in directory W:\work\jakarta\jakarta-turbine-fulcrum\yaafi\)
> >Index:
> >src/java/org/apache/fulcrum/yaafi/framework/container/ServiceComp
> onentImpl.java
> >===================================================================
> >RCS file:
> >/home/cvspublic/jakarta-turbine-fulcrum/yaafi/src/java/org/apache
> /fulcrum/yaafi/framework/container/ServiceComponentImpl.java,v
> >retrieving revision 1.1
> >diff -r1.1 ServiceComponentImpl.java
> >148c148
> >< throw new RuntimeException(msg,t);
> >---
> > > throw new RuntimeException(msg);
> >206c206
> >< throw new RuntimeException(msg,t);
> >---
> > > throw new RuntimeException(msg);
> >346c346
> >< throw new RuntimeException(msg,t);
> >---
> > > throw new RuntimeException(msg);
>
> >2) the components were not properly disposed (ServiceContainerImpl.java)
>
> >cvs diff
> >src\java\org\apache\fulcrum\yaafi\framework\container\ServiceCont
> ainerImpl.java
> >(in directory W:\work\jakarta\jakarta-turbine-fulcrum\yaafi\)
> >Index:
> >src/java/org/apache/fulcrum/yaafi/framework/container/ServiceCont
> ainerImpl.java
> >===================================================================
> >RCS file:
> >/home/cvspublic/jakarta-turbine-fulcrum/yaafi/src/java/org/apache
> /fulcrum/yaafi/framework/container/ServiceContainerImpl.java,v
> >retrieving revision 1.1
> >diff -r1.1 ServiceContainerImpl.java
> >536c536
> ><
> >---
> > > this.decommision( serviceComponent );
>
>
>
>
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
>
> --
> Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
> hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/
>
> RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire
> Linux, Java, perl, Solaris -- Consulting, Training, Development
>
> What is more important to you...
> [ ] Product Security
> or [ ] Quality of Sales and Marketing Support
> -- actual question from a Microsoft customer survey
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
Re: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
Posted by "Henning P. Schmiedehausen" <hp...@intermeta.de>.
Siegfried Goeschl <si...@it20one.at> writes:
>Hi folks,
>I fixed the following bugs in fulcrum-yaafi 1.0.3-dev
>1) implementation not backward compatible to JDK 1.3.x
>(ServiceComponentImpl.java)
Folks,
while I really appreciate the effort to support JDK 1.3, we should
take a look ahead. 1.5 went gold a while ago and I do intend at some
point to start using its features.
Is there any reason that we still actively support JDK 1.3 (any
platforms locked into 1.3? products requiring this?)? Or shouldn't we
at some point start to point out that Java 1.4 is around for four
years or so and use 1.4.x as our baseline.
(On a only vaguely related side note: It is a sad thing that Maven
supports conditional compiling so terribly bad. I would love to see a
mainly 1.4 oriented code base with some 1.5 goodies compiled into it
conditionally. While this sucks in ant but is doable, in Maven this is
not only a nightmare but seems to be un-do-able. Even selecting JDKs
in maven is a real PITA.)
Regards
Henning
>cvs diff
>src\java\org\apache\fulcrum\yaafi\framework\container\ServiceComponentImpl.java
>(in directory W:\work\jakarta\jakarta-turbine-fulcrum\yaafi\)
>Index:
>src/java/org/apache/fulcrum/yaafi/framework/container/ServiceComponentImpl.java
>===================================================================
>RCS file:
>/home/cvspublic/jakarta-turbine-fulcrum/yaafi/src/java/org/apache/fulcrum/yaafi/framework/container/ServiceComponentImpl.java,v
>retrieving revision 1.1
>diff -r1.1 ServiceComponentImpl.java
>148c148
>< throw new RuntimeException(msg,t);
>---
> > throw new RuntimeException(msg);
>206c206
>< throw new RuntimeException(msg,t);
>---
> > throw new RuntimeException(msg);
>346c346
>< throw new RuntimeException(msg,t);
>---
> > throw new RuntimeException(msg);
>2) the components were not properly disposed (ServiceContainerImpl.java)
>cvs diff
>src\java\org\apache\fulcrum\yaafi\framework\container\ServiceContainerImpl.java
>(in directory W:\work\jakarta\jakarta-turbine-fulcrum\yaafi\)
>Index:
>src/java/org/apache/fulcrum/yaafi/framework/container/ServiceContainerImpl.java
>===================================================================
>RCS file:
>/home/cvspublic/jakarta-turbine-fulcrum/yaafi/src/java/org/apache/fulcrum/yaafi/framework/container/ServiceContainerImpl.java,v
>retrieving revision 1.1
>diff -r1.1 ServiceContainerImpl.java
>536c536
><
>---
> > this.decommision( serviceComponent );
>---------------------------------------------------------------------
>To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire
Linux, Java, perl, Solaris -- Consulting, Training, Development
What is more important to you...
[ ] Product Security
or [ ] Quality of Sales and Marketing Support
-- actual question from a Microsoft customer survey
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
RE: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
Posted by Eric Pugh <ep...@upstate.com>.
Sigi,
I couldn't get these to apply.. Can you attach them as an attachment? What
are you doing to create your diffs? Also, can you add an entry to
/xdocs/changes.xml
Eric
> -----Original Message-----
> From: Siegfried Goeschl [mailto:siegfried.goeschl@it20one.at]
> Sent: Wednesday, November 03, 2004 11:05 AM
> To: Turbine Developers List; Eric Pugh
> Subject: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
>
>
> Hi folks,
>
> I fixed the following bugs in fulcrum-yaafi 1.0.3-dev
>
> 1) implementation not backward compatible to JDK 1.3.x
> (ServiceComponentImpl.java)
>
> cvs diff
> src\java\org\apache\fulcrum\yaafi\framework\container\ServiceCompo
> nentImpl.java
> (in directory W:\work\jakarta\jakarta-turbine-fulcrum\yaafi\)
> Index:
> src/java/org/apache/fulcrum/yaafi/framework/container/ServiceCompo
> nentImpl.java
> ===================================================================
> RCS file:
> /home/cvspublic/jakarta-turbine-fulcrum/yaafi/src/java/org/apache/
> fulcrum/yaafi/framework/container/ServiceComponentImpl.java,v
> retrieving revision 1.1
> diff -r1.1 ServiceComponentImpl.java
> 148c148
> < throw new RuntimeException(msg,t);
> ---
> > throw new RuntimeException(msg);
> 206c206
> < throw new RuntimeException(msg,t);
> ---
> > throw new RuntimeException(msg);
> 346c346
> < throw new RuntimeException(msg,t);
> ---
> > throw new RuntimeException(msg);
>
> 2) the components were not properly disposed (ServiceContainerImpl.java)
>
> cvs diff
> src\java\org\apache\fulcrum\yaafi\framework\container\ServiceConta
> inerImpl.java
> (in directory W:\work\jakarta\jakarta-turbine-fulcrum\yaafi\)
> Index:
> src/java/org/apache/fulcrum/yaafi/framework/container/ServiceConta
> inerImpl.java
> ===================================================================
> RCS file:
> /home/cvspublic/jakarta-turbine-fulcrum/yaafi/src/java/org/apache/
> fulcrum/yaafi/framework/container/ServiceContainerImpl.java,v
> retrieving revision 1.1
> diff -r1.1 ServiceContainerImpl.java
> 536c536
> <
> ---
> > this.decommision( serviceComponent );
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
RE: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
Posted by Eric Pugh <ep...@opensourceconnections.com>.
I have applied the fix.. However, there is one more problem.. The method
on BaseUnitTest.release() doesn't do anything. The only way to shut down a
compoent is to call dispose on the container, which ends up being a call to
tearDown..
I added a unit test to TestComponentTest to demonstrate the problem.. Often
in testing we want to shut down a component to see what happens...
On the plus side, the Disoposable method is now called, so I was able to
remove the hack in my BaseQuartzTestCase!
Eric
> -----Original Message-----
> From: Siegfried Goeschl [mailto:siegfried.goeschl@it20one.at]
> Sent: Wednesday, November 03, 2004 11:05 AM
> To: Turbine Developers List; Eric Pugh
> Subject: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev
>
>
> Hi folks,
>
> I fixed the following bugs in fulcrum-yaafi 1.0.3-dev
>
> 1) implementation not backward compatible to JDK 1.3.x
> (ServiceComponentImpl.java)
>
> cvs diff
> src\java\org\apache\fulcrum\yaafi\framework\container\ServiceCompo
> nentImpl.java
> (in directory W:\work\jakarta\jakarta-turbine-fulcrum\yaafi\)
> Index:
> src/java/org/apache/fulcrum/yaafi/framework/container/ServiceCompo
> nentImpl.java
> ===================================================================
> RCS file:
> /home/cvspublic/jakarta-turbine-fulcrum/yaafi/src/java/org/apache/
> fulcrum/yaafi/framework/container/ServiceComponentImpl.java,v
> retrieving revision 1.1
> diff -r1.1 ServiceComponentImpl.java
> 148c148
> < throw new RuntimeException(msg,t);
> ---
> > throw new RuntimeException(msg);
> 206c206
> < throw new RuntimeException(msg,t);
> ---
> > throw new RuntimeException(msg);
> 346c346
> < throw new RuntimeException(msg,t);
> ---
> > throw new RuntimeException(msg);
>
> 2) the components were not properly disposed (ServiceContainerImpl.java)
>
> cvs diff
> src\java\org\apache\fulcrum\yaafi\framework\container\ServiceConta
> inerImpl.java
> (in directory W:\work\jakarta\jakarta-turbine-fulcrum\yaafi\)
> Index:
> src/java/org/apache/fulcrum/yaafi/framework/container/ServiceConta
> inerImpl.java
> ===================================================================
> RCS file:
> /home/cvspublic/jakarta-turbine-fulcrum/yaafi/src/java/org/apache/
> fulcrum/yaafi/framework/container/ServiceContainerImpl.java,v
> retrieving revision 1.1
> diff -r1.1 ServiceContainerImpl.java
> 536c536
> <
> ---
> > this.decommision( serviceComponent );
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org