You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/06/12 13:38:59 UTC
[GitHub] flink pull request #4109: [FLINK-6898] [metrics] Limit size of operator comp...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4109
[FLINK-6898] [metrics] Limit size of operator component in metric name
This PR prevents the operator name component of a metric name to exceed 80 characters. I picked 80 since it is below 255 (a common maximum for file lengths), but still large enough for that once-in-a-million special case. I guess.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6898
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4109
----
commit 71bf096d6562d45a3b235ad8c027cdd601f6d937
Author: zentol <ch...@apache.org>
Date: 2017-06-12T13:36:25Z
[FLINK-6898] [metrics] Limit size of operator component in metric name
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4109: [FLINK-6898] [metrics] Limit size of operator component i...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4109
a constant is a good idea, will add it and start merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4109: [FLINK-6898] [metrics] Limit size of operator comp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4109
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4109: [FLINK-6898] [metrics] Limit size of operator component i...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4109
Update looks good. Do we want to define `80` as a constant?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4109: [FLINK-6898] [metrics] Limit size of operator component i...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4109
no, it's not safe nor does it actually fulfill the purpose. I better add a test for this....
We can't just fail, as the metric system shouldn't throw exceptions, since this isn't a problem that affects job execution.
I've moved the truncation into `TaskMetricGroup#addOperator()` which is the only call to the constructor outside of tests (as intended).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4109: [FLINK-6898] [metrics] Limit size of operator component i...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4109
Is it safe to set the full `operatorName` in the parent constructor scope but truncate in the local info and variables map? Would it be better to explicitly fail rather than implicitly truncate?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---