You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2023/01/14 11:05:24 UTC

[GitHub] [pulsar-client-go] reugn opened a new pull request, #942: Migrate from the deprecated io/ioutil package

reugn opened a new pull request, #942:
URL: https://github.com/apache/pulsar-client-go/pull/942

   ### Motivation
   The `io/ioutil` package has been deprecated in go1.16, see the [release notes](https://go.dev/doc/go1.16#ioutil). This PR replaces the existing `io/ioutil` calls with their new definitions in the `io` and `os` packages.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is already covered by existing tests.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API: (yes / **no**)
     - The schema: (yes / **no** / don't know)
     - The default values of configurations: (yes / **no**)
     - The wire protocol: (yes / **no**)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-go] pgier commented on pull request #942: Migrate from the deprecated io/ioutil package

Posted by "pgier (via GitHub)" <gi...@apache.org>.
pgier commented on PR #942:
URL: https://github.com/apache/pulsar-client-go/pull/942#issuecomment-1419984006

   @nodece That's certainly possible, but in my opinion not worth the extra maintenance effort.  It would mean that any bug fixes and new features would also need to be tested against the older versions.  At some point we should just tell users to upgrade their Go version, especially since golang itself only maintains the two most recent versions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-go] nodece merged pull request #942: Migrate from the deprecated io/ioutil package

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece merged PR #942:
URL: https://github.com/apache/pulsar-client-go/pull/942


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-go] nodece commented on pull request #942: Migrate from the deprecated io/ioutil package

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #942:
URL: https://github.com/apache/pulsar-client-go/pull/942#issuecomment-1418692401

   We can use a build flag to be compatible with the different versions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org