You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "akashsawan1 (via GitHub)" <gi...@apache.org> on 2023/04/11 18:33:20 UTC
[GitHub] [eventmesh] akashsawan1 opened a new pull request, #3697: ISSUE #3513 Swap these 2 arguments so they are in the correct order: expected value, actual value.[PravegaStorageConfigTest]
akashsawan1 opened a new pull request, #3697:
URL: https://github.com/apache/eventmesh/pull/3697
Fixes #<3513>.
Motivation
Explain why you want to make the changes and what problem you're trying to solve.
I am contributing for the first time, it will help to keep me motivated to learn and help the community
Modifications
Describe the modifications you've done.
Swapped actual and expected values in the line 50,51,53,54,56-58.
Documentation
Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3697: ISSUE #3513 Swap these 2 arguments so they are in the correct order: expected value, actual value.[PravegaStorageConfigTest] #3513
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3697:
URL: https://github.com/apache/eventmesh/pull/3697#issuecomment-1504519340
## [Codecov](https://codecov.io/gh/apache/eventmesh/pull/3697?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3697](https://codecov.io/gh/apache/eventmesh/pull/3697?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eaa2b2e) into [master](https://codecov.io/gh/apache/eventmesh/commit/1e38fd13a0b8983ee9761fe62553803c6a182266?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e38fd1) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eaa2b2e differs from pull request most recent head 147c3cc. Consider uploading reports for the commit 147c3cc to get more accurate results
```diff
@@ Coverage Diff @@
## master #3697 +/- ##
============================================
- Coverage 13.76% 13.75% -0.02%
Complexity 1291 1291
============================================
Files 571 571
Lines 29236 29229 -7
Branches 2884 2872 -12
============================================
- Hits 4024 4020 -4
+ Misses 24838 24836 -2
+ Partials 374 373 -1
```
[see 7 files with indirect coverage changes](https://codecov.io/gh/apache/eventmesh/pull/3697/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3697: [ISSUE #3513] Swap these 2 arguments so they are in the correct order: expected value, actual value.[PravegaStorageConfigTest]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3697:
URL: https://github.com/apache/eventmesh/pull/3697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org