You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "tanishqgandhi1908 (via GitHub)" <gi...@apache.org> on 2026/07/29 19:03:56 UTC
[PR] feat(frontend): add the Models section to the dashboard [texera]
tanishqgandhi1908 opened a new pull request, #7046:
URL: https://github.com/apache/texera/pull/7046
### What changes were proposed in this PR?
Adds a Models section to the dashboard so models can be managed from the UI. Lists the models a user can access, with card and list views, keyword search, sort, inline rename and description editing, sharing, and delete.
Gated behind a new gui.tabs.models_enabled flag, defaulting to false: the list page ships before the detail page, so the section stays hidden until complete.
<img width="1432" height="635" alt="Screenshot 2026-07-29 at 11 05 33 AM" src="https://github.com/user-attachments/assets/013a2a7a-bd5a-4fdf-9f02-b145760a3096" />
<img width="1432" height="635" alt="Screenshot 2026-07-29 at 11 05 33 AM" src="https://github.com/user-attachments/assets/027ed9c6-c32b-4478-bf0d-f75978ad68f6" />
<img width="451" height="453" alt="Screenshot 2026-07-29 at 11 04 17 AM" src="https://github.com/user-attachments/assets/39a41348-298c-4491-8e22-d6a2ddab2c0d" />
### Any related issues, documentation, discussions?
<!--
Part of #6494
Depends on #6974 — base is main, so the diff shows that PR's commits until it merges
### How was this PR tested?
cd frontend && ng test --include "src/app/dashboard/**"
sbt "ConfigService/testOnly *ConfigResourceSpec" "Config/testOnly *DefaultsConfigSpec"
229 tests across the 7 touched specs; ConfigResourceSpec 33 and DefaultsConfigSpec 5 for the new tab flag. New specs cover the model service (15) and the list page (14: filtering across name/description/framework/owner, AND-ing across chips, sort fallback for the edit-time key models lack, caching so a filter change does not refetch). Model branches added to list-item (24) and card-item (74), including that the card links to the user route when accessibleUserIds is empty, does not fetch a dataset cover, and routes rename/description/share through ModelService.
Manually verified against the local stack: sidebar appears only with the flag on, both views render, search and sort work, share opens against /access/model/*, delete removes the row.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(frontend): add the Models section to the dashboard [texera]
Posted by "tanishqgandhi1908 (via GitHub)" <gi...@apache.org>.
tanishqgandhi1908 commented on PR #7046:
URL: https://github.com/apache/texera/pull/7046#issuecomment-5182575689
Will reopen the PR once end to end prototype is working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(frontend): add the Models section to the dashboard [texera]
Posted by "tanishqgandhi1908 (via GitHub)" <gi...@apache.org>.
tanishqgandhi1908 closed pull request #7046: feat(frontend): add the Models section to the dashboard
URL: https://github.com/apache/texera/pull/7046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(frontend): add the Models section to the dashboard [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7046:
URL: https://github.com/apache/texera/pull/7046#issuecomment-5122504728
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/7046?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 51.92%. Comparing base ([`a351f44`](https://app.codecov.io/gh/apache/texera/commit/a351f44fbf08920d7d9dfe806614ffc4c8ed5a83?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`859a332`](https://app.codecov.io/gh/apache/texera/commit/859a3323f436e1c85315c90b4c29a6514d936472?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 44 commits behind head on main.
> :exclamation: There is a different number of reports uploaded between BASE (a351f44) and HEAD (859a332). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (a351f44) | HEAD (859a332) |
>|------|------|------|
>|agent-service|2|0|
>|config-service|2|1|
>|notebook-migration-service|2|0|
>|access-control-service|2|0|
>|computing-unit-managing-service|2|0|
>|workflow-compiling-service|2|1|
>|pyamber|2|0|
>|file-service|2|0|
>|frontend|2|0|
>|amber|2|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #7046 +/- ##
=============================================
- Coverage 77.30% 51.92% -25.39%
+ Complexity 3524 20 -3504
=============================================
Files 1161 6 -1155
Lines 45922 156 -45766
Branches 5101 9 -5092
=============================================
- Hits 35501 81 -35420
+ Misses 8840 73 -8767
+ Partials 1581 2 -1579
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/7046/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/7046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/7046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [amber](https://app.codecov.io/gh/apache/texera/pull/7046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/7046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/7046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.66% <ø> (ø)` | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/7046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/7046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/7046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/7046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/7046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.31% <ø> (-28.84%)` | :arrow_down: |
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/7046?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(frontend): add the Models section to the dashboard [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7046:
URL: https://github.com/apache/texera/pull/7046#issuecomment-5122566785
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 0 better · 🔴 9 worse · ⚪ 6 noise (<±5%) · 0 without baseline
> Compared against main `a61702f` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/30482759759)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 363 | 0.222 | 25,238/37,117/37,117 us | 🔴 -14.4% / 🔴 +135.3% |
| 🔴 | bs=100 sw=10 sl=64 | 781 | 0.476 | 124,340/170,211/170,211 us | 🔴 +10.1% / 🔴 +58.5% |
| ⚪ | bs=1000 sw=10 sl=64 | 913 | 0.557 | 1,095,712/1,150,204/1,150,204 us | ⚪ within ±5% / 🔴 +11.9% |
<details><summary>Baseline details</summary>
Latest main `a61702f` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 363 tuples/sec | 424 tuples/sec | 786.12 tuples/sec | -14.4% | -53.8% |
| bs=10 sw=10 sl=64 | MB/s | 0.222 MB/s | 0.259 MB/s | 0.48 MB/s | -14.3% | -53.7% |
| bs=10 sw=10 sl=64 | p50 | 25,238 us | 24,385 us | 12,305 us | +3.5% | +105.1% |
| bs=10 sw=10 sl=64 | p95 | 37,117 us | 32,669 us | 15,774 us | +13.6% | +135.3% |
| bs=10 sw=10 sl=64 | p99 | 37,117 us | 32,669 us | 18,978 us | +13.6% | +95.6% |
| bs=100 sw=10 sl=64 | throughput | 781 tuples/sec | 844 tuples/sec | 999.71 tuples/sec | -7.5% | -21.9% |
| bs=100 sw=10 sl=64 | MB/s | 0.476 MB/s | 0.515 MB/s | 0.61 MB/s | -7.6% | -22.0% |
| bs=100 sw=10 sl=64 | p50 | 124,340 us | 115,509 us | 100,616 us | +7.6% | +23.6% |
| bs=100 sw=10 sl=64 | p95 | 170,211 us | 154,643 us | 107,356 us | +10.1% | +58.5% |
| bs=100 sw=10 sl=64 | p99 | 170,211 us | 154,643 us | 113,255 us | +10.1% | +50.3% |
| bs=1000 sw=10 sl=64 | throughput | 913 tuples/sec | 919 tuples/sec | 1,031 tuples/sec | -0.7% | -11.5% |
| bs=1000 sw=10 sl=64 | MB/s | 0.557 MB/s | 0.561 MB/s | 0.63 MB/s | -0.7% | -11.5% |
| bs=1000 sw=10 sl=64 | p50 | 1,095,712 us | 1,091,668 us | 980,328 us | +0.4% | +11.8% |
| bs=1000 sw=10 sl=64 | p95 | 1,150,204 us | 1,134,182 us | 1,027,528 us | +1.4% | +11.9% |
| bs=1000 sw=10 sl=64 | p99 | 1,150,204 us | 1,134,182 us | 1,054,298 us | +1.4% | +9.1% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,551.04,200,128000,363,0.222,25238.28,37117.07,37117.07
1,100,10,64,20,2562.41,2000,1280000,781,0.476,124339.89,170210.79,170210.79
2,1000,10,64,20,21913.00,20000,12800000,913,0.557,1095711.50,1150204.27,1150204.27
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(frontend): add the Models section to the dashboard [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7046:
URL: https://github.com/apache/texera/pull/7046#issuecomment-5122406233
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@Ma77Ball`, `@Yicong-Huang`, `@aglinxinyuan`
You can notify them by mentioning `@Ma77Ball`, `@Yicong-Huang`, `@aglinxinyuan` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org