You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Vadim Gritsenko <vg...@hns.com> on 2001/06/11 15:25:42 UTC
[Patch] ContentAggregator not releasing resources
Hello everybody,
Why searching for the reasons of poor cache performance,
I found that ContentAggregator is not releasing event pipelines
in all cases. It does that only on errorless generate() calls...
If exception occur or cache is valid, pipelines are not released.
This patch solves that problem, but first Avalon's Excalibur must
be fixed to eliminate deadlock in DefaultPool implementation
(see my previous email).
Patch is attached.
Vadim
---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org
Re: [Patch] ContentAggregator not releasing resources
Posted by Berin Loritsch <bl...@apache.org>.
giacomo wrote:
>
> On Tue, 12 Jun 2001, Vadim Gritsenko wrote:
>
> > You are 100% right!
> >
> > Do not forget to put latest Avalon - or you will get deadlock in the DefaultPool.
>
> Uh, should I wait until Avalon beta4 is out?
I am testing an upgrade now that will allow you to set pool sizes for the
individual components. Once done, I will commit the current build. Since
this really only affects a few users right now (namely Cocoon). I want to
get some more docs in Beta 4 for the official release.
>
> Giacomo
>
> >
> > Now patch is attached.
> >
> > Vadim
> >
> > > -----Original Message-----
> > > From: giacomo [mailto:giacomo@apache.org]
> > > Sent: Tuesday, June 12, 2001 11:13
> > > To: Cocoon Developers
> > > Subject: Re: [Patch] ContentAggregator not releasing resources
> > >
> > >
> > > On Mon, 11 Jun 2001, Vadim Gritsenko wrote:
> > >
> > > > Hello everybody,
> > > >
> > > > Why searching for the reasons of poor cache performance,
> > > > I found that ContentAggregator is not releasing event pipelines
> > > > in all cases. It does that only on errorless generate() calls...
> > > > If exception occur or cache is valid, pipelines are not released.
> > > >
> > > > This patch solves that problem, but first Avalon's Excalibur must
> > > > be fixed to eliminate deadlock in DefaultPool implementation
> > > > (see my previous email).
> > > >
> > > > Patch is attached.
> > >
> > > Haven't found your patch. Maybe you forgot to attech it?
> > >
> > > Giacomo
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> > > For additional commands, email: cocoon-dev-help@xml.apache.org
> > >
> > >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org
RE: [Patch] ContentAggregator not releasing resources
Posted by giacomo <gi...@apache.org>.
On Tue, 12 Jun 2001, Vadim Gritsenko wrote:
> You are 100% right!
>
> Do not forget to put latest Avalon - or you will get deadlock in the DefaultPool.
Uh, should I wait until Avalon beta4 is out?
Giacomo
>
> Now patch is attached.
>
> Vadim
>
> > -----Original Message-----
> > From: giacomo [mailto:giacomo@apache.org]
> > Sent: Tuesday, June 12, 2001 11:13
> > To: Cocoon Developers
> > Subject: Re: [Patch] ContentAggregator not releasing resources
> >
> >
> > On Mon, 11 Jun 2001, Vadim Gritsenko wrote:
> >
> > > Hello everybody,
> > >
> > > Why searching for the reasons of poor cache performance,
> > > I found that ContentAggregator is not releasing event pipelines
> > > in all cases. It does that only on errorless generate() calls...
> > > If exception occur or cache is valid, pipelines are not released.
> > >
> > > This patch solves that problem, but first Avalon's Excalibur must
> > > be fixed to eliminate deadlock in DefaultPool implementation
> > > (see my previous email).
> > >
> > > Patch is attached.
> >
> > Haven't found your patch. Maybe you forgot to attech it?
> >
> > Giacomo
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> > For additional commands, email: cocoon-dev-help@xml.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org
RE: [Patch] ContentAggregator not releasing resources
Posted by Vadim Gritsenko <vg...@hns.com>.
You are 100% right!
Do not forget to put latest Avalon - or you will get deadlock in the DefaultPool.
Now patch is attached.
Vadim
> -----Original Message-----
> From: giacomo [mailto:giacomo@apache.org]
> Sent: Tuesday, June 12, 2001 11:13
> To: Cocoon Developers
> Subject: Re: [Patch] ContentAggregator not releasing resources
>
>
> On Mon, 11 Jun 2001, Vadim Gritsenko wrote:
>
> > Hello everybody,
> >
> > Why searching for the reasons of poor cache performance,
> > I found that ContentAggregator is not releasing event pipelines
> > in all cases. It does that only on errorless generate() calls...
> > If exception occur or cache is valid, pipelines are not released.
> >
> > This patch solves that problem, but first Avalon's Excalibur must
> > be fixed to eliminate deadlock in DefaultPool implementation
> > (see my previous email).
> >
> > Patch is attached.
>
> Haven't found your patch. Maybe you forgot to attech it?
>
> Giacomo
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
>
>
Re: [Patch] ContentAggregator not releasing resources
Posted by giacomo <gi...@apache.org>.
On Mon, 11 Jun 2001, Vadim Gritsenko wrote:
> Hello everybody,
>
> Why searching for the reasons of poor cache performance,
> I found that ContentAggregator is not releasing event pipelines
> in all cases. It does that only on errorless generate() calls...
> If exception occur or cache is valid, pipelines are not released.
>
> This patch solves that problem, but first Avalon's Excalibur must
> be fixed to eliminate deadlock in DefaultPool implementation
> (see my previous email).
>
> Patch is attached.
Haven't found your patch. Maybe you forgot to attech it?
Giacomo
---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org