You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Dragos Schebesch via Review Board <no...@reviews.apache.org> on 2018/07/11 11:52:37 UTC
Re: Review Request 67502: Refactored API functionality into separate
module.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/
-----------------------------------------------------------
(Updated July 11, 2018, 11:52 a.m.)
Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
Summary (updated)
-----------------
Refactored API functionality into separate module.
Repository: mesos
Description (updated)
-------
Refactored API functionality into separate module.
Diffs (updated)
-----
support/python3/common.py PRE-CREATION
Diff: https://reviews.apache.org/r/67502/diff/3/
Changes: https://reviews.apache.org/r/67502/diff/2-3/
Testing
-------
Thanks,
Dragos Schebesch
Re: Review Request 67502: Refactored ReviewBoard API functionality
into separate module.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/#review206381
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On July 19, 2018, 3:48 p.m., Dragos Schebesch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67502/
> -----------------------------------------------------------
>
> (Updated July 19, 2018, 3:48 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactored API functionality into separate module -- this was done to clean up the codebase and put all API calls in single place.
>
>
> Diffs
> -----
>
> support/python3/common.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67502/diff/4/
>
>
> Testing
> -------
>
> For example, to call the api on a specific review_url, with some data, we would use the following code:
>
> ```
> ReviewBoardHandler().api(review_url, data)
> ```
>
>
> Thanks,
>
> Dragos Schebesch
>
>
Re: Review Request 67502: Refactored ReviewBoard API functionality
into separate module.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/#review206908
-----------------------------------------------------------
support/python3/common.py
Lines 146 (patched)
<https://reviews.apache.org/r/67502/#comment290034>
Pylint complains that there are too many local variables, you can remove `latest_diff_url` to have only 15 vars in the file.
- Armand Grillet
On July 19, 2018, 3:48 p.m., Dragos Schebesch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67502/
> -----------------------------------------------------------
>
> (Updated July 19, 2018, 3:48 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactored API functionality into separate module -- this was done to clean up the codebase and put all API calls in single place.
>
>
> Diffs
> -----
>
> support/python3/common.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67502/diff/4/
>
>
> Testing
> -------
>
> For example, to call the api on a specific review_url, with some data, we would use the following code:
>
> ```
> ReviewBoardHandler().api(review_url, data)
> ```
>
>
> Thanks,
>
> Dragos Schebesch
>
>
Re: Review Request 67502: Refactored ReviewBoard API functionality
into separate module.
Posted by Dragos Schebesch via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/
-----------------------------------------------------------
(Updated Aug. 16, 2018, 6:52 p.m.)
Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
Repository: mesos
Description
-------
Refactored ReviewBoard API functionality into separate module.
Diffs (updated)
-----
support/python3/common.py PRE-CREATION
Diff: https://reviews.apache.org/r/67502/diff/6/
Changes: https://reviews.apache.org/r/67502/diff/5-6/
Testing
-------
For example, to call the api on a specific review_url, with some data, we would use the following code:
```
ReviewBoardHandler().api(review_url, data)
```
Thanks,
Dragos Schebesch
Re: Review Request 67502: Refactored ReviewBoard API functionality
into separate module.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/#review207241
-----------------------------------------------------------
Fix it, then Ship it!
support/python3/common.py
Lines 153-154 (patched)
<https://reviews.apache.org/r/67502/#comment290552>
I actually disagree with the TODO here: we often use an empty diff (but a new iteration of the review) to purposefully trigger the Review Bot.
- Andrew Schwartzmeyer
On Aug. 7, 2018, 10:36 a.m., Dragos Schebesch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67502/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 10:36 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactored ReviewBoard API functionality into separate module.
>
>
> Diffs
> -----
>
> support/python3/common.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67502/diff/5/
>
>
> Testing
> -------
>
> For example, to call the api on a specific review_url, with some data, we would use the following code:
>
> ```
> ReviewBoardHandler().api(review_url, data)
> ```
>
>
> Thanks,
>
> Dragos Schebesch
>
>
Re: Review Request 67502: Refactored ReviewBoard API functionality
into separate module.
Posted by Dragos Schebesch via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/
-----------------------------------------------------------
(Updated Aug. 7, 2018, 5:36 p.m.)
Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
Repository: mesos
Description (updated)
-------
Refactored ReviewBoard API functionality into separate module.
Diffs (updated)
-----
support/python3/common.py PRE-CREATION
Diff: https://reviews.apache.org/r/67502/diff/5/
Changes: https://reviews.apache.org/r/67502/diff/4-5/
Testing
-------
For example, to call the api on a specific review_url, with some data, we would use the following code:
```
ReviewBoardHandler().api(review_url, data)
```
Thanks,
Dragos Schebesch
Re: Review Request 67502: Refactored ReviewBoard API functionality
into separate module.
Posted by Dragos Schebesch via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/
-----------------------------------------------------------
(Updated July 19, 2018, 3:48 p.m.)
Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
Repository: mesos
Description (updated)
-------
Refactored API functionality into separate module -- this was done to clean up the codebase and put all API calls in single place.
Diffs
-----
support/python3/common.py PRE-CREATION
Diff: https://reviews.apache.org/r/67502/diff/4/
Testing
-------
For example, to call the api on a specific review_url, with some data, we would use the following code:
```
ReviewBoardHandler().api(review_url, data)
```
Thanks,
Dragos Schebesch
Re: Review Request 67502: Refactored ReviewBoard API functionality
into separate module.
Posted by Dragos Schebesch via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/
-----------------------------------------------------------
(Updated July 18, 2018, 8:50 a.m.)
Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
Summary (updated)
-----------------
Refactored ReviewBoard API functionality into separate module.
Repository: mesos
Description (updated)
-------
Refactored ReviewBoard API functionality into separate module.
Diffs (updated)
-----
support/python3/common.py PRE-CREATION
Diff: https://reviews.apache.org/r/67502/diff/4/
Changes: https://reviews.apache.org/r/67502/diff/3-4/
Testing (updated)
-------
For example, to call the api on a specific review_url, with some data, we would use the following code:
```
ReviewBoardHandler().api(review_url, data)
```
Thanks,
Dragos Schebesch
Re: Review Request 67502: Refactored API functionality into separate
module.
Posted by Dragos Schebesch via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/
-----------------------------------------------------------
(Updated July 11, 2018, 11:53 a.m.)
Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
Repository: mesos
Description
-------
Refactored API functionality into separate module.
Diffs
-----
support/python3/common.py PRE-CREATION
Diff: https://reviews.apache.org/r/67502/diff/3/
Testing (updated)
-------
Tests have been done later in the chain.
Thanks,
Dragos Schebesch