You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2015/04/01 17:04:53 UTC

[jira] [Commented] (HADOOP-8320) FileSystem#checkPath and AbstractFileSystem#checkPath should share code

    [ https://issues.apache.org/jira/browse/HADOOP-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390752#comment-14390752 ] 

Hadoop QA commented on HADOOP-8320:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12708691/HADOOP-8320.005.patch
  against trunk revision 2e79f1c.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.fs.TestFcLocalFsUtil
                  org.apache.hadoop.fs.TestLocalDirAllocator
                  org.apache.hadoop.io.file.tfile.TestTFileSeqFileComparison
                  org.apache.hadoop.fs.shell.TestCopy
                  org.apache.hadoop.util.TestDiskChecker
                  org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractAppend
                  org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractRename
                  org.apache.hadoop.fs.TestFileUtil
                  org.apache.hadoop.fs.contract.localfs.TestLocalFSContractOpen
                  org.apache.hadoop.security.ssl.TestSSLFactory
                  org.apache.hadoop.fs.TestFsShellCopy
                  org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem
                  org.apache.hadoop.fs.TestLocalFileSystem
                  org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractDelete
                  org.apache.hadoop.fs.shell.find.TestIname
                  org.apache.hadoop.fs.TestFSMainOperationsLocalFileSystem
                  org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem
                  org.apache.hadoop.io.file.tfile.TestTFileStreams
                  org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractOpen
                  org.apache.hadoop.fs.viewfs.TestViewFsWithAuthorityLocalFs
                  org.apache.hadoop.util.TestGenericOptionsParser
                  org.apache.hadoop.io.TestSetFile
                  org.apache.hadoop.fs.TestS3_LocalFileContextURI
                  org.apache.hadoop.crypto.key.TestKeyShell
                  org.apache.hadoop.fs.viewfs.TestViewFileSystemDelegationTokenSupport
                  org.apache.hadoop.fs.viewfs.TestViewFileSystemDelegation
                  org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractMkdir
                  org.apache.hadoop.io.compress.TestCodec
                  org.apache.hadoop.fs.TestGetFileBlockLocations
                  org.apache.hadoop.fs.viewfs.TestViewFsLocalFs
                  org.apache.hadoop.io.file.tfile.TestTFileNoneCodecsStreams
                  org.apache.hadoop.fs.TestChecksumFileSystem
                  org.apache.hadoop.fs.TestTruncatedInputBug
                  org.apache.hadoop.security.alias.TestCredShell
                  org.apache.hadoop.security.alias.TestCredentialProviderFactory
                  org.apache.hadoop.fs.contract.localfs.TestLocalFSContractCreate
                  org.apache.hadoop.io.TestMapFile
                  org.apache.hadoop.fs.TestPath
                  org.apache.hadoop.fs.viewfs.TestChRootedFs
                  org.apache.hadoop.security.TestLdapGroupsMapping
                  org.apache.hadoop.fs.TestFilterFileSystem
                  org.apache.hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem
                  org.apache.hadoop.fs.shell.TestPathData
                  org.apache.hadoop.fs.TestFileSystemInitialization
                  org.apache.hadoop.fs.shell.find.TestPrint0
                  org.apache.hadoop.io.TestArrayFile
                  org.apache.hadoop.fs.TestLocalFsFCStatistics
                  org.apache.hadoop.fs.TestLocalFileSystemPermission
                  org.apache.hadoop.fs.TestListFiles
                  org.apache.hadoop.fs.shell.find.TestFind
                  org.apache.hadoop.io.file.tfile.TestTFileByteArrays
                  org.apache.hadoop.io.file.tfile.TestTFileSplit
                  org.apache.hadoop.io.file.tfile.TestTFileSeek
                  org.apache.hadoop.fs.contract.localfs.TestLocalFSContractMkdir
                  org.apache.hadoop.io.file.tfile.TestTFileJClassComparatorByteArrays
                  org.apache.hadoop.fs.TestFsShellReturnCode
                  org.apache.hadoop.io.file.tfile.TestVLong
                  org.apache.hadoop.fs.TestHarFileSystemBasics
                  org.apache.hadoop.fs.TestTrash
                  org.apache.hadoop.crypto.key.TestKeyProviderFactory
                  org.apache.hadoop.fs.shell.TestLs
                  org.apache.hadoop.fs.shell.TestMove
                  org.apache.hadoop.io.file.tfile.TestTFileNoneCodecsJClassComparatorByteArrays
                  org.apache.hadoop.io.file.tfile.TestTFileComparators
                  org.apache.hadoop.fs.shell.find.TestName
                  org.apache.hadoop.util.TestNodeHealthScriptRunner
                  org.apache.hadoop.fs.contract.localfs.TestLocalFSContractAppend
                  org.apache.hadoop.io.TestSequenceFileSync
                  org.apache.hadoop.fs.viewfs.TestChRootedFileSystem
                  org.apache.hadoop.io.file.tfile.TestTFileUnsortedByteArrays
                  org.apache.hadoop.fs.TestLocalFSFileContextMainOperations
                  org.apache.hadoop.fs.TestAvroFSInput
                  org.apache.hadoop.fs.contract.localfs.TestLocalFSContractRename
                  org.apache.hadoop.fs.viewfs.TestFcPermissionsLocalFs
                  org.apache.hadoop.fs.shell.TestCount
                  org.apache.hadoop.fs.contract.localfs.TestLocalFSContractSeek
                  org.apache.hadoop.fs.TestSymlinkLocalFSFileContext
                  org.apache.hadoop.fs.contract.localfs.TestLocalFSContractLoaded
                  org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractCreate
                  org.apache.hadoop.fs.viewfs.TestViewFsTrash
                  org.apache.hadoop.fs.viewfs.TestViewfsFileStatus
                  org.apache.hadoop.io.file.tfile.TestTFileComparator2
                  org.apache.hadoop.fs.TestFcLocalFsPermission
                  org.apache.hadoop.fs.shell.TestCopyPreserveFlag
                  org.apache.hadoop.fs.TestLocalFSFileContextCreateMkdir
                  org.apache.hadoop.fs.shell.find.TestPrint
                  org.apache.hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem
                  org.apache.hadoop.fs.TestStat
                  org.apache.hadoop.fs.TestHarFileSystem
                  org.apache.hadoop.fs.viewfs.TestFcMainOperationsLocalFs
                  org.apache.hadoop.fs.contract.localfs.TestLocalFSContractDelete
                  org.apache.hadoop.io.TestBloomMapFile
                  org.apache.hadoop.fs.TestLocal_S3FileContextURI
                  org.apache.hadoop.io.TestSequenceFileSerialization
                  org.apache.hadoop.io.file.tfile.TestTFileNoneCodecsByteArrays
                  org.apache.hadoop.io.nativeio.TestNativeIO
                  org.apache.hadoop.fs.shell.TestAclCommands
                  org.apache.hadoop.io.TestSecureIOUtils
                  org.apache.hadoop.io.TestSequenceFile
                  org.apache.hadoop.io.file.tfile.TestTFile
                  org.apache.hadoop.fs.TestFileContextDeleteOnExit
                  org.apache.hadoop.fs.viewfs.TestViewFsURIs
                  org.apache.hadoop.fs.viewfs.TestFcCreateMkdirLocalFs
                  org.apache.hadoop.fs.TestFileContextResolveAfs
                  org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractSeek
                  org.apache.hadoop.crypto.TestCryptoStreamsForLocalFS
                  org.apache.hadoop.fs.shell.TestTextCommand
                  org.apache.hadoop.conf.TestConfiguration

                                      The following test timeouts occurred in hadoop-common-project/hadoop-common:

org.apache.hadoop.fs.TestFileSystemCaching

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6038//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6038//console

This message is automatically generated.

> FileSystem#checkPath and AbstractFileSystem#checkPath should share code
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-8320
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8320
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 2.0.0-alpha
>            Reporter: Aaron T. Myers
>            Assignee: Vijay Bhat
>            Priority: Minor
>         Attachments: HADOOP-8320.001.patch, HADOOP-8320.002.patch, HADOOP-8320.003.patch, HADOOP-8320.004.patch, HADOOP-8320.005.patch
>
>
> Per the discussion on HADOOP-8310, these two methods can be refactored to share some code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)