You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/09/27 01:14:55 UTC

[GitHub] [incubator-pinot] dongxiaoman opened a new issue #6063: Controller Metric missing a critical dot in it

dongxiaoman opened a new issue #6063:
URL: https://github.com/apache/incubator-pinot/issues/6063


   Right now the latest controller metric is missing one dot in its name, making them not easy to read:
   ```
   "org.apache.pinot.common.metrics":name="pinot.controllercontrollerInstanceDeleteError",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllercontrollerInstancePostError",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllercontrollerLeaderPartitionCount",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllercontrollerLeadershipChangeWithoutCallback",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllercontrollerRealtimeTableSegmentAssignmentError",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllercontrollerSchemaUploadError",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllercontrollerSegmentUploadError",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllercontrollerTableAddError",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllercontrollerTableSchemaUpdateError",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllercontrollerTableTenantCreateError",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllercontrollerTableTenantDeleteError",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllercontrollerTableTenantUpdateError",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllercontrollerTableUpdateError",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllerdataDir.exists",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllerdataDir.fileOpLatencyMs",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllerdisabledTableCount",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllerhealthcheckBadCalls",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllerhealthcheckOkCalls",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllerhelix.connected",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllerhelix.leader",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllerhelixZookeeperReconnects",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllernumberOfReplicas.point_transaction_entry_rt_REALTIME",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllernumberSegmentUploadTimeoutExceeded",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllernumberTimesScheduleTasksCalled",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllerofflineTableCount",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllerpercentOfReplicas.point_transaction_entry_rt_REALTIME",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllerpercentSegmentsAvailable.point_transaction_entry_rt_REALTIME",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllerperiodicTaskNumTablesProcessed",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllerpinotControllerLeader",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllerpinotLeadControllerResourceEnabled",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllerrealtimeTableCount",type="ControllerMetrics"
   "org.apache.pinot.common.metrics":name="pinot.controllersegmentsInErrorState.point_transaction_entry_rt_REALTIME",type="ControllerMetrics"
   ```
   For example pinot.**controllercontrollerInstancePostError** should have a "dot" in it, making pinot.controller.controllerInstancePostError


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] fx19880617 commented on issue #6063: Controller Metric missing a critical dot in it

Posted by GitBox <gi...@apache.org>.
fx19880617 commented on issue #6063:
URL: https://github.com/apache/incubator-pinot/issues/6063#issuecomment-703200911


   Agreed. I will take a look.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org