[GitHub] [sedona] Kimahriman commented on a diff in pull request #764: [WIP] [SEDONA-235] Integrate S2, add ST_S2CellIDs

["Kimahriman (via GitHub)" <gi...@apache.org>]

Kimahriman commented on code in PR #764:
URL: https://github.com/apache/sedona/pull/764#discussion_r1103834778


##########
sql/pom.xml:
##########
@@ -123,6 +123,11 @@
             <groupId>org.scalatest</groupId>
             <artifactId>scalatest_${scala.compat.version}</artifactId>
         </dependency>
+        <dependency>
+            <groupId>com.google.geometry</groupId>
+            <artifactId>s2-geometry</artifactId>
+            <version>2.0.0</version>
+        </dependency>

Review Comment:
   This is never reference directly in this module so I don't think you need to include this dependency here



##########
common/pom.xml:
##########
@@ -57,6 +57,11 @@
             <groupId>org.wololo</groupId>
             <artifactId>jts2geojson</artifactId>
         </dependency>
+        <dependency>
+            <groupId>com.google.geometry</groupId>
+            <artifactId>s2-geometry</artifactId>
+            <version>2.0.0</version>
+        </dependency>

Review Comment:
   Add this to the dependencyManagement section of the parent pom and only specify the version there



##########
common/src/main/java/org/apache/sedona/common/utils/GeomUtils.java:
##########
@@ -27,6 +27,8 @@
 
 import java.nio.ByteOrder;
 import java.util.*;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.LinkedBlockingQueue;

Review Comment:
   Doesn't look like these are used



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org