[GitHub] [kafka] philipnee commented on a diff in pull request #12862: Consumer refator find coordinator

[GitBox <gi...@apache.org>]

philipnee commented on code in PR #12862:
URL: https://github.com/apache/kafka/pull/12862#discussion_r1037502209


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java:
##########
@@ -145,19 +166,46 @@ void runOnce() {
             this.inflightEvent = Optional.empty();
         }
 
+        // TODO: Add a condition here, like shouldFindCoordinator in the future.  Since we don't always need to find
+        //  the coordinator.
+        if (coordinatorUnknown()) {

Review Comment:
   hmm, but I think we do want to check the connection against the networkClient here.  Given that we want to decouple the coordinatorManager from the networkClient.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org