You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:22:24 UTC
[GitHub] [cloudstack] apurv-1 opened a new pull request #5122: UI: Keyboard label shortcut
apurv-1 opened a new pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122
### Description
Issue #4798
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Screenshots (if appropriate):
https://user-images.githubusercontent.com/53378650/122402659-50f44b80-cf9b-11eb-81a2-18dfd5fe17b2.mp4
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-909027269
@apurv-1 can you merge latest main branch and address the merge conflict ? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-899372091
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5122 (SL-JID-523)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-881481529
@apurv-1 can you resolve the conflict, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-883985247
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1004736836
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-909038476
> @apurv-1 can you merge latest main branch and address the merge conflict ? Thanks.
Yeah Sure!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-873915002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-884133378
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5122 (SL-JID-403)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-899369352
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 edited a comment on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
apurv-1 edited a comment on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-902664681
@borisstoyanov, I've updated the keys!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov edited a comment on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
borisstoyanov edited a comment on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1029229506
> Looks mostly okay. One comment on changes that I feel are probably not a part of this PR. I could be completely wrong though Since `Comments` is a part of default UI, can we also have a shortcut for that? 
>
> @apurv-1 @borisstoyanov will it be a good idea to have some short info in CloudStack documentation about keyboard shortcuts?
Absolutely right @shwstppr, I think comments were added after the majority of work with this PR was done.
@apurv-1 do you have time to add this shortcut?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1059951980
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1031043921
@apurv-1 With the collapsed menu mode, the hint text is being cut off. I think you should hide it when the menu is collapsed.
Also is there a need for a keyboard shortcut for the Quota section?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-873914868
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-872855471
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1027707051
@Pearl1594 @shwstppr can you review this one and possibly merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1056834856
@apurv-1 sorry there are conflicts again, can you please fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1033047868
@apurv-1 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5122: we
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1043794182
Hi @apurv-1 can you please fix the title of the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1004649861
@apurv-1 sorry can you resolve the merge conflicts please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov removed a comment on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
borisstoyanov removed a comment on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-883926692
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on a change in pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on a change in pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#discussion_r799808486
##########
File path: ui/src/config/section/infra/secondaryStorages.js
##########
@@ -51,9 +52,19 @@ export default {
component: () => import('@/components/view/AnnotationsTab.vue')
}],
actions: [
+ {
+ api: 'migrateSecondaryStorageData',
+ icon: 'drag',
+ shortKey: ['m'],
+ label: 'label.migrate.data.from.image.store',
+ listView: true,
+ popup: true,
+ component: () => import('@/views/infra/MigrateData.vue')
+ },
Review comment:
I think I might have added the shortKey on the object but then It was removed(Since its here in this [PR #5103](https://github.com/apache/cloudstack/pull/5103/files#diff-03295e69be9bb1aec7bb1a7865447db525533f3ae3ef2fe19c5d2942312c50c2R64)).
But no worries I'll remove it. : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1004662697
> @apurv-1 sorry can you resolve the merge conflicts please.
No worries, done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1059951933
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#discussion_r821534893
##########
File path: ui/src/components/view/ActionButton.vue
##########
@@ -46,12 +46,15 @@
:shape="!dataView && action.icon === 'plus' ? 'round' : 'circle'"
style="margin-left: 5px"
:size="size"
+ v-shortkey="action.shortKey"
+ @shortkey="execAction(action)"
@click="execAction(action)">
<span v-if="!dataView && action.icon === 'plus'">
{{ $t(action.label) }}
</span>
<a-icon v-if="(typeof action.icon === 'string')" :type="action.icon" />
<font-awesome-icon v-else :icon="action.icon" />
+ <span class="view-shortkey" v-if="$store.getters.showshortkeys">{{ action.shortKey.length ? action.shortKey[0] : '' }}</span>
Review comment:
```suggestion
<span class="view-shortkey" v-if="$store.getters.showshortkeys && action.shortKey">{{ action.shortKey.length ? action.shortKey[0] : '' }}</span>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-891246432
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5122 (SL-JID-468)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-909038476
> @apurv-1 can you merge latest main branch and address the merge conflict ? Thanks.
Yeah Sure!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-909038476
> @apurv-1 can you merge latest main branch and address the merge conflict ? Thanks.
Yeah Sure!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-909027269
@apurv-1 can you merge latest main branch and address the merge conflict ? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-873849855
Hey @DaanHoogland , The PR is up for your review now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-868990104
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-883926692
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-902664681
> Hi @apurv-1, can we make some small cosmetic changes to the shortcuts please
>
> **Compute**
>
> * c + i = Instances
> * c + k = Kubernetes
>
> **Storage**
>
> * s + n = Snapshots
>
> **Networks**
>
> * n + g = Guest networks
> * n + v = VPC
> * n + c = VPN Customer Gateway
> * n + p = Public IP addresses
> * n + s = Security groups
>
> **Templates**
>
> * shft + t = templates
> * t + k = Kubernetes ISOs
> * t + i = ISOs
>
> **Service offerings**
>
> * shft + o = service offerings
> * o + c = compute offering
> * o + s = system offerings
> * o + d = disk offerings
> * o + b = bakcup offerings
> * o + n = network offerings
> * o + v = VPC offerings
>
> **Infrastructure:**
>
> * i + u = infra -> Summary
> * i + z = infra -> zones
> * i + P = infra -> pods
> * i + c = infra -> clusters
> * i + h = infra -> hosts
> * i + t = infra -> primary storage
> * i + s = infra -> secondary storage
> * i + v = infra -> system vms
> * i + r = infra -> virtual routers
> * i + L = infra -> instarnal LB
> * i + u = infra -> CPU Sockets
> * i + m = infra -> management servers
> * i + a = infra -> alerts
>
> **Configuration:**
>
> * shft + g = Global settings
> * g + L = LDAP settings
> * g + h = hypervisor capabilities
>
> **Tools:**
>
> * shft + x = import/export instances
>
> **Shortkey of VPN Customer Gateway cannot be seen**
> <img alt="Screenshot 2021-08-16 at 14 22 09" width="452" src="https://user-images.githubusercontent.com/13551960/129556052-e35fcb18-e363-4160-8641-6e717eb2ce68.png">
>
> **Hypervisor capabilities cannot be seen**
> <img alt="Screenshot 2021-08-16 at 14 27 50" width="312" src="https://user-images.githubusercontent.com/13551960/129556640-6f6963db-7d64-4281-af0b-b10760c0b19f.png">
Updated the keys!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-902666229
@apurv-1 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-899333684
UI build: :heavy_multiplication_x:
(SL-JID-522)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-881844008
> @apurv-1 can you resolve the conflict, please?
Done @DaanHoogland, but Its not completed yet!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-902665882
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#discussion_r798412278
##########
File path: ui/src/config/section/infra/secondaryStorages.js
##########
@@ -51,9 +52,19 @@ export default {
component: () => import('@/components/view/AnnotationsTab.vue')
}],
actions: [
+ {
+ api: 'migrateSecondaryStorageData',
+ icon: 'drag',
+ shortKey: ['m'],
+ label: 'label.migrate.data.from.image.store',
+ listView: true,
+ popup: true,
+ component: () => import('@/views/infra/MigrateData.vue')
+ },
Review comment:
@apurv-1 is this part of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1031339951
> @apurv-1 With the collapsed menu mode, the hint text is being cut off. I think you should hide it when the menu is collapsed.  Also is there a need for a keyboard shortcut for the Quota section? 
Okay sure!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1031036527
Hi @apurv-1 can you please fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-909027269
@apurv-1 can you merge latest main branch and address the merge conflict ? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1059952681
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5122 (SL-JID-1210)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1063672931
@apurv-1 Can you resolve the conflicts ? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1044182097
> Hi @apurv-1 can you please fix the title of the PR?
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-870348512
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-873929903
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1030346756
> > Looks mostly okay. One comment on changes that I feel are probably not a part of this PR. I could be completely wrong though Since `Comments` is a part of default UI, can we also have a shortcut for that? 
> > @apurv-1 @borisstoyanov will it be a good idea to have some short info in CloudStack documentation about keyboard shortcuts?
>
> Absolutely right @shwstppr, I think comments were added after the majority of work with this PR was done. @apurv-1 do you have time to add this shortcut?
Yeah sure, will add the shortKey for the comments too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1033047423
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1027733094
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-873914868
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-891243527
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov removed a comment on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
borisstoyanov removed a comment on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-883969726
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-888098609
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5122 (SL-JID-439)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-891244140
@borisstoyanov a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-888095655
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-883985538
@borisstoyanov a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-870348857
@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1004739888
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5122 (SL-JID-973)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1004736345
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1033051686
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5122 (SL-JID-1109)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-868990077
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-872855105
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-884129897
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-873915002
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 removed a comment on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
apurv-1 removed a comment on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-881843830
> @apurv-1 can you resolve the conflict, please?
Done @sureshanaparti!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1061640364
Thanks for resolving the conflicts @apurv-1
Can you address the comments and add shortkeys for all actions which are listed as `listview: true` in the .js files ?
Also, there are issues when there are shortkeys with common characters, which fails to navigate
eg: i+c, c+i, t+i, i+t, etc.
Just to be safe can the shortkeys be modified so that no character is repeated in different combos
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1027732602
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1027736347
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5122 (SL-JID-1086)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-872858082
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5122 (SL-JID-314)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-870348857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-881843830
> @apurv-1 can you resolve the conflict, please?
Done @sureshanaparti!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-899332504
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 edited a comment on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
apurv-1 edited a comment on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-902664681
> Hi @apurv-1, can we make some small cosmetic changes to the shortcuts please
>
> **Compute**
>
> * c + i = Instances
> * c + k = Kubernetes
>
> **Storage**
>
> * s + n = Snapshots
>
> **Networks**
>
> * n + g = Guest networks
> * n + v = VPC
> * n + c = VPN Customer Gateway
> * n + p = Public IP addresses
> * n + s = Security groups
>
> **Templates**
>
> * shft + t = templates
> * t + k = Kubernetes ISOs
> * t + i = ISOs
>
> **Service offerings**
>
> * shft + o = service offerings
> * o + c = compute offering
> * o + s = system offerings
> * o + d = disk offerings
> * o + b = bakcup offerings
> * o + n = network offerings
> * o + v = VPC offerings
>
> **Infrastructure:**
>
> * i + u = infra -> Summary
> * i + z = infra -> zones
> * i + P = infra -> pods
> * i + c = infra -> clusters
> * i + h = infra -> hosts
> * i + t = infra -> primary storage
> * i + s = infra -> secondary storage
> * i + v = infra -> system vms
> * i + r = infra -> virtual routers
> * i + L = infra -> instarnal LB
> * i + u = infra -> CPU Sockets
> * i + m = infra -> management servers
> * i + a = infra -> alerts
>
> **Configuration:**
>
> * shft + g = Global settings
> * g + L = LDAP settings
> * g + h = hypervisor capabilities
>
> **Tools:**
>
> * shft + x = import/export instances
>
> **Shortkey of VPN Customer Gateway cannot be seen**
> <img alt="Screenshot 2021-08-16 at 14 22 09" width="452" src="https://user-images.githubusercontent.com/13551960/129556052-e35fcb18-e363-4160-8641-6e717eb2ce68.png">
>
> **Hypervisor capabilities cannot be seen**
> <img alt="Screenshot 2021-08-16 at 14 27 50" width="312" src="https://user-images.githubusercontent.com/13551960/129556640-6f6963db-7d64-4281-af0b-b10760c0b19f.png">
Hi @borisstoyanov, I've updated the keys!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-870353899
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5122 (SL-JID-295)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1059946529
> @apurv-1 sorry there are conflicts again, can you please fix?
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#discussion_r821534616
##########
File path: ui/src/components/view/ActionButton.vue
##########
@@ -65,12 +68,15 @@
:shape="!dataView && ['plus', 'user-add'].includes(action.icon) ? 'round' : 'circle'"
style="margin-left: 5px"
:size="size"
+ v-shortkey="action.shortKey"
+ @shortkey="execAction(action)"
@click="execAction(action)">
<span v-if="!dataView && ['plus', 'user-add'].includes(action.icon)">
{{ $t(action.label) }}
</span>
<a-icon v-if="(typeof action.icon === 'string')" :type="action.icon" />
<font-awesome-icon v-else :icon="action.icon" />
+ <span class="view-shortkey" v-if="$store.getters.showshortkeys">{{ action.shortKey.length ? action.shortKey[0] : '' }}</span>
Review comment:
```suggestion
<span class="view-shortkey" v-if="$store.getters.showshortkeys && action.shortKey">{{ action.shortKey.length ? action.shortKey[0] : '' }}</span>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-892468316
@apurv-1 can you add shortcuts for 'Tools' section as well, it seems that it was added post factum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-899369594
@apurv-1 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-868990544
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5122 (SL-JID-288)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-899335100
@apurv-1 can you address the merge conflicts please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-884130432
@borisstoyanov a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-883992304
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5122 (SL-JID-402)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-888095951
@borisstoyanov a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-870348512
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-902670787
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5122 (SL-JID-542)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-899438205
Hi @apurv-1, can we make some small cosmetic changes to the shortcuts please
**Compute**
- c + i = Instances
- c + k = Kubernetes
**Storage**
- s + n = Snapshots
**Networks**
- n + g = Guest networks
- n + v = VPC
- n + c = VPN Customer Gateway
- n + p = Public IP addresses
- n + s = Security groups
**Templates**
- shft + t = templates
- t + k = Kubernetes ISOs
- t + i = ISOs
**Service offerings**
- shft + o = service offerings
- o + c = compute offering
- o + s = system offerings
- o + d = disk offerings
- o + b = bakcup offerings
- o + n = network offerings
- o + v = VPC offerings
**Infrastructure:**
- i + u = infra -> Summary
- i + z = infra -> zones
- i + P = infra -> pods
- i + c = infra -> clusters
- i + h = infra -> hosts
- i + t = infra -> primary storage
- i + s = infra -> secondary storage
- i + v = infra -> system vms
- i + r = infra -> virtual routers
- i + L = infra -> instarnal LB
- i + u = infra -> CPU Sockets
- i + m = infra -> management servers
- i + a = infra -> alerts
**Configuration:**
- shft + g = Global settings
- g + L = LDAP settings
- g + h = hypervisor capabilities
**Tools:**
- shft + x = import/export instances
**Shortkey of VPN Customer Gateway cannot be seen**
<img width="452" alt="Screenshot 2021-08-16 at 14 22 09" src="https://user-images.githubusercontent.com/13551960/129556052-e35fcb18-e363-4160-8641-6e717eb2ce68.png">
**Hypervisor capabilities cannot be seen**
<img width="312" alt="Screenshot 2021-08-16 at 14 27 50" src="https://user-images.githubusercontent.com/13551960/129556640-6f6963db-7d64-4281-af0b-b10760c0b19f.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-883926914
@apurv-1 can you address the conflicts please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-899333085
@borisstoyanov a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-883969726
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5122: UI: Keyboard label shortcut
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5122:
URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-1029229506
> Looks mostly okay. One comment on changes that I feel are probably not a part of this PR. I could be completely wrong though Since `Comments` is a part of default UI, can we also have a shortcut for that? 
>
> @apurv-1 @borisstoyanov will it be a good idea to have some short info in CloudStack documentation about keyboard shortcuts?
Absolutely right @shwstppr, I think that was added after the majority of work with this PR was done.
@apurv-1 do you have time to add this shortcut?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org