You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/23 05:41:33 UTC
[GitHub] [pulsar] lightzhao opened a new pull request, #17813: unload bundle causes topic fence, OpAddEntry NPE appears in addComple…
lightzhao opened a new pull request, #17813:
URL: https://github.com/apache/pulsar/pull/17813
…te. #17737
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
-->
<!-- Either this PR fixes an issue, -->
Fixes #unload bundle causes topic fence, OpAddEntry NPE appears in addComplete
<!-- or this PR is one task of an issue -->
Master Issue: #17737
### Motivation
<!-- Explain here the context, and why you're making that change. What is the problem you're trying to solve. -->
### Modifications
<!-- Describe the modifications you've done. -->
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #17813: unload bundle causes topic fence, OpAddEntry NPE appears in addComple…
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #17813:
URL: https://github.com/apache/pulsar/pull/17813#issuecomment-1255853182
This is a problem that should be fixed, but it would need a proper fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #17813: unload bundle causes topic fence, OpAddEntry NPE appears in addComple…
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #17813:
URL: https://github.com/apache/pulsar/pull/17813#issuecomment-1255852505
please see https://github.com/apache/pulsar/pull/15090/files#r846562410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #17813: unload bundle causes topic fence, OpAddEntry NPE appears in addComple…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17813:
URL: https://github.com/apache/pulsar/pull/17813#issuecomment-1308106906
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #17813: unload bundle causes topic fence, OpAddEntry NPE appears in addComple…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17813:
URL: https://github.com/apache/pulsar/pull/17813#issuecomment-1255829238
@lightzhao Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lightzhao closed pull request #17813: unload bundle causes topic fence, OpAddEntry NPE appears in addComple…
Posted by GitBox <gi...@apache.org>.
lightzhao closed pull request #17813: unload bundle causes topic fence, OpAddEntry NPE appears in addComple…
URL: https://github.com/apache/pulsar/pull/17813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #17813: unload bundle causes topic fence, OpAddEntry NPE appears in addComple…
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #17813:
URL: https://github.com/apache/pulsar/pull/17813#issuecomment-1255852623
duplicates #15090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lightzhao commented on pull request #17813: unload bundle causes topic fence, OpAddEntry NPE appears in addComple…
Posted by GitBox <gi...@apache.org>.
lightzhao commented on PR #17813:
URL: https://github.com/apache/pulsar/pull/17813#issuecomment-1272684248
> by-passing this check doesn't make sense.
>
> Why is the ledger null in the first place? Please share a stacktrace and more context about the issue.
OK, I'll take a look. Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org