You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/05/17 21:52:17 UTC
[GitHub] [pulsar] codecov-commenter commented on pull request #20299: [improve][ws] Use allowTopicOperationAsync for authz checks
codecov-commenter commented on PR #20299:
URL: https://github.com/apache/pulsar/pull/20299#issuecomment-1552135348
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20299?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#20299](https://app.codecov.io/gh/apache/pulsar/pull/20299?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f80cc11) into [master](https://app.codecov.io/gh/apache/pulsar/commit/bc1764f9ef71dd31e8cd61c7571e493442bc6395?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bc1764f) will **increase** coverage by `2.96%`.
> The diff coverage is `18.18%`.
[](https://app.codecov.io/gh/apache/pulsar/pull/20299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #20299 +/- ##
============================================
+ Coverage 34.48% 37.45% +2.96%
+ Complexity 12528 644 -11884
============================================
Files 1614 1692 +78
Lines 126177 131881 +5704
Branches 13772 14829 +1057
============================================
+ Hits 43508 49391 +5883
+ Misses 77051 76041 -1010
- Partials 5618 6449 +831
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.18% <18.18%> (+0.04%)` | :arrow_up: |
| systests | `24.97% <3.77%> (?)` | |
| unittests | `33.19% <16.66%> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pulsar/pull/20299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...r/broker/authentication/AuthenticationService.java](https://app.codecov.io/gh/apache/pulsar/pull/20299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9icm9rZXIvYXV0aGVudGljYXRpb24vQXV0aGVudGljYXRpb25TZXJ2aWNlLmphdmE=) | `36.19% <0.00%> (+2.19%)` | :arrow_up: |
| [...rvice/nonpersistent/NonPersistentSubscription.java](https://app.codecov.io/gh/apache/pulsar/pull/20299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL25vbnBlcnNpc3RlbnQvTm9uUGVyc2lzdGVudFN1YnNjcmlwdGlvbi5qYXZh) | `27.91% <0.00%> (-9.34%)` | :arrow_down: |
| [...a/org/apache/pulsar/websocket/ConsumerHandler.java](https://app.codecov.io/gh/apache/pulsar/pull/20299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLXdlYnNvY2tldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL3dlYnNvY2tldC9Db25zdW1lckhhbmRsZXIuamF2YQ==) | `25.40% <0.00%> (-1.18%)` | :arrow_down: |
| [...a/org/apache/pulsar/websocket/ProducerHandler.java](https://app.codecov.io/gh/apache/pulsar/pull/20299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLXdlYnNvY2tldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL3dlYnNvY2tldC9Qcm9kdWNlckhhbmRsZXIuamF2YQ==) | `31.03% <0.00%> (-1.90%)` | :arrow_down: |
| [...ava/org/apache/pulsar/websocket/ReaderHandler.java](https://app.codecov.io/gh/apache/pulsar/pull/20299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLXdlYnNvY2tldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL3dlYnNvY2tldC9SZWFkZXJIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...oker/service/nonpersistent/NonPersistentTopic.java](https://app.codecov.io/gh/apache/pulsar/pull/20299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL25vbnBlcnNpc3RlbnQvTm9uUGVyc2lzdGVudFRvcGljLmphdmE=) | `45.74% <66.66%> (-4.69%)` | :arrow_down: |
| [...va/org/apache/pulsar/client/impl/ConsumerImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/20299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL0NvbnN1bWVySW1wbC5qYXZh) | `56.62% <100.00%> (-3.57%)` | :arrow_down: |
| [...he/pulsar/client/impl/MultiTopicsConsumerImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/20299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL011bHRpVG9waWNzQ29uc3VtZXJJbXBsLmphdmE=) | `47.58% <100.00%> (+0.30%)` | :arrow_up: |
... and [413 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20299/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org