You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/18 10:00:02 UTC
[GitHub] [arrow-datafusion] Jimexist opened a new pull request #742: fix pyarrow type id mapping in `python` crate
Jimexist opened a new pull request #742:
URL: https://github.com/apache/arrow-datafusion/pull/742
# Which issue does this PR close?
fix pyarrow type id mapping in `python` crate
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #742: fix pyarrow type id mapping in `python` crate
Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #742:
URL: https://github.com/apache/arrow-datafusion/pull/742#discussion_r671817228
##########
File path: python/src/types.rs
##########
@@ -48,24 +48,13 @@ fn data_type_id(id: &i32) -> Result<DataType, errors::DataFusionError> {
7 => DataType::Int32,
8 => DataType::UInt64,
9 => DataType::Int64,
-
10 => DataType::Float16,
11 => DataType::Float32,
12 => DataType::Float64,
-
- //13 => DataType::Decimal,
-
- // 14 => DataType::Date32(),
- // 15 => DataType::Date64(),
- // 16 => DataType::Timestamp(),
- // 17 => DataType::Time32(),
- // 18 => DataType::Time64(),
- // 19 => DataType::Duration()
- 20 => DataType::Binary,
- 21 => DataType::Utf8,
- 22 => DataType::LargeBinary,
- 23 => DataType::LargeUtf8,
-
+ 13 => DataType::Utf8,
Review comment:
previously it'll throw because `pa.string()` is with `id` 13, not 20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #742: fix pyarrow type id mapping in `python` crate
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #742:
URL: https://github.com/apache/arrow-datafusion/pull/742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #742: fix pyarrow type id mapping in `python` crate
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #742:
URL: https://github.com/apache/arrow-datafusion/pull/742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #742: fix pyarrow type id mapping in `python` crate
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #742:
URL: https://github.com/apache/arrow-datafusion/pull/742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #742: fix pyarrow type id mapping in `python` crate
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #742:
URL: https://github.com/apache/arrow-datafusion/pull/742#discussion_r671827651
##########
File path: python/tests/test_pa_types.py
##########
@@ -0,0 +1,51 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import pyarrow as pa
+
+
+def test_type_ids():
+ """having this fixed is very important because internally we rely on this id to parse from
+ python"""
+ for idx, arrow_type in [
+ (0, pa.null()),
+ (1, pa.bool_()),
+ (2, pa.uint8()),
+ (3, pa.int8()),
+ (4, pa.uint16()),
+ (5, pa.int16()),
+ (6, pa.uint32()),
+ (7, pa.int32()),
+ (8, pa.uint64()),
+ (9, pa.int64()),
+ (10, pa.float16()),
+ (11, pa.float32()),
+ (12, pa.float64()),
+ (13, pa.string()),
Review comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org