You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "shreemaan-abhishek (via GitHub)" <gi...@apache.org> on 2023/07/27 16:44:21 UTC
[GitHub] [apisix] shreemaan-abhishek opened a new pull request, #9919: fix: avoid using nightly version of openwhisk
shreemaan-abhishek opened a new pull request, #9919:
URL: https://github.com/apache/apisix/pull/9919
### Description
The CI uses the nightly version of Openwhisk which might result in inconsistent behavior or build failure altogether.
cc: @kingluo
Fixes # (issue)
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 merged pull request #9919: fix: avoid using nightly version of openwhisk
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 merged PR #9919:
URL: https://github.com/apache/apisix/pull/9919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #9919: fix: avoid using nightly version of openwhisk
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on code in PR #9919:
URL: https://github.com/apache/apisix/pull/9919#discussion_r1277078823
##########
ci/init-plugin-test-service.sh:
##########
@@ -22,8 +22,8 @@ after() {
docker exec -i apache-apisix_kafka-server2_1 /opt/bitnami/kafka/bin/kafka-topics.sh --create --zookeeper zookeeper-server2:2181 --replication-factor 1 --partitions 1 --topic test4
# prepare openwhisk env
- docker pull openwhisk/action-nodejs-v14:nightly
- docker run --rm -d --name openwhisk -p 3233:3233 -p 3232:3232 -v /var/run/docker.sock:/var/run/docker.sock openwhisk/standalone:nightly
+ docker pull openwhisk/action-nodejs-v14:7545841
Review Comment:
@monkeyDluffy6017, it does not represent any version I suppose because, in the openwhisk docker hub, the tags were specified like random numbers (no semantically versioned tags were available). I just found a combination of tags that worked well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #9919: fix: avoid using nightly version of openwhisk
Posted by "moonming (via GitHub)" <gi...@apache.org>.
moonming commented on PR #9919:
URL: https://github.com/apache/apisix/pull/9919#issuecomment-1657431580
@monkeyDluffy6017 review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9919: fix: avoid using nightly version of openwhisk
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #9919:
URL: https://github.com/apache/apisix/pull/9919#discussion_r1277156231
##########
ci/init-plugin-test-service.sh:
##########
@@ -22,8 +22,8 @@ after() {
docker exec -i apache-apisix_kafka-server2_1 /opt/bitnami/kafka/bin/kafka-topics.sh --create --zookeeper zookeeper-server2:2181 --replication-factor 1 --partitions 1 --topic test4
# prepare openwhisk env
- docker pull openwhisk/action-nodejs-v14:nightly
- docker run --rm -d --name openwhisk -p 3233:3233 -p 3232:3232 -v /var/run/docker.sock:/var/run/docker.sock openwhisk/standalone:nightly
+ docker pull openwhisk/action-nodejs-v14:7545841
Review Comment:
It's very werid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on a diff in pull request #9919: fix: avoid using nightly version of openwhisk
Posted by "moonming (via GitHub)" <gi...@apache.org>.
moonming commented on code in PR #9919:
URL: https://github.com/apache/apisix/pull/9919#discussion_r1278716045
##########
ci/init-plugin-test-service.sh:
##########
@@ -22,8 +22,8 @@ after() {
docker exec -i apache-apisix_kafka-server2_1 /opt/bitnami/kafka/bin/kafka-topics.sh --create --zookeeper zookeeper-server2:2181 --replication-factor 1 --partitions 1 --topic test4
# prepare openwhisk env
- docker pull openwhisk/action-nodejs-v14:nightly
- docker run --rm -d --name openwhisk -p 3233:3233 -p 3232:3232 -v /var/run/docker.sock:/var/run/docker.sock openwhisk/standalone:nightly
+ docker pull openwhisk/action-nodejs-v14:7545841
Review Comment:
can we use `docker pull openwhisk/action-nodejs-v14:latest`?
##########
ci/init-plugin-test-service.sh:
##########
@@ -22,8 +22,8 @@ after() {
docker exec -i apache-apisix_kafka-server2_1 /opt/bitnami/kafka/bin/kafka-topics.sh --create --zookeeper zookeeper-server2:2181 --replication-factor 1 --partitions 1 --topic test4
# prepare openwhisk env
- docker pull openwhisk/action-nodejs-v14:nightly
- docker run --rm -d --name openwhisk -p 3233:3233 -p 3232:3232 -v /var/run/docker.sock:/var/run/docker.sock openwhisk/standalone:nightly
+ docker pull openwhisk/action-nodejs-v14:7545841
+ docker run --rm -d --name openwhisk -p 3233:3233 -p 3232:3232 -v /var/run/docker.sock:/var/run/docker.sock openwhisk/standalone:de3e0a8
Review Comment:
What's the version of `docker pull openwhisk/standalone` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9919: fix: avoid using nightly version of openwhisk
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #9919:
URL: https://github.com/apache/apisix/pull/9919#discussion_r1276994978
##########
ci/init-plugin-test-service.sh:
##########
@@ -22,8 +22,8 @@ after() {
docker exec -i apache-apisix_kafka-server2_1 /opt/bitnami/kafka/bin/kafka-topics.sh --create --zookeeper zookeeper-server2:2181 --replication-factor 1 --partitions 1 --topic test4
# prepare openwhisk env
- docker pull openwhisk/action-nodejs-v14:nightly
- docker run --rm -d --name openwhisk -p 3233:3233 -p 3232:3232 -v /var/run/docker.sock:/var/run/docker.sock openwhisk/standalone:nightly
+ docker pull openwhisk/action-nodejs-v14:7545841
Review Comment:
What version does this id represent?
##########
ci/init-plugin-test-service.sh:
##########
@@ -22,8 +22,8 @@ after() {
docker exec -i apache-apisix_kafka-server2_1 /opt/bitnami/kafka/bin/kafka-topics.sh --create --zookeeper zookeeper-server2:2181 --replication-factor 1 --partitions 1 --topic test4
# prepare openwhisk env
- docker pull openwhisk/action-nodejs-v14:nightly
- docker run --rm -d --name openwhisk -p 3233:3233 -p 3232:3232 -v /var/run/docker.sock:/var/run/docker.sock openwhisk/standalone:nightly
+ docker pull openwhisk/action-nodejs-v14:7545841
Review Comment:
Which version does this id represent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9919: fix: avoid using nightly version of openwhisk
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #9919:
URL: https://github.com/apache/apisix/pull/9919#issuecomment-1657434801
@moonming It's not ready now, the image is a temporary version
```
docker pull openwhisk/action-nodejs-v14:7545841
```
I suggest use a digital and formal versison, like
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #9919: fix: avoid using nightly version of openwhisk
Posted by "moonming (via GitHub)" <gi...@apache.org>.
moonming commented on PR #9919:
URL: https://github.com/apache/apisix/pull/9919#issuecomment-1657431136
> @moonming latest or nightly can't fix the version and will create conflicts when dependencies change.
>
> https://github.com/apache/apisix/blob/cea8f10dce6336e1e09566e23f3e9ff24a5a1924/ci/init-plugin-test-service.sh#L25-L35
>
> ```
> 2023-07-27T07:35:35.8965822Z ok: updated action testme
> 2023-07-27T07:35:42.8525542Z "ready": true
> 2023-07-27T07:35:43.3148176Z ok: deleted action testme
> 2023-07-27T07:35:44.0565688Z ok: created package pkg
> 2023-07-27T07:35:44.7900623Z error: Unable to create action 'pkg/testpkg': The request content was malformed:
> 2023-07-27T07:35:44.7916960Z The specified runtime 'nodejs:14' is not supported by this platform. Valid values are: 'php:8.1', 'python:3.11', 'ruby:2.5', 'nodejs:18', 'dotnet:3.1', 'blackbox', 'python:3.10', 'rust:1.34', 'swift:5.7', 'java:8', 'sequence', 'dotnet:6.0', 'go:1.20', 'swift:5.3', 'nodejs:20'. (code h8by3ms1qmPROJuVOdStDv4kDyQYohmV)
> 2023-07-27T07:35:44.7923721Z Run 'wsk --help' for usage.
> ```
>
> Therefore, one needs to choose a dedicated version pair that works well.
Got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kingluo commented on pull request #9919: fix: avoid using nightly version of openwhisk
Posted by "kingluo (via GitHub)" <gi...@apache.org>.
kingluo commented on PR #9919:
URL: https://github.com/apache/apisix/pull/9919#issuecomment-1657430199
@moonming latest or nightly can't fix the version and will create conflicts when dependencies change.
https://github.com/apache/apisix/blob/cea8f10dce6336e1e09566e23f3e9ff24a5a1924/ci/init-plugin-test-service.sh#L25-L35
```
2023-07-27T07:35:35.8965822Z ok: updated action testme
2023-07-27T07:35:42.8525542Z "ready": true
2023-07-27T07:35:43.3148176Z ok: deleted action testme
2023-07-27T07:35:44.0565688Z ok: created package pkg
2023-07-27T07:35:44.7900623Z error: Unable to create action 'pkg/testpkg': The request content was malformed:
2023-07-27T07:35:44.7916960Z The specified runtime 'nodejs:14' is not supported by this platform. Valid values are: 'php:8.1', 'python:3.11', 'ruby:2.5', 'nodejs:18', 'dotnet:3.1', 'blackbox', 'python:3.10', 'rust:1.34', 'swift:5.7', 'java:8', 'sequence', 'dotnet:6.0', 'go:1.20', 'swift:5.3', 'nodejs:20'. (code h8by3ms1qmPROJuVOdStDv4kDyQYohmV)
2023-07-27T07:35:44.7923721Z Run 'wsk --help' for usage.
```
Therefore, one needs to choose a dedicated version pair that works well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org