You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/24 22:10:54 UTC
[GitHub] [airflow] paulvic opened a new pull request #14436: Add max_retry_delay to be deserialized
paulvic opened a new pull request #14436:
URL: https://github.com/apache/airflow/pull/14436
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14436: BugFix: Serialize max_retry_delay as a timedelta
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14436:
URL: https://github.com/apache/airflow/pull/14436#discussion_r582377687
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -856,7 +860,7 @@ def test_no_new_fields_added_to_base_operator(self):
'executor_config': {},
'inlets': [],
'label': '10',
- 'max_retry_delay': None,
+ 'max_retry_delay': timedelta(0, 600),
Review comment:
This should still be None as we haven't changed the default value in the BaseOperator constructor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #14436: BugFix: Serialize max_retry_delay as a timedelta
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #14436:
URL: https://github.com/apache/airflow/pull/14436
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14436: BugFix: Serialize max_retry_delay as a timedelta
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14436:
URL: https://github.com/apache/airflow/pull/14436#issuecomment-786107364
[The Workflow run](https://github.com/apache/airflow/actions/runs/600360473) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] paulvic commented on pull request #14436: BugFix: Serialize max_retry_delay as a timedelta
Posted by GitBox <gi...@apache.org>.
paulvic commented on pull request #14436:
URL: https://github.com/apache/airflow/pull/14436#issuecomment-786611944
thanks @kaxil 🙇
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] paulvic commented on pull request #14436: BugFix: Serialize max_retry_delay as a timedelta
Posted by GitBox <gi...@apache.org>.
paulvic commented on pull request #14436:
URL: https://github.com/apache/airflow/pull/14436#issuecomment-786593097
Hi @kaxil, it appears that the `build docs` check was cancelled, but I don't see any way to re-trigger it. Any advice on how to proceed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] paulvic commented on a change in pull request #14436: BugFix: Serialize max_retry_delay as a timedelta
Posted by GitBox <gi...@apache.org>.
paulvic commented on a change in pull request #14436:
URL: https://github.com/apache/airflow/pull/14436#discussion_r582604316
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -856,7 +860,7 @@ def test_no_new_fields_added_to_base_operator(self):
'executor_config': {},
'inlets': [],
'label': '10',
- 'max_retry_delay': None,
+ 'max_retry_delay': timedelta(0, 600),
Review comment:
Gotcha 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14436: BugFix: Serialize max_retry_delay as a timedelta
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14436:
URL: https://github.com/apache/airflow/pull/14436#discussion_r582377687
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -856,7 +860,7 @@ def test_no_new_fields_added_to_base_operator(self):
'executor_config': {},
'inlets': [],
'label': '10',
- 'max_retry_delay': None,
+ 'max_retry_delay': timedelta(0, 600),
Review comment:
This should still be None as we haven't change the default value
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -856,7 +860,7 @@ def test_no_new_fields_added_to_base_operator(self):
'executor_config': {},
'inlets': [],
'label': '10',
- 'max_retry_delay': None,
+ 'max_retry_delay': timedelta(0, 600),
Review comment:
This should still be None as we haven't changed the default value
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org