You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wayang.apache.org by "juripetersen (via GitHub)" <gi...@apache.org> on 2023/11/21 10:23:43 UTC
[I] SqlContext has no option to configure platforms [incubator-wayang]
juripetersen opened a new issue, #378:
URL: https://github.com/apache/incubator-wayang/issues/378
The SqlContext's constructor hard-codes three platforms and provides no options to customise the desired plugins and therefore used platforms:
```java
public SqlContext(Configuration configuration) throws SQLException {
Configuration configuration1 = configuration.fork(String.format("SqlContext(%s)", configuration.getName()));
wayangContext = new WayangContext(configuration1)
.withPlugin(Java.basicPlugin())
.withPlugin(Spark.basicPlugin())
.withPlugin(Postgres.plugin());
calciteSchema = SchemaUtils.getSchema(configuration);
}
```
A proposed solution would be to change `SqlContext` so that it extends `WayangContext`, providing the desired functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SqlContext has no option to configure platforms [incubator-wayang]
Posted by "kbeedkar (via GitHub)" <gi...@apache.org>.
kbeedkar closed issue #378: SqlContext has no option to configure platforms
URL: https://github.com/apache/incubator-wayang/issues/378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SqlContext has no option to configure platforms [incubator-wayang]
Posted by "juripetersen (via GitHub)" <gi...@apache.org>.
juripetersen commented on issue #378:
URL: https://github.com/apache/incubator-wayang/issues/378#issuecomment-1820676133
@kbeedkar the PR is now linked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SqlContext has no option to configure platforms [incubator-wayang]
Posted by "kbeedkar (via GitHub)" <gi...@apache.org>.
kbeedkar commented on issue #378:
URL: https://github.com/apache/incubator-wayang/issues/378#issuecomment-1820669979
@juripetersen Indeed. Can you go ahead with your proposed solution and create a PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org