[GitHub] spark pull request #21433: [SPARK-23820][CORE] Enable use of long form of ca...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21433#discussion_r216209470
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/RDDInfo.scala ---
    @@ -53,10 +55,16 @@ class RDDInfo(
     }
     
     private[spark] object RDDInfo {
    +  private val callsiteForm = SparkEnv.get.conf.get(EVENT_LOG_CALLSITE_FORM)
    +
       def fromRdd(rdd: RDD[_]): RDDInfo = {
         val rddName = Option(rdd.name).getOrElse(Utils.getFormattedClassName(rdd))
         val parentIds = rdd.dependencies.map(_.rdd.id)
    +    val callSite = callsiteForm match {
    +      case "short" => rdd.creationSite.shortForm
    +      case "long" => rdd.creationSite.longForm
    --- End diff --
    
    If the users input is neither `short` nor `long`, we will get an exception, right?
    
    cc @jiangxb1987 @cloud-fan 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org