You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/17 12:04:07 UTC
[GitHub] [doris] yiguolei opened a new pull request, #16022: [refactor](remove non vec) remove column block and column view
yiguolei opened a new pull request, #16022:
URL: https://github.com/apache/doris/pull/16022
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #16022: [refactor](remove non vec) remove column block and column view
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #16022:
URL: https://github.com/apache/doris/pull/16022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16022: [refactor](remove non vec) remove column block and column view
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #16022:
URL: https://github.com/apache/doris/pull/16022#issuecomment-1385775530
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 37.06 seconds
load time: 493 seconds
storage size: 17122232890 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230117172729_clickbench_pr_82462.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16022: [refactor](remove non vec) remove column block and column view
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16022:
URL: https://github.com/apache/doris/pull/16022#issuecomment-1386426734
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16022: [refactor](remove non vec) remove column block and column view
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #16022:
URL: https://github.com/apache/doris/pull/16022#discussion_r1072131340
##########
be/src/olap/rowset/segment_v2/page_decoder.h:
##########
@@ -72,16 +71,6 @@
return step;
}
- // Fetch the next vector of values from the page into 'column_vector_view'.
- // The output vector must have space for up to n cells.
- //
- // Return the size of read entries .
- //
- // In the case that the values are themselves references
- // to other memory (eg Slices), the referred-to memory is
- // allocated in the column_vector_view's mem_pool.
- virtual Status next_batch(size_t* n, ColumnBlockView* dst) = 0;
-
virtual Status next_batch(size_t* n, vectorized::MutableColumnPtr& dst) = 0;
virtual Status read_by_rowids(const rowid_t* rowids, ordinal_t page_first_ordinal, size_t* n,
Review Comment:
warning: unknown type name 'ordinal_t' [clang-diagnostic-error]
```cpp
virtual Status read_by_rowids(const rowid_t* rowids, ordinal_t page_first_ordinal, size_t* n,
^
```
##########
be/src/olap/rowset/segment_v2/page_decoder.h:
##########
@@ -72,16 +71,6 @@ class PageDecoder {
return step;
}
- // Fetch the next vector of values from the page into 'column_vector_view'.
- // The output vector must have space for up to n cells.
- //
- // Return the size of read entries .
- //
- // In the case that the values are themselves references
- // to other memory (eg Slices), the referred-to memory is
- // allocated in the column_vector_view's mem_pool.
- virtual Status next_batch(size_t* n, ColumnBlockView* dst) = 0;
-
virtual Status next_batch(size_t* n, vectorized::MutableColumnPtr& dst) = 0;
virtual Status read_by_rowids(const rowid_t* rowids, ordinal_t page_first_ordinal, size_t* n,
Review Comment:
warning: unknown type name 'rowid_t' [clang-diagnostic-error]
```cpp
virtual Status read_by_rowids(const rowid_t* rowids, ordinal_t page_first_ordinal, size_t* n,
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16022: [refactor](remove non vec) remove column block and column view
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16022:
URL: https://github.com/apache/doris/pull/16022#issuecomment-1386426755
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org