You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vineet Garg <vg...@hortonworks.com> on 2018/11/06 03:51:56 UTC

Review Request 69257: HIVE-20842 Fix logic introduced in HIVE-20660 to estimate statistics for group by

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69257/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-20842
    https://issues.apache.org/jira/browse/HIVE-20842


Repository: hive-git


Description
-------

See jIRA


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 32fba6c8ff 
  ql/src/test/results/clientpositive/annotate_stats_groupby.q.out fe30d3197c 
  ql/src/test/results/clientpositive/cbo_rp_annotate_stats_groupby.q.out 91369679aa 
  ql/src/test/results/clientpositive/llap/bucket_groupby.q.out 4e6885d9a2 
  ql/src/test/results/clientpositive/llap/bucket_map_join_tez2.q.out 8fe30f0cc5 
  ql/src/test/results/clientpositive/llap/check_constraint.q.out 72736807cc 
  ql/src/test/results/clientpositive/llap/constraints_optimization.q.out 96caa4d6dd 
  ql/src/test/results/clientpositive/llap/correlationoptimizer1.q.out efa2dd818a 
  ql/src/test/results/clientpositive/llap/correlationoptimizer6.q.out 93a3017696 
  ql/src/test/results/clientpositive/llap/dynpart_sort_opt_vectorization.q.out bd3c7769a4 
  ql/src/test/results/clientpositive/llap/dynpart_sort_optimization2.q.out 30074abaf2 
  ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out dca0ebdab8 
  ql/src/test/results/clientpositive/llap/except_distinct.q.out c155a73c96 
  ql/src/test/results/clientpositive/llap/explainanalyze_2.q.out 9332e719d9 
  ql/src/test/results/clientpositive/llap/explainuser_1.q.out a87890f89e 
  ql/src/test/results/clientpositive/llap/explainuser_2.q.out 51465324d2 
  ql/src/test/results/clientpositive/llap/explainuser_4.q.out bf20c3d8dc 
  ql/src/test/results/clientpositive/llap/intersect_all.q.out dbb77d1abc 
  ql/src/test/results/clientpositive/llap/intersect_distinct.q.out 604c7bbd63 
  ql/src/test/results/clientpositive/llap/intersect_merge.q.out b19fd2c4ec 
  ql/src/test/results/clientpositive/llap/limit_pushdown.q.out a84a7b3db3 
  ql/src/test/results/clientpositive/llap/limit_pushdown3.q.out 8d5848bcd3 
  ql/src/test/results/clientpositive/llap/mrr.q.out a8aceea293 
  ql/src/test/results/clientpositive/llap/offset_limit_ppd_optimizer.q.out 133d8af9e9 
  ql/src/test/results/clientpositive/llap/parallel.q.out 692bb8ca74 
  ql/src/test/results/clientpositive/llap/parallel_colstats.q.out 91a450accf 
  ql/src/test/results/clientpositive/llap/ptf.q.out b719f73566 
  ql/src/test/results/clientpositive/llap/reduce_deduplicate_distinct.q.out 8d04800040 
  ql/src/test/results/clientpositive/llap/reduce_deduplicate_extended.q.out 54dc0f7b8f 
  ql/src/test/results/clientpositive/llap/selectDistinctStar.q.out 17601acc2d 
  ql/src/test/results/clientpositive/llap/sharedworkext.q.out ca2b4d6750 
  ql/src/test/results/clientpositive/llap/sqlmerge_stats.q.out cd178cff4c 
  ql/src/test/results/clientpositive/llap/subquery_in.q.out 3222e2f616 
  ql/src/test/results/clientpositive/llap/subquery_in_having.q.out 3839696882 
  ql/src/test/results/clientpositive/llap/subquery_multi.q.out 7b00d69754 
  ql/src/test/results/clientpositive/llap/subquery_notin.q.out 37e7562818 
  ql/src/test/results/clientpositive/llap/subquery_scalar.q.out c72e4b2097 
  ql/src/test/results/clientpositive/llap/subquery_select.q.out 6870ad1873 
  ql/src/test/results/clientpositive/llap/subquery_views.q.out 4c723dce6b 
  ql/src/test/results/clientpositive/llap/tez_join_hash.q.out 2ac8400576 
  ql/src/test/results/clientpositive/llap/tez_union2.q.out ef0d4bd71a 
  ql/src/test/results/clientpositive/llap/tez_union_multiinsert.q.out 05d259b0d9 
  ql/src/test/results/clientpositive/llap/unionDistinct_1.q.out b1eec43b72 
  ql/src/test/results/clientpositive/llap/unionDistinct_3.q.out 5337820ab0 
  ql/src/test/results/clientpositive/llap/vector_adaptor_usage_mode.q.out 52b17cf36b 
  ql/src/test/results/clientpositive/llap/vector_char_2.q.out 1ba0ab6920 
  ql/src/test/results/clientpositive/llap/vector_distinct_2.q.out e72e398e4b 
  ql/src/test/results/clientpositive/llap/vector_groupby_3.q.out 3ea544e4b8 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets2.q.out 7bee405977 
  ql/src/test/results/clientpositive/llap/vector_groupby_reduce.q.out 3696cad941 
  ql/src/test/results/clientpositive/llap/vector_outer_reference_windowed.q.out fcde000739 
  ql/src/test/results/clientpositive/llap/vector_windowing.q.out 8e8c445af7 
  ql/src/test/results/clientpositive/llap/vector_windowing_gby2.q.out 5943548a6c 
  ql/src/test/results/clientpositive/llap/vectorization_limit.q.out 3dc640a300 
  ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out f929706757 
  ql/src/test/results/clientpositive/llap/vectorized_ptf.q.out 56e81aa819 
  ql/src/test/results/clientpositive/llap/windowing.q.out ffd21abb4c 
  ql/src/test/results/clientpositive/perf/tez/constraints/query11.q.out 658ae27d14 
  ql/src/test/results/clientpositive/perf/tez/constraints/query14.q.out e8a6eaa464 
  ql/src/test/results/clientpositive/perf/tez/constraints/query23.q.out c7b1c9a6bb 
  ql/src/test/results/clientpositive/perf/tez/constraints/query33.q.out 6d7c620dea 
  ql/src/test/results/clientpositive/perf/tez/constraints/query34.q.out f4e6a73942 
  ql/src/test/results/clientpositive/perf/tez/constraints/query38.q.out bc22cfb07e 
  ql/src/test/results/clientpositive/perf/tez/constraints/query4.q.out 7291c142c0 
  ql/src/test/results/clientpositive/perf/tez/constraints/query45.q.out bf620c8ed5 
  ql/src/test/results/clientpositive/perf/tez/constraints/query49.q.out 324eef20d0 
  ql/src/test/results/clientpositive/perf/tez/constraints/query5.q.out 32b0e3ec2a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query58.q.out ac9e4123f5 
  ql/src/test/results/clientpositive/perf/tez/constraints/query64.q.out aebd6b4137 
  ql/src/test/results/clientpositive/perf/tez/constraints/query66.q.out f82272c3f2 
  ql/src/test/results/clientpositive/perf/tez/constraints/query70.q.out 184d281df0 
  ql/src/test/results/clientpositive/perf/tez/constraints/query73.q.out 45ddfd5a4a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query74.q.out 39b3f0a715 
  ql/src/test/results/clientpositive/perf/tez/constraints/query75.q.out fee4e83651 
  ql/src/test/results/clientpositive/perf/tez/constraints/query78.q.out ef4d6dbc21 
  ql/src/test/results/clientpositive/perf/tez/constraints/query79.q.out fb94428c03 
  ql/src/test/results/clientpositive/perf/tez/constraints/query80.q.out dbaecf8fe8 
  ql/src/test/results/clientpositive/perf/tez/constraints/query83.q.out 4c9fc683d1 
  ql/src/test/results/clientpositive/perf/tez/constraints/query87.q.out b6d3904c1c 
  ql/src/test/results/clientpositive/perf/tez/constraints/query95.q.out fd709f99dd 
  ql/src/test/results/clientpositive/perf/tez/constraints/query97.q.out 1e15c0decd 
  ql/src/test/results/clientpositive/perf/tez/query11.q.out 2f453f3ab0 
  ql/src/test/results/clientpositive/perf/tez/query14.q.out c078c271ec 
  ql/src/test/results/clientpositive/perf/tez/query33.q.out a76122c4ed 
  ql/src/test/results/clientpositive/perf/tez/query34.q.out fa40be9bb9 
  ql/src/test/results/clientpositive/perf/tez/query38.q.out e91141d836 
  ql/src/test/results/clientpositive/perf/tez/query4.q.out 27ce7b5b89 
  ql/src/test/results/clientpositive/perf/tez/query45.q.out c2f9374c4b 
  ql/src/test/results/clientpositive/perf/tez/query49.q.out 6fe8e9aa94 
  ql/src/test/results/clientpositive/perf/tez/query5.q.out 31afb0ef17 
  ql/src/test/results/clientpositive/perf/tez/query58.q.out 9e71fc0a54 
  ql/src/test/results/clientpositive/perf/tez/query64.q.out f670c4f4e2 
  ql/src/test/results/clientpositive/perf/tez/query70.q.out e8743e3298 
  ql/src/test/results/clientpositive/perf/tez/query73.q.out 7aafbcf61c 
  ql/src/test/results/clientpositive/perf/tez/query74.q.out 4b174fe4d4 
  ql/src/test/results/clientpositive/perf/tez/query78.q.out 853759ff15 
  ql/src/test/results/clientpositive/perf/tez/query79.q.out f1538371a9 
  ql/src/test/results/clientpositive/perf/tez/query80.q.out ff26befbd4 
  ql/src/test/results/clientpositive/perf/tez/query83.q.out a99851f080 
  ql/src/test/results/clientpositive/perf/tez/query87.q.out 4006cfb876 
  ql/src/test/results/clientpositive/perf/tez/query97.q.out 21daca3aed 


Diff: https://reviews.apache.org/r/69257/diff/1/


Testing
-------


Thanks,

Vineet Garg


Re: Review Request 69257: HIVE-20842 Fix logic introduced in HIVE-20660 to estimate statistics for group by

Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69257/
-----------------------------------------------------------

(Updated Nov. 13, 2018, 10:45 p.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-20842
    https://issues.apache.org/jira/browse/HIVE-20842


Repository: hive-git


Description
-------

See jIRA


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java f0b41f36f3 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 32fba6c8ff 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets2.q.out 7bee405977 
  ql/src/test/results/clientpositive/perf/tez/constraints/query5.q.out 32b0e3ec2a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query70.q.out 184d281df0 
  ql/src/test/results/clientpositive/perf/tez/constraints/query77.q.out 78f7c28b7a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query80.q.out dbaecf8fe8 
  ql/src/test/results/clientpositive/perf/tez/constraints/query95.q.out fd709f99dd 
  ql/src/test/results/clientpositive/perf/tez/query5.q.out 2ce689b1bb 
  ql/src/test/results/clientpositive/perf/tez/query70.q.out 4650ef66fc 
  ql/src/test/results/clientpositive/perf/tez/query77.q.out 528c19cf61 
  ql/src/test/results/clientpositive/perf/tez/query80.q.out 223e61aa24 


Diff: https://reviews.apache.org/r/69257/diff/8/

Changes: https://reviews.apache.org/r/69257/diff/7-8/


Testing
-------


Thanks,

Vineet Garg


Re: Review Request 69257: HIVE-20842 Fix logic introduced in HIVE-20660 to estimate statistics for group by

Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69257/
-----------------------------------------------------------

(Updated Nov. 13, 2018, 12:51 a.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-20842
    https://issues.apache.org/jira/browse/HIVE-20842


Repository: hive-git


Description
-------

See jIRA


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java f0b41f36f3 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 32fba6c8ff 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets2.q.out 7bee405977 
  ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out f929706757 
  ql/src/test/results/clientpositive/perf/tez/constraints/query5.q.out 32b0e3ec2a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query70.q.out 184d281df0 
  ql/src/test/results/clientpositive/perf/tez/constraints/query77.q.out 78f7c28b7a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query80.q.out dbaecf8fe8 
  ql/src/test/results/clientpositive/perf/tez/constraints/query95.q.out fd709f99dd 
  ql/src/test/results/clientpositive/perf/tez/query5.q.out 2ce689b1bb 
  ql/src/test/results/clientpositive/perf/tez/query70.q.out 4650ef66fc 
  ql/src/test/results/clientpositive/perf/tez/query80.q.out 223e61aa24 


Diff: https://reviews.apache.org/r/69257/diff/7/

Changes: https://reviews.apache.org/r/69257/diff/6-7/


Testing
-------


Thanks,

Vineet Garg


Re: Review Request 69257: HIVE-20842 Fix logic introduced in HIVE-20660 to estimate statistics for group by

Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69257/
-----------------------------------------------------------

(Updated Nov. 12, 2018, 10:46 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

Rebased patch


Bugs: HIVE-20842
    https://issues.apache.org/jira/browse/HIVE-20842


Repository: hive-git


Description
-------

See jIRA


Diffs (updated)
-----

  llap-server/src/main/resources/package.py c48ff79691 
  ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java f0b41f36f3 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 32fba6c8ff 
  ql/src/test/results/clientpositive/annotate_stats_groupby.q.out fe30d3197c 
  ql/src/test/results/clientpositive/cbo_rp_annotate_stats_groupby.q.out 91369679aa 
  ql/src/test/results/clientpositive/llap/bucket_groupby.q.out 4e6885d9a2 
  ql/src/test/results/clientpositive/llap/bucket_map_join_tez2.q.out 5de5a69f87 
  ql/src/test/results/clientpositive/llap/check_constraint.q.out 2b1564879c 
  ql/src/test/results/clientpositive/llap/constraints_optimization.q.out bf60646636 
  ql/src/test/results/clientpositive/llap/correlationoptimizer1.q.out efa2dd818a 
  ql/src/test/results/clientpositive/llap/correlationoptimizer6.q.out 93a3017696 
  ql/src/test/results/clientpositive/llap/dynpart_sort_opt_vectorization.q.out bd3c7769a4 
  ql/src/test/results/clientpositive/llap/dynpart_sort_optimization2.q.out 30074abaf2 
  ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out dca0ebdab8 
  ql/src/test/results/clientpositive/llap/except_distinct.q.out c155a73c96 
  ql/src/test/results/clientpositive/llap/explainuser_1.q.out c86450aae2 
  ql/src/test/results/clientpositive/llap/explainuser_2.q.out 1dd9a0ff30 
  ql/src/test/results/clientpositive/llap/explainuser_4.q.out 8de83793ac 
  ql/src/test/results/clientpositive/llap/intersect_all.q.out dbb77d1abc 
  ql/src/test/results/clientpositive/llap/intersect_distinct.q.out 604c7bbd63 
  ql/src/test/results/clientpositive/llap/intersect_merge.q.out b19fd2c4ec 
  ql/src/test/results/clientpositive/llap/limit_pushdown.q.out a84a7b3db3 
  ql/src/test/results/clientpositive/llap/limit_pushdown3.q.out 8d5848bcd3 
  ql/src/test/results/clientpositive/llap/mrr.q.out a8aceea293 
  ql/src/test/results/clientpositive/llap/offset_limit_ppd_optimizer.q.out 133d8af9e9 
  ql/src/test/results/clientpositive/llap/parallel.q.out 692bb8ca74 
  ql/src/test/results/clientpositive/llap/parallel_colstats.q.out 91a450accf 
  ql/src/test/results/clientpositive/llap/ptf.q.out b719f73566 
  ql/src/test/results/clientpositive/llap/reduce_deduplicate_distinct.q.out 8d04800040 
  ql/src/test/results/clientpositive/llap/reduce_deduplicate_extended.q.out 54dc0f7b8f 
  ql/src/test/results/clientpositive/llap/selectDistinctStar.q.out 17601acc2d 
  ql/src/test/results/clientpositive/llap/sharedworkext.q.out e3488151bf 
  ql/src/test/results/clientpositive/llap/sqlmerge_stats.q.out cd178cff4c 
  ql/src/test/results/clientpositive/llap/subquery_in.q.out 9cfc960bf0 
  ql/src/test/results/clientpositive/llap/subquery_in_having.q.out 3839696882 
  ql/src/test/results/clientpositive/llap/subquery_multi.q.out 7b00d69754 
  ql/src/test/results/clientpositive/llap/subquery_notin.q.out 29d8bbfb48 
  ql/src/test/results/clientpositive/llap/subquery_scalar.q.out c43ad9188b 
  ql/src/test/results/clientpositive/llap/subquery_select.q.out 0435530467 
  ql/src/test/results/clientpositive/llap/subquery_views.q.out aa50b468c3 
  ql/src/test/results/clientpositive/llap/tez_join_hash.q.out 2ac8400576 
  ql/src/test/results/clientpositive/llap/tez_union2.q.out ef0d4bd71a 
  ql/src/test/results/clientpositive/llap/tez_union_multiinsert.q.out 05d259b0d9 
  ql/src/test/results/clientpositive/llap/unionDistinct_1.q.out 93791ac8e0 
  ql/src/test/results/clientpositive/llap/unionDistinct_3.q.out 5337820ab0 
  ql/src/test/results/clientpositive/llap/vector_adaptor_usage_mode.q.out 52b17cf36b 
  ql/src/test/results/clientpositive/llap/vector_char_2.q.out 1ba0ab6920 
  ql/src/test/results/clientpositive/llap/vector_distinct_2.q.out e72e398e4b 
  ql/src/test/results/clientpositive/llap/vector_groupby_3.q.out 3ea544e4b8 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets2.q.out 7bee405977 
  ql/src/test/results/clientpositive/llap/vector_groupby_reduce.q.out 3696cad941 
  ql/src/test/results/clientpositive/llap/vector_outer_reference_windowed.q.out fcde000739 
  ql/src/test/results/clientpositive/llap/vector_windowing.q.out 8e8c445af7 
  ql/src/test/results/clientpositive/llap/vector_windowing_gby2.q.out 5943548a6c 
  ql/src/test/results/clientpositive/llap/vectorization_limit.q.out 3dc640a300 
  ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out f929706757 
  ql/src/test/results/clientpositive/llap/vectorized_ptf.q.out 56e81aa819 
  ql/src/test/results/clientpositive/llap/windowing.q.out ffd21abb4c 
  ql/src/test/results/clientpositive/perf/tez/constraints/query11.q.out 00b6bcbe1a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query14.q.out e8a6eaa464 
  ql/src/test/results/clientpositive/perf/tez/constraints/query33.q.out 6d7c620dea 
  ql/src/test/results/clientpositive/perf/tez/constraints/query34.q.out b717b285ef 
  ql/src/test/results/clientpositive/perf/tez/constraints/query4.q.out 2f8ab17bf0 
  ql/src/test/results/clientpositive/perf/tez/constraints/query49.q.out 324eef20d0 
  ql/src/test/results/clientpositive/perf/tez/constraints/query5.q.out 32b0e3ec2a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query70.q.out 184d281df0 
  ql/src/test/results/clientpositive/perf/tez/constraints/query73.q.out 53345420af 
  ql/src/test/results/clientpositive/perf/tez/constraints/query74.q.out 12ed5c8ecb 
  ql/src/test/results/clientpositive/perf/tez/constraints/query77.q.out 78f7c28b7a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query78.q.out ef4d6dbc21 
  ql/src/test/results/clientpositive/perf/tez/constraints/query79.q.out fb94428c03 
  ql/src/test/results/clientpositive/perf/tez/constraints/query80.q.out dbaecf8fe8 
  ql/src/test/results/clientpositive/perf/tez/constraints/query87.q.out b6d3904c1c 
  ql/src/test/results/clientpositive/perf/tez/constraints/query95.q.out fd709f99dd 
  ql/src/test/results/clientpositive/perf/tez/constraints/query97.q.out 1e15c0decd 
  ql/src/test/results/clientpositive/perf/tez/query11.q.out da1c349ff0 
  ql/src/test/results/clientpositive/perf/tez/query33.q.out 6c4798eed5 
  ql/src/test/results/clientpositive/perf/tez/query34.q.out fd60a3a6bd 
  ql/src/test/results/clientpositive/perf/tez/query4.q.out bb0d7ba3f5 
  ql/src/test/results/clientpositive/perf/tez/query5.q.out 2ce689b1bb 
  ql/src/test/results/clientpositive/perf/tez/query70.q.out 4650ef66fc 
  ql/src/test/results/clientpositive/perf/tez/query73.q.out a3ec37822f 
  ql/src/test/results/clientpositive/perf/tez/query74.q.out 20aade2974 
  ql/src/test/results/clientpositive/perf/tez/query78.q.out 3d938e1c8e 
  ql/src/test/results/clientpositive/perf/tez/query79.q.out 877ff7bc77 
  ql/src/test/results/clientpositive/perf/tez/query80.q.out 223e61aa24 
  ql/src/test/results/clientpositive/perf/tez/query87.q.out 5b59116741 
  ql/src/test/results/clientpositive/perf/tez/query97.q.out 8cd15fb1a2 
  ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out 1f681944cd 


Diff: https://reviews.apache.org/r/69257/diff/6/

Changes: https://reviews.apache.org/r/69257/diff/5-6/


Testing
-------


Thanks,

Vineet Garg


Re: Review Request 69257: HIVE-20842 Fix logic introduced in HIVE-20660 to estimate statistics for group by

Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69257/
-----------------------------------------------------------

(Updated Nov. 9, 2018, 10:44 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

Uploaded wrong patch before


Bugs: HIVE-20842
    https://issues.apache.org/jira/browse/HIVE-20842


Repository: hive-git


Description
-------

See jIRA


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java f0b41f36f3 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 32fba6c8ff 
  ql/src/test/results/clientpositive/annotate_stats_groupby.q.out fe30d3197c 
  ql/src/test/results/clientpositive/cbo_rp_annotate_stats_groupby.q.out 91369679aa 
  ql/src/test/results/clientpositive/llap/bucket_groupby.q.out 4e6885d9a2 
  ql/src/test/results/clientpositive/llap/bucket_map_join_tez2.q.out 8fe30f0cc5 
  ql/src/test/results/clientpositive/llap/check_constraint.q.out 72736807cc 
  ql/src/test/results/clientpositive/llap/constraints_optimization.q.out 23bab345ca 
  ql/src/test/results/clientpositive/llap/correlationoptimizer1.q.out efa2dd818a 
  ql/src/test/results/clientpositive/llap/correlationoptimizer6.q.out 93a3017696 
  ql/src/test/results/clientpositive/llap/dynpart_sort_opt_vectorization.q.out bd3c7769a4 
  ql/src/test/results/clientpositive/llap/dynpart_sort_optimization2.q.out 30074abaf2 
  ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out dca0ebdab8 
  ql/src/test/results/clientpositive/llap/except_distinct.q.out c155a73c96 
  ql/src/test/results/clientpositive/llap/explainuser_1.q.out a87890f89e 
  ql/src/test/results/clientpositive/llap/explainuser_2.q.out 51465324d2 
  ql/src/test/results/clientpositive/llap/explainuser_4.q.out bf20c3d8dc 
  ql/src/test/results/clientpositive/llap/intersect_all.q.out dbb77d1abc 
  ql/src/test/results/clientpositive/llap/intersect_distinct.q.out 604c7bbd63 
  ql/src/test/results/clientpositive/llap/intersect_merge.q.out b19fd2c4ec 
  ql/src/test/results/clientpositive/llap/limit_pushdown.q.out a84a7b3db3 
  ql/src/test/results/clientpositive/llap/limit_pushdown3.q.out 8d5848bcd3 
  ql/src/test/results/clientpositive/llap/mrr.q.out a8aceea293 
  ql/src/test/results/clientpositive/llap/offset_limit_ppd_optimizer.q.out 133d8af9e9 
  ql/src/test/results/clientpositive/llap/parallel.q.out 692bb8ca74 
  ql/src/test/results/clientpositive/llap/parallel_colstats.q.out 91a450accf 
  ql/src/test/results/clientpositive/llap/ptf.q.out b719f73566 
  ql/src/test/results/clientpositive/llap/reduce_deduplicate_distinct.q.out 8d04800040 
  ql/src/test/results/clientpositive/llap/reduce_deduplicate_extended.q.out 54dc0f7b8f 
  ql/src/test/results/clientpositive/llap/selectDistinctStar.q.out 17601acc2d 
  ql/src/test/results/clientpositive/llap/sharedworkext.q.out ca2b4d6750 
  ql/src/test/results/clientpositive/llap/sqlmerge_stats.q.out cd178cff4c 
  ql/src/test/results/clientpositive/llap/subquery_in.q.out 3222e2f616 
  ql/src/test/results/clientpositive/llap/subquery_in_having.q.out 3839696882 
  ql/src/test/results/clientpositive/llap/subquery_multi.q.out 7b00d69754 
  ql/src/test/results/clientpositive/llap/subquery_notin.q.out 37e7562818 
  ql/src/test/results/clientpositive/llap/subquery_scalar.q.out c72e4b2097 
  ql/src/test/results/clientpositive/llap/subquery_select.q.out 6870ad1873 
  ql/src/test/results/clientpositive/llap/subquery_views.q.out 4c723dce6b 
  ql/src/test/results/clientpositive/llap/tez_join_hash.q.out 2ac8400576 
  ql/src/test/results/clientpositive/llap/tez_union2.q.out ef0d4bd71a 
  ql/src/test/results/clientpositive/llap/tez_union_multiinsert.q.out 05d259b0d9 
  ql/src/test/results/clientpositive/llap/unionDistinct_1.q.out b1eec43b72 
  ql/src/test/results/clientpositive/llap/unionDistinct_3.q.out 5337820ab0 
  ql/src/test/results/clientpositive/llap/vector_adaptor_usage_mode.q.out 52b17cf36b 
  ql/src/test/results/clientpositive/llap/vector_char_2.q.out 1ba0ab6920 
  ql/src/test/results/clientpositive/llap/vector_distinct_2.q.out e72e398e4b 
  ql/src/test/results/clientpositive/llap/vector_groupby_3.q.out 3ea544e4b8 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets2.q.out 7bee405977 
  ql/src/test/results/clientpositive/llap/vector_groupby_reduce.q.out 3696cad941 
  ql/src/test/results/clientpositive/llap/vector_outer_reference_windowed.q.out fcde000739 
  ql/src/test/results/clientpositive/llap/vector_windowing.q.out 8e8c445af7 
  ql/src/test/results/clientpositive/llap/vector_windowing_gby2.q.out 5943548a6c 
  ql/src/test/results/clientpositive/llap/vectorization_limit.q.out 3dc640a300 
  ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out f929706757 
  ql/src/test/results/clientpositive/llap/vectorized_ptf.q.out 56e81aa819 
  ql/src/test/results/clientpositive/llap/windowing.q.out ffd21abb4c 
  ql/src/test/results/clientpositive/perf/tez/constraints/query11.q.out 00b6bcbe1a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query14.q.out e8a6eaa464 
  ql/src/test/results/clientpositive/perf/tez/constraints/query33.q.out 6d7c620dea 
  ql/src/test/results/clientpositive/perf/tez/constraints/query34.q.out f4e6a73942 
  ql/src/test/results/clientpositive/perf/tez/constraints/query4.q.out 2f8ab17bf0 
  ql/src/test/results/clientpositive/perf/tez/constraints/query49.q.out 324eef20d0 
  ql/src/test/results/clientpositive/perf/tez/constraints/query5.q.out 32b0e3ec2a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query70.q.out 184d281df0 
  ql/src/test/results/clientpositive/perf/tez/constraints/query73.q.out 45ddfd5a4a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query74.q.out 12ed5c8ecb 
  ql/src/test/results/clientpositive/perf/tez/constraints/query77.q.out 78f7c28b7a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query78.q.out ef4d6dbc21 
  ql/src/test/results/clientpositive/perf/tez/constraints/query79.q.out fb94428c03 
  ql/src/test/results/clientpositive/perf/tez/constraints/query80.q.out dbaecf8fe8 
  ql/src/test/results/clientpositive/perf/tez/constraints/query83.q.out 0dea786232 
  ql/src/test/results/clientpositive/perf/tez/constraints/query87.q.out b6d3904c1c 
  ql/src/test/results/clientpositive/perf/tez/constraints/query95.q.out fd709f99dd 
  ql/src/test/results/clientpositive/perf/tez/constraints/query97.q.out 1e15c0decd 
  ql/src/test/results/clientpositive/perf/tez/query11.q.out 2f453f3ab0 
  ql/src/test/results/clientpositive/perf/tez/query33.q.out a76122c4ed 
  ql/src/test/results/clientpositive/perf/tez/query34.q.out fa40be9bb9 
  ql/src/test/results/clientpositive/perf/tez/query4.q.out 27ce7b5b89 
  ql/src/test/results/clientpositive/perf/tez/query5.q.out 31afb0ef17 
  ql/src/test/results/clientpositive/perf/tez/query70.q.out e8743e3298 
  ql/src/test/results/clientpositive/perf/tez/query73.q.out 7aafbcf61c 
  ql/src/test/results/clientpositive/perf/tez/query74.q.out 4b174fe4d4 
  ql/src/test/results/clientpositive/perf/tez/query78.q.out 853759ff15 
  ql/src/test/results/clientpositive/perf/tez/query79.q.out f1538371a9 
  ql/src/test/results/clientpositive/perf/tez/query80.q.out ff26befbd4 
  ql/src/test/results/clientpositive/perf/tez/query83.q.out a99851f080 
  ql/src/test/results/clientpositive/perf/tez/query87.q.out 4006cfb876 
  ql/src/test/results/clientpositive/perf/tez/query97.q.out 21daca3aed 
  ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out 0bdc44be8f 


Diff: https://reviews.apache.org/r/69257/diff/5/

Changes: https://reviews.apache.org/r/69257/diff/4-5/


Testing
-------


Thanks,

Vineet Garg


Re: Review Request 69257: HIVE-20842 Fix logic introduced in HIVE-20660 to estimate statistics for group by

Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69257/
-----------------------------------------------------------

(Updated Nov. 9, 2018, 10:42 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

Updated tests + checkstyle fixes


Bugs: HIVE-20842
    https://issues.apache.org/jira/browse/HIVE-20842


Repository: hive-git


Description
-------

See jIRA


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSemiJoinRule.java 7799090d43 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 11c8f5f02c 
  ql/src/test/queries/clientpositive/semijoin.q 144069bbe6 
  ql/src/test/results/clientpositive/llap/explainuser_1.q.out a87890f89e 
  ql/src/test/results/clientpositive/llap/optimize_join_ptp.q.out af55d4d5f3 
  ql/src/test/results/clientpositive/llap/semijoin.q.out 531ef46c78 
  ql/src/test/results/clientpositive/llap/subquery_in.q.out 3222e2f616 
  ql/src/test/results/clientpositive/llap/subquery_views.q.out 4c723dce6b 
  ql/src/test/results/clientpositive/llap/vector_mapjoin_reduce.q.out ad57fcd666 
  ql/src/test/results/clientpositive/perf/tez/cbo_query14.q.out 9bb4f2e7f2 
  ql/src/test/results/clientpositive/perf/tez/query14.q.out c078c271ec 
  ql/src/test/results/clientpositive/spark/semijoin.q.out a787bce4b4 
  ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out 0bdc44be8f 
  ql/src/test/results/clientpositive/spark/subquery_in.q.out 7063a794cb 
  ql/src/test/results/clientpositive/spark/subquery_views.q.out 15400893b2 
  ql/src/test/results/clientpositive/spark/vector_mapjoin_reduce.q.out 6634a047f6 


Diff: https://reviews.apache.org/r/69257/diff/4/

Changes: https://reviews.apache.org/r/69257/diff/3-4/


Testing
-------


Thanks,

Vineet Garg


Re: Review Request 69257: HIVE-20842 Fix logic introduced in HIVE-20660 to estimate statistics for group by

Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69257/
-----------------------------------------------------------

(Updated Nov. 9, 2018, 10:16 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

Updated the logic to fix tests


Bugs: HIVE-20842
    https://issues.apache.org/jira/browse/HIVE-20842


Repository: hive-git


Description
-------

See jIRA


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java f0b41f36f3 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 32fba6c8ff 
  ql/src/test/results/clientpositive/annotate_stats_groupby.q.out fe30d3197c 
  ql/src/test/results/clientpositive/cbo_rp_annotate_stats_groupby.q.out 91369679aa 
  ql/src/test/results/clientpositive/llap/bucket_groupby.q.out 4e6885d9a2 
  ql/src/test/results/clientpositive/llap/bucket_map_join_tez2.q.out 8fe30f0cc5 
  ql/src/test/results/clientpositive/llap/check_constraint.q.out 72736807cc 
  ql/src/test/results/clientpositive/llap/constraints_optimization.q.out 23bab345ca 
  ql/src/test/results/clientpositive/llap/correlationoptimizer1.q.out efa2dd818a 
  ql/src/test/results/clientpositive/llap/correlationoptimizer6.q.out 93a3017696 
  ql/src/test/results/clientpositive/llap/dynpart_sort_opt_vectorization.q.out bd3c7769a4 
  ql/src/test/results/clientpositive/llap/dynpart_sort_optimization2.q.out 30074abaf2 
  ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out dca0ebdab8 
  ql/src/test/results/clientpositive/llap/except_distinct.q.out c155a73c96 
  ql/src/test/results/clientpositive/llap/explainuser_1.q.out a87890f89e 
  ql/src/test/results/clientpositive/llap/explainuser_2.q.out 51465324d2 
  ql/src/test/results/clientpositive/llap/explainuser_4.q.out bf20c3d8dc 
  ql/src/test/results/clientpositive/llap/intersect_all.q.out dbb77d1abc 
  ql/src/test/results/clientpositive/llap/intersect_distinct.q.out 604c7bbd63 
  ql/src/test/results/clientpositive/llap/intersect_merge.q.out b19fd2c4ec 
  ql/src/test/results/clientpositive/llap/limit_pushdown.q.out a84a7b3db3 
  ql/src/test/results/clientpositive/llap/limit_pushdown3.q.out 8d5848bcd3 
  ql/src/test/results/clientpositive/llap/mrr.q.out a8aceea293 
  ql/src/test/results/clientpositive/llap/offset_limit_ppd_optimizer.q.out 133d8af9e9 
  ql/src/test/results/clientpositive/llap/parallel.q.out 692bb8ca74 
  ql/src/test/results/clientpositive/llap/parallel_colstats.q.out 91a450accf 
  ql/src/test/results/clientpositive/llap/ptf.q.out b719f73566 
  ql/src/test/results/clientpositive/llap/reduce_deduplicate_distinct.q.out 8d04800040 
  ql/src/test/results/clientpositive/llap/reduce_deduplicate_extended.q.out 54dc0f7b8f 
  ql/src/test/results/clientpositive/llap/selectDistinctStar.q.out 17601acc2d 
  ql/src/test/results/clientpositive/llap/sharedworkext.q.out ca2b4d6750 
  ql/src/test/results/clientpositive/llap/sqlmerge_stats.q.out cd178cff4c 
  ql/src/test/results/clientpositive/llap/subquery_in.q.out 3222e2f616 
  ql/src/test/results/clientpositive/llap/subquery_in_having.q.out 3839696882 
  ql/src/test/results/clientpositive/llap/subquery_multi.q.out 7b00d69754 
  ql/src/test/results/clientpositive/llap/subquery_notin.q.out 37e7562818 
  ql/src/test/results/clientpositive/llap/subquery_scalar.q.out c72e4b2097 
  ql/src/test/results/clientpositive/llap/subquery_select.q.out 6870ad1873 
  ql/src/test/results/clientpositive/llap/subquery_views.q.out 4c723dce6b 
  ql/src/test/results/clientpositive/llap/tez_join_hash.q.out 2ac8400576 
  ql/src/test/results/clientpositive/llap/tez_union2.q.out ef0d4bd71a 
  ql/src/test/results/clientpositive/llap/tez_union_multiinsert.q.out 05d259b0d9 
  ql/src/test/results/clientpositive/llap/unionDistinct_1.q.out b1eec43b72 
  ql/src/test/results/clientpositive/llap/unionDistinct_3.q.out 5337820ab0 
  ql/src/test/results/clientpositive/llap/vector_adaptor_usage_mode.q.out 52b17cf36b 
  ql/src/test/results/clientpositive/llap/vector_char_2.q.out 1ba0ab6920 
  ql/src/test/results/clientpositive/llap/vector_distinct_2.q.out e72e398e4b 
  ql/src/test/results/clientpositive/llap/vector_groupby_3.q.out 3ea544e4b8 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets2.q.out 7bee405977 
  ql/src/test/results/clientpositive/llap/vector_groupby_reduce.q.out 3696cad941 
  ql/src/test/results/clientpositive/llap/vector_outer_reference_windowed.q.out fcde000739 
  ql/src/test/results/clientpositive/llap/vector_windowing.q.out 8e8c445af7 
  ql/src/test/results/clientpositive/llap/vector_windowing_gby2.q.out 5943548a6c 
  ql/src/test/results/clientpositive/llap/vectorization_limit.q.out 3dc640a300 
  ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out f929706757 
  ql/src/test/results/clientpositive/llap/vectorized_ptf.q.out 56e81aa819 
  ql/src/test/results/clientpositive/llap/windowing.q.out ffd21abb4c 
  ql/src/test/results/clientpositive/perf/tez/constraints/query11.q.out 00b6bcbe1a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query14.q.out e8a6eaa464 
  ql/src/test/results/clientpositive/perf/tez/constraints/query33.q.out 6d7c620dea 
  ql/src/test/results/clientpositive/perf/tez/constraints/query34.q.out f4e6a73942 
  ql/src/test/results/clientpositive/perf/tez/constraints/query4.q.out 2f8ab17bf0 
  ql/src/test/results/clientpositive/perf/tez/constraints/query49.q.out 324eef20d0 
  ql/src/test/results/clientpositive/perf/tez/constraints/query5.q.out 32b0e3ec2a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query70.q.out 184d281df0 
  ql/src/test/results/clientpositive/perf/tez/constraints/query73.q.out 45ddfd5a4a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query74.q.out 12ed5c8ecb 
  ql/src/test/results/clientpositive/perf/tez/constraints/query77.q.out 78f7c28b7a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query78.q.out ef4d6dbc21 
  ql/src/test/results/clientpositive/perf/tez/constraints/query79.q.out fb94428c03 
  ql/src/test/results/clientpositive/perf/tez/constraints/query80.q.out dbaecf8fe8 
  ql/src/test/results/clientpositive/perf/tez/constraints/query83.q.out 0dea786232 
  ql/src/test/results/clientpositive/perf/tez/constraints/query87.q.out b6d3904c1c 
  ql/src/test/results/clientpositive/perf/tez/constraints/query95.q.out fd709f99dd 
  ql/src/test/results/clientpositive/perf/tez/constraints/query97.q.out 1e15c0decd 
  ql/src/test/results/clientpositive/perf/tez/query11.q.out 2f453f3ab0 
  ql/src/test/results/clientpositive/perf/tez/query33.q.out a76122c4ed 
  ql/src/test/results/clientpositive/perf/tez/query34.q.out fa40be9bb9 
  ql/src/test/results/clientpositive/perf/tez/query4.q.out 27ce7b5b89 
  ql/src/test/results/clientpositive/perf/tez/query5.q.out 31afb0ef17 
  ql/src/test/results/clientpositive/perf/tez/query70.q.out e8743e3298 
  ql/src/test/results/clientpositive/perf/tez/query73.q.out 7aafbcf61c 
  ql/src/test/results/clientpositive/perf/tez/query74.q.out 4b174fe4d4 
  ql/src/test/results/clientpositive/perf/tez/query78.q.out 853759ff15 
  ql/src/test/results/clientpositive/perf/tez/query79.q.out f1538371a9 
  ql/src/test/results/clientpositive/perf/tez/query80.q.out ff26befbd4 
  ql/src/test/results/clientpositive/perf/tez/query83.q.out a99851f080 
  ql/src/test/results/clientpositive/perf/tez/query87.q.out 4006cfb876 
  ql/src/test/results/clientpositive/perf/tez/query97.q.out 21daca3aed 
  ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out 0bdc44be8f 


Diff: https://reviews.apache.org/r/69257/diff/3/

Changes: https://reviews.apache.org/r/69257/diff/2-3/


Testing
-------


Thanks,

Vineet Garg


Re: Review Request 69257: HIVE-20842 Fix logic introduced in HIVE-20660 to estimate statistics for group by

Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69257/
-----------------------------------------------------------

(Updated Nov. 7, 2018, 12:46 a.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-20842
    https://issues.apache.org/jira/browse/HIVE-20842


Repository: hive-git


Description
-------

See jIRA


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 32fba6c8ff 
  ql/src/test/results/clientpositive/annotate_stats_groupby.q.out fe30d3197c 
  ql/src/test/results/clientpositive/cbo_rp_annotate_stats_groupby.q.out 91369679aa 
  ql/src/test/results/clientpositive/llap/bucket_groupby.q.out 4e6885d9a2 
  ql/src/test/results/clientpositive/llap/bucket_map_join_tez2.q.out 8fe30f0cc5 
  ql/src/test/results/clientpositive/llap/check_constraint.q.out 72736807cc 
  ql/src/test/results/clientpositive/llap/constraints_optimization.q.out 96caa4d6dd 
  ql/src/test/results/clientpositive/llap/correlationoptimizer1.q.out efa2dd818a 
  ql/src/test/results/clientpositive/llap/correlationoptimizer6.q.out 93a3017696 
  ql/src/test/results/clientpositive/llap/dynpart_sort_opt_vectorization.q.out bd3c7769a4 
  ql/src/test/results/clientpositive/llap/dynpart_sort_optimization2.q.out 30074abaf2 
  ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out dca0ebdab8 
  ql/src/test/results/clientpositive/llap/except_distinct.q.out c155a73c96 
  ql/src/test/results/clientpositive/llap/explainanalyze_2.q.out 9332e719d9 
  ql/src/test/results/clientpositive/llap/explainuser_1.q.out a87890f89e 
  ql/src/test/results/clientpositive/llap/explainuser_2.q.out 51465324d2 
  ql/src/test/results/clientpositive/llap/explainuser_4.q.out bf20c3d8dc 
  ql/src/test/results/clientpositive/llap/intersect_all.q.out dbb77d1abc 
  ql/src/test/results/clientpositive/llap/intersect_distinct.q.out 604c7bbd63 
  ql/src/test/results/clientpositive/llap/intersect_merge.q.out b19fd2c4ec 
  ql/src/test/results/clientpositive/llap/limit_pushdown.q.out a84a7b3db3 
  ql/src/test/results/clientpositive/llap/limit_pushdown3.q.out 8d5848bcd3 
  ql/src/test/results/clientpositive/llap/mrr.q.out a8aceea293 
  ql/src/test/results/clientpositive/llap/offset_limit_ppd_optimizer.q.out 133d8af9e9 
  ql/src/test/results/clientpositive/llap/parallel.q.out 692bb8ca74 
  ql/src/test/results/clientpositive/llap/parallel_colstats.q.out 91a450accf 
  ql/src/test/results/clientpositive/llap/ptf.q.out b719f73566 
  ql/src/test/results/clientpositive/llap/reduce_deduplicate_distinct.q.out 8d04800040 
  ql/src/test/results/clientpositive/llap/reduce_deduplicate_extended.q.out 54dc0f7b8f 
  ql/src/test/results/clientpositive/llap/selectDistinctStar.q.out 17601acc2d 
  ql/src/test/results/clientpositive/llap/sharedworkext.q.out ca2b4d6750 
  ql/src/test/results/clientpositive/llap/sqlmerge_stats.q.out cd178cff4c 
  ql/src/test/results/clientpositive/llap/subquery_in.q.out 3222e2f616 
  ql/src/test/results/clientpositive/llap/subquery_in_having.q.out 3839696882 
  ql/src/test/results/clientpositive/llap/subquery_multi.q.out 7b00d69754 
  ql/src/test/results/clientpositive/llap/subquery_notin.q.out 37e7562818 
  ql/src/test/results/clientpositive/llap/subquery_scalar.q.out c72e4b2097 
  ql/src/test/results/clientpositive/llap/subquery_select.q.out 6870ad1873 
  ql/src/test/results/clientpositive/llap/subquery_views.q.out 4c723dce6b 
  ql/src/test/results/clientpositive/llap/tez_join_hash.q.out 2ac8400576 
  ql/src/test/results/clientpositive/llap/tez_union2.q.out ef0d4bd71a 
  ql/src/test/results/clientpositive/llap/tez_union_multiinsert.q.out 05d259b0d9 
  ql/src/test/results/clientpositive/llap/unionDistinct_1.q.out b1eec43b72 
  ql/src/test/results/clientpositive/llap/unionDistinct_3.q.out 5337820ab0 
  ql/src/test/results/clientpositive/llap/vector_adaptor_usage_mode.q.out 52b17cf36b 
  ql/src/test/results/clientpositive/llap/vector_char_2.q.out 1ba0ab6920 
  ql/src/test/results/clientpositive/llap/vector_distinct_2.q.out e72e398e4b 
  ql/src/test/results/clientpositive/llap/vector_groupby_3.q.out 3ea544e4b8 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets2.q.out 7bee405977 
  ql/src/test/results/clientpositive/llap/vector_groupby_reduce.q.out 3696cad941 
  ql/src/test/results/clientpositive/llap/vector_outer_reference_windowed.q.out fcde000739 
  ql/src/test/results/clientpositive/llap/vector_windowing.q.out 8e8c445af7 
  ql/src/test/results/clientpositive/llap/vector_windowing_gby2.q.out 5943548a6c 
  ql/src/test/results/clientpositive/llap/vectorization_limit.q.out 3dc640a300 
  ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out f929706757 
  ql/src/test/results/clientpositive/llap/vectorized_ptf.q.out 56e81aa819 
  ql/src/test/results/clientpositive/llap/windowing.q.out ffd21abb4c 
  ql/src/test/results/clientpositive/perf/tez/constraints/query11.q.out 00b6bcbe1a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query14.q.out e8a6eaa464 
  ql/src/test/results/clientpositive/perf/tez/constraints/query33.q.out 6d7c620dea 
  ql/src/test/results/clientpositive/perf/tez/constraints/query34.q.out f4e6a73942 
  ql/src/test/results/clientpositive/perf/tez/constraints/query38.q.out bc22cfb07e 
  ql/src/test/results/clientpositive/perf/tez/constraints/query4.q.out 2f8ab17bf0 
  ql/src/test/results/clientpositive/perf/tez/constraints/query45.q.out bf620c8ed5 
  ql/src/test/results/clientpositive/perf/tez/constraints/query49.q.out 324eef20d0 
  ql/src/test/results/clientpositive/perf/tez/constraints/query5.q.out 32b0e3ec2a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query58.q.out 61342fa356 
  ql/src/test/results/clientpositive/perf/tez/constraints/query64.q.out aebd6b4137 
  ql/src/test/results/clientpositive/perf/tez/constraints/query66.q.out f82272c3f2 
  ql/src/test/results/clientpositive/perf/tez/constraints/query70.q.out 184d281df0 
  ql/src/test/results/clientpositive/perf/tez/constraints/query73.q.out 45ddfd5a4a 
  ql/src/test/results/clientpositive/perf/tez/constraints/query74.q.out 12ed5c8ecb 
  ql/src/test/results/clientpositive/perf/tez/constraints/query75.q.out f2593995b8 
  ql/src/test/results/clientpositive/perf/tez/constraints/query78.q.out ef4d6dbc21 
  ql/src/test/results/clientpositive/perf/tez/constraints/query79.q.out fb94428c03 
  ql/src/test/results/clientpositive/perf/tez/constraints/query80.q.out dbaecf8fe8 
  ql/src/test/results/clientpositive/perf/tez/constraints/query83.q.out 0dea786232 
  ql/src/test/results/clientpositive/perf/tez/constraints/query87.q.out b6d3904c1c 
  ql/src/test/results/clientpositive/perf/tez/constraints/query95.q.out fd709f99dd 
  ql/src/test/results/clientpositive/perf/tez/constraints/query97.q.out 1e15c0decd 
  ql/src/test/results/clientpositive/perf/tez/query11.q.out 2f453f3ab0 
  ql/src/test/results/clientpositive/perf/tez/query14.q.out c078c271ec 
  ql/src/test/results/clientpositive/perf/tez/query33.q.out a76122c4ed 
  ql/src/test/results/clientpositive/perf/tez/query34.q.out fa40be9bb9 
  ql/src/test/results/clientpositive/perf/tez/query38.q.out e91141d836 
  ql/src/test/results/clientpositive/perf/tez/query4.q.out 27ce7b5b89 
  ql/src/test/results/clientpositive/perf/tez/query45.q.out c2f9374c4b 
  ql/src/test/results/clientpositive/perf/tez/query49.q.out 6fe8e9aa94 
  ql/src/test/results/clientpositive/perf/tez/query5.q.out 31afb0ef17 
  ql/src/test/results/clientpositive/perf/tez/query58.q.out 9e71fc0a54 
  ql/src/test/results/clientpositive/perf/tez/query64.q.out f670c4f4e2 
  ql/src/test/results/clientpositive/perf/tez/query70.q.out e8743e3298 
  ql/src/test/results/clientpositive/perf/tez/query73.q.out 7aafbcf61c 
  ql/src/test/results/clientpositive/perf/tez/query74.q.out 4b174fe4d4 
  ql/src/test/results/clientpositive/perf/tez/query75.q.out 9968adef41 
  ql/src/test/results/clientpositive/perf/tez/query78.q.out 853759ff15 
  ql/src/test/results/clientpositive/perf/tez/query79.q.out f1538371a9 
  ql/src/test/results/clientpositive/perf/tez/query80.q.out ff26befbd4 
  ql/src/test/results/clientpositive/perf/tez/query83.q.out a99851f080 
  ql/src/test/results/clientpositive/perf/tez/query87.q.out 4006cfb876 
  ql/src/test/results/clientpositive/perf/tez/query97.q.out 21daca3aed 
  ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out 0bdc44be8f 


Diff: https://reviews.apache.org/r/69257/diff/2/

Changes: https://reviews.apache.org/r/69257/diff/1-2/


Testing
-------


Thanks,

Vineet Garg