You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/20 11:15:38 UTC

[GitHub] [incubator-shardingsphere] SteNicholas opened a new pull request #4056: MySQL date function

SteNicholas opened a new pull request #4056: MySQL date function
URL: https://github.com/apache/incubator-shardingsphere/pull/4056
 
 
   Fixes #4051.
   
   MySQLParser doesn't support date function like `DATE_ADD` etc, which is necessary for statement.
   
   Changes proposed in this pull request:
   - MySQLParser add date function like `DATE_ADD` etc to `regularFunctionName_`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4056: MySQL date function

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4056: MySQL date function
URL: https://github.com/apache/incubator-shardingsphere/pull/4056
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4056: MySQL date function

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4056: MySQL date function
URL: https://github.com/apache/incubator-shardingsphere/pull/4056#issuecomment-576309734
 
 
   ## Pull Request Test Coverage Report for [Build 1451](https://coveralls.io/builds/28212219)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **53** unchanged lines in **5** files lost coverage.
   * Overall coverage decreased (**-0.02%**) to **66.89%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/log/ConfigurationLogger.java](https://coveralls.io/builds/28212219/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Flog%2FConfigurationLogger.java#L53) | 1 | 96.43% |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/service/ConfigurationService.java](https://coveralls.io/builds/28212219/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Fservice%2FConfigurationService.java#L181) | 1 | 98.36% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/value/NumberValue.java](https://coveralls.io/builds/28212219/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fvalue%2FNumberValue.java#L41) | 7 | 0% |
   | [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/yaml/engine/YamlEngine.java](https://coveralls.io/builds/28212219/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fyaml%2Fengine%2FYamlEngine.java#L58) | 15 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28212219/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L319) | 29 | 0% |
   <!-- | **Total:** | **53** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28212219/badge)](https://coveralls.io/builds/28212219) |
   | :-- | --: |
   | Change from base [Build 718](https://coveralls.io/builds/28207607): |  -0.02% |
   | Covered Lines: | 10895 |
   | Relevant Lines: | 16288 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services