You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by sh...@apache.org on 2022/05/28 04:32:28 UTC
[servicecomb-java-chassis] branch master updated: [SCB-2529] enable checkstyle NewlineAtEndOfFile (#3010)
This is an automated email from the ASF dual-hosted git repository.
shoothzj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git
The following commit(s) were added to refs/heads/master by this push:
new 2e45749c4 [SCB-2529] enable checkstyle NewlineAtEndOfFile (#3010)
2e45749c4 is described below
commit 2e45749c4b758db48ed3473a0875cffae55ecefd
Author: TingTing Wang <19...@qq.com>
AuthorDate: Sat May 28 12:32:21 2022 +0800
[SCB-2529] enable checkstyle NewlineAtEndOfFile (#3010)
---
ci/checkstyle/checkstyle.xml | 2 ++
.../config/center/client/AddressManager.java | 2 +-
.../http/client/common/HttpTransportImpl.java | 2 +-
.../service/center/client/model/SchemaInfo.java | 2 +-
.../element/impl/InvocationContextItemTest.java | 2 +-
.../converter/SwaggerToProtoGenerator.java | 2 +-
.../io/protostuff/runtime/model/ModelProtobuf.java | 8 +++----
.../rest/codec/param/RestClientRequestImpl.java | 2 +-
.../rest/RestProducerInvocationCreatorTest.java | 2 +-
.../common/rest/VertxRestInvocationTest.java | 2 +-
.../common/rest/codec/query/QueryCodecCsvTest.java | 2 +-
.../rest/codec/query/QueryCodecMultiTest.java | 2 +-
.../rest/codec/query/QueryCodecPipesTest.java | 2 +-
.../common/rest/codec/query/QueryCodecSsvTest.java | 2 +-
.../common/rest/codec/query/QueryCodecTsvTest.java | 2 +-
.../common/rest/codec/query/QueryCodecsTest.java | 2 +-
.../definition/path/PathVarParamWriterTest.java | 2 +-
.../definition/path/URLPathStringBuilderTest.java | 2 +-
.../filter/inner/RestServerCodecFilterTest.java | 2 +-
.../core/event/InvocationHandlersStartEvent.java | 2 +-
.../event/InvocationStartSendRequestEvent.java | 2 +-
.../core/event/InvocationTimeoutCheckEvent.java | 2 +-
.../impl/JacksonPropertyNodeNameProvider.java | 2 +-
.../core/filter/impl/ParameterValidatorFilter.java | 2 +-
.../invocation/endpoint/EndpointCacheUtils.java | 2 +-
.../core/invocation/endpoint/EndpointUtils.java | 2 +-
.../provider/producer/ProducerProviderManager.java | 2 +-
.../core/definition/OperationConfigTest.java | 2 +-
.../servicecomb/core/exception/ExceptionsTest.java | 2 +-
.../converter/TimeoutExceptionConverterTest.java | 2 +-
.../servicecomb/core/filter/FilterChainTest.java | 2 +-
.../filter/impl/ParameterValidatorFilterTest.java | 2 +-
.../filter/impl/ProducerOperationFilterTest.java | 2 +-
.../filter/impl/SimpleLoadBalanceFilterTest.java | 2 +-
.../invocation/ProducerInvocationFlowTest.java | 2 +-
.../core/invocation/endpoint/EndpointTest.java | 2 +-
.../invocation/endpoint/EndpointUtilsTest.java | 2 +-
.../timeout/PassingTimeStrategyTest.java | 2 +-
.../timeout/ProcessingTimeStrategyTest.java | 2 +-
.../servicecomb/demo/edge/consumer/Consumer.java | 4 ++--
.../encrypt/filter/EdgeSignatureRequestFilter.java | 2 +-
.../src/main/resources/config/log4j.properties | 2 +-
.../jaxrs/server/QueryParamWithListSchema.java | 10 ++++----
.../jaxrs/server/SchemeInterfaceJaxrsImpl.java | 2 +-
.../demo/multiServiceCenterClient/ServerBTest.java | 2 +-
.../src/main/resources/application.properties | 2 +-
.../demo/pojo/client/invoker/ClientModel.java | 2 +-
.../servicecomb/demo/pojo/server/TestImpl.java | 2 +-
.../servicecomb/demo/pojo/server/TestImpl.java | 2 +-
.../springmvc/client/ConsumerTestsAfterBootup.java | 4 ++--
.../demo/springmvc/server/DownloadSchema.java | 2 +-
.../demo/springmvc/third/EarlyConsumer.java | 2 +-
.../demo/springmvc/third/HealthSchema.java | 2 +-
.../demo/springmvc/third/NormalConsumer.java | 2 +-
.../servicecomb/demo/springmvc/third/Register.java | 2 +-
.../zeroconfig/client/ClientServerEndpoint.java | 2 +-
.../ConfigCenterConfigurationSourceImplTest.java | 2 +-
.../config/center/client/AddressManagerTest.java | 2 +-
.../foundation/common/event/AlarmEvent.java | 2 +-
.../foundation/common/log/AbstractMarker.java | 2 +-
.../foundation/common/utils/JvmUtils.java | 2 +-
.../foundation/common/DynamicObjectTest.java | 2 +-
.../foundation/common/base/DynamicEnumTest.java | 2 +-
.../foundation/common/utils/AsyncUtilsTest.java | 2 +-
.../config/DynamicWatchedConfigurationExt.java | 2 +-
.../config/inject/PlaceholderResolver.java | 2 +-
.../config/priority/ConfigObjectFactory.java | 2 +-
.../config/BootStrapPropertiesTest.java | 2 +-
.../priority/TestPriorityPropertyFactory.java | 2 +-
.../src/main/java/io/protostuff/package-info.java | 2 +-
.../serializer/repeated/AbstractWriters.java | 2 +-
.../protobuf/internal/model/CustomGeneric.java | 2 +-
.../protobuf/internal/model/ProtobufRoot.java | 12 +++++-----
.../internal/schema/scalar/TestFixed64Schema.java | 2 +-
.../internal/schema/scalar/TestUInt64Schema.java | 2 +-
.../servicecomb/registry/RegistrationManager.java | 2 +-
.../servicecomb/registry/consumer/AppManager.java | 2 +-
.../foundation/ssl/CertificateUtil.java | 2 +-
.../foundation/ssl/TrustManagerExt.java | 4 ++--
.../foundation/test/scaffolding/AssertUtils.java | 2 +-
.../src/main/resources/config/log4j.properties | 2 +-
.../foundation/vertx/server/TcpServer.java | 2 +-
.../foundation/vertx/http/TestReadStreamPart.java | 4 ++--
...stVertxServerResponseToHttpServletResponse.java | 4 ++--
.../event/GovernanceConfigurationChangedEvent.java | 2 +-
.../governance/marker/operator/MatchOperator.java | 2 +-
.../servicecomb/router/ExampleDistributor.java | 2 +-
.../filter/IsolationDiscoveryFilterTest.java | 2 +-
...riorityInstancePropertyDiscoveryFilterTest.java | 2 +-
.../apache/dynamicconfig/test/SimApolloServer.java | 2 +-
.../servicecomb/it/schema/objectparams/Color.java | 2 +-
.../schema/objectparams/FlattenObjectRequest.java | 2 +-
.../FluentSetterFlattenObjectRequest.java | 2 +-
.../java/org/apache/servicecomb/it/Consumers.java | 2 +-
.../org/apache/servicecomb/it/ResultPrinter.java | 2 +-
.../servicecomb/it/testcase/TestDownload.java | 2 +-
.../objectparams/TestSpringMVCObjectParamType.java | 28 +++++++++++-----------
.../servicecomb/it/edge/PreLoadBootListener.java | 2 +-
.../encrypt/filter/EdgeSignatureRequestFilter.java | 2 +-
.../it/schema/DefaultJsonValueJaxrsSchema.java | 2 +-
.../servicecomb/it/schema/DownloadSchema.java | 2 +-
.../demo/pojo/test/endpoints/TestImpl.java | 2 +-
.../PojoSpringConnectionLimitIntegrationTest.java | 2 +-
.../src/test/resources/log4j.properties | 2 +-
.../src/test/resources/microservice.yaml | 2 +-
.../demo/pojo/test/PojoSpringIntegrationTest.java | 2 +-
.../src/test/resources/microservice.yaml | 2 +-
.../servicecomb/tests/tracing/TracingTestBase.java | 2 +-
.../metrics/core/meter/os/net/InterfaceUsage.java | 2 +-
.../metrics/core/meter/os/net/NetStat.java | 2 +-
.../metrics/core/publish/DefaultLogPublisher.java | 2 +-
.../metrics/core/TestHealthBootListener.java | 2 +-
.../reference/async/CseAsyncRestTemplate.java | 2 +-
.../CseAsyncClientHttpRequestFactoryTest.java | 2 +-
.../async/CseAsyncClientHttpRequestTest.java | 2 +-
.../lightweight/AbstractLightweightDiscovery.java | 2 +-
.../AbstractLightweightRegistration.java | 2 +-
.../registry/lightweight/store/Store.java | 2 +-
.../registry/lightweight/MessageTest.java | 2 +-
.../registry/lightweight/StoreServiceTest.java | 2 +-
.../servicecomb/serviceregistry/api/Type.java | 2 +-
.../client/http/RestClientUtil.java | 4 ++--
.../client/http/ServiceRegistryClientImpl.java | 4 ++--
.../client/http/WebsocketClientUtil.java | 2 +-
.../diagnosis/instance/InstanceCacheChecker.java | 4 ++--
.../task/MicroserviceInstanceStatusSyncTask.java | 2 +-
.../serviceregistry/RegistryUtilsTest.java | 2 +-
.../serviceregistry/ServiceRegistryTest.java | 2 +-
.../auth/TestRBACBootStrapService.java | 2 +-
.../auth/TokenCacheManagerTest.java | 2 +-
.../refresh/AddressManagerTest.java | 2 +-
.../cache/AggregateServiceRegistryCacheTest.java | 2 +-
.../registry/cache/MicroserviceCacheKeyTest.java | 2 +-
.../cache/RefreshableMicroserviceCacheTest.java | 2 +-
.../cache/RefreshableServiceRegistryCacheTest.java | 2 +-
.../starter/servlet/RestServletInitializer.java | 2 +-
.../springboot2/starter/servlet/package-info.java | 2 +-
.../processor/parameter/JsonViewProcessor.java | 2 +-
.../swagger/converter/ConverterMgrTest.java | 2 +-
.../RequestPartAnnotationProcessorTest.java | 2 +-
.../InvocationContextCompletableFuture.java | 2 +-
.../part/PartListToPartArrayConverterTest.java | 2 +-
.../impl/part/PartListToPartListConverterTest.java | 2 +-
.../impl/part/PartToPartConverterTest.java | 2 +-
.../exception/CommonExceptionDataTest.java | 2 +-
.../invocation/validator/ParameterValidator.java | 2 +-
.../highway/HighwayServerCodecFilterTest.java | 2 +-
.../transport/rest/client/BoundaryFactory.java | 2 +-
.../rest/client/HttpClientRequestFactory.java | 3 ++-
.../rest/client/RestClientCodecFilterTest.java | 2 +-
.../rest/client/RestClientDecoderTest.java | 2 +-
.../rest/client/RestClientEncoderTest.java | 2 +-
.../RestClientTransportContextFactoryTest.java | 2 +-
153 files changed, 188 insertions(+), 185 deletions(-)
diff --git a/ci/checkstyle/checkstyle.xml b/ci/checkstyle/checkstyle.xml
index 963b85364..9afaa1249 100644
--- a/ci/checkstyle/checkstyle.xml
+++ b/ci/checkstyle/checkstyle.xml
@@ -26,6 +26,8 @@
Description: none
-->
<module name="Checker">
+ <module name="NewlineAtEndOfFile">
+ </module>
<module name="TreeWalker">
<module name="AvoidStarImport"/>
<module name="RedundantImport"/>
diff --git a/clients/config-center-client/src/main/java/org/apache/servicecomb/config/center/client/AddressManager.java b/clients/config-center-client/src/main/java/org/apache/servicecomb/config/center/client/AddressManager.java
index 1f4b24ce0..fc72e3635 100644
--- a/clients/config-center-client/src/main/java/org/apache/servicecomb/config/center/client/AddressManager.java
+++ b/clients/config-center-client/src/main/java/org/apache/servicecomb/config/center/client/AddressManager.java
@@ -43,4 +43,4 @@ public class AddressManager extends AbstractAddressManager {
public void onRefreshEndpointEvent(RefreshEndpointEvent event) {
refreshEndpoint(event, RefreshEndpointEvent.CONFIG_CENTER_NAME);
}
-}
\ No newline at end of file
+}
diff --git a/clients/http-client-common/src/main/java/org/apache/servicecomb/http/client/common/HttpTransportImpl.java b/clients/http-client-common/src/main/java/org/apache/servicecomb/http/client/common/HttpTransportImpl.java
index 496cdd141..da8789292 100644
--- a/clients/http-client-common/src/main/java/org/apache/servicecomb/http/client/common/HttpTransportImpl.java
+++ b/clients/http-client-common/src/main/java/org/apache/servicecomb/http/client/common/HttpTransportImpl.java
@@ -107,4 +107,4 @@ public class HttpTransportImpl implements HttpTransport {
public void addHeaders(Map<String, String> headers) {
this.globalHeaders = headers;
}
-}
\ No newline at end of file
+}
diff --git a/clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/model/SchemaInfo.java b/clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/model/SchemaInfo.java
index 720e0e98b..40180433d 100755
--- a/clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/model/SchemaInfo.java
+++ b/clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/model/SchemaInfo.java
@@ -57,4 +57,4 @@ public class SchemaInfo {
public void setSummary(String summary) {
this.summary = summary;
}
-}
\ No newline at end of file
+}
diff --git a/common/common-access-log/src/test/java/org/apache/servicecomb/common/accessLog/core/element/impl/InvocationContextItemTest.java b/common/common-access-log/src/test/java/org/apache/servicecomb/common/accessLog/core/element/impl/InvocationContextItemTest.java
index 9bcda0ac4..644ac99de 100644
--- a/common/common-access-log/src/test/java/org/apache/servicecomb/common/accessLog/core/element/impl/InvocationContextItemTest.java
+++ b/common/common-access-log/src/test/java/org/apache/servicecomb/common/accessLog/core/element/impl/InvocationContextItemTest.java
@@ -148,4 +148,4 @@ public class InvocationContextItemTest {
ITEM.appendClientFormattedItem(finishEvent, strBuilder);
MatcherAssert.assertThat(strBuilder.toString(), Matchers.is(InvocationContextAccessItem.NOT_FOUND));
}
-}
\ No newline at end of file
+}
diff --git a/common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/internal/converter/SwaggerToProtoGenerator.java b/common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/internal/converter/SwaggerToProtoGenerator.java
index 841bab20c..8df320d26 100644
--- a/common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/internal/converter/SwaggerToProtoGenerator.java
+++ b/common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/internal/converter/SwaggerToProtoGenerator.java
@@ -242,7 +242,7 @@ public class SwaggerToProtoGenerator {
private String tryFindEnumType(List<String> enums) {
if (enums != null && !enums.isEmpty()) {
String strEnums = enums.toString();
- String enumName = "Enum_" + Hashing.sha256().hashString(strEnums, StandardCharsets.UTF_8).toString();
+ String enumName = "Enum_" + Hashing.sha256().hashString(strEnums, StandardCharsets.UTF_8);
pending.add(() -> createEnum(enumName, enums));
return enumName;
}
diff --git a/common/common-protobuf/src/test/java/io/protostuff/runtime/model/ModelProtobuf.java b/common/common-protobuf/src/test/java/io/protostuff/runtime/model/ModelProtobuf.java
index a4a2eb555..9bde21a30 100644
--- a/common/common-protobuf/src/test/java/io/protostuff/runtime/model/ModelProtobuf.java
+++ b/common/common-protobuf/src/test/java/io/protostuff/runtime/model/ModelProtobuf.java
@@ -2167,8 +2167,8 @@ io.protostuff.runtime.model.ModelProtobuf.User defaultValue);
}
private com.google.protobuf.MapField<java.lang.String, java.lang.String>
internalGetMutableCseContext() {
- onChanged();;
- if (cseContext_ == null) {
+ onChanged();
+ if (cseContext_ == null) {
cseContext_ = com.google.protobuf.MapField.newMapField(
CseContextDefaultEntryHolder.defaultEntry);
}
@@ -2298,8 +2298,8 @@ io.protostuff.runtime.model.ModelProtobuf.User defaultValue);
}
private com.google.protobuf.MapField<java.lang.String, io.protostuff.runtime.model.ModelProtobuf.User>
internalGetMutableUserMap() {
- onChanged();;
- if (userMap_ == null) {
+ onChanged();
+ if (userMap_ == null) {
userMap_ = com.google.protobuf.MapField.newMapField(
UserMapDefaultEntryHolder.defaultEntry);
}
diff --git a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/RestClientRequestImpl.java b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/RestClientRequestImpl.java
index 1280af73f..b02242b94 100644
--- a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/RestClientRequestImpl.java
+++ b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/RestClientRequestImpl.java
@@ -134,7 +134,7 @@ public class RestClientRequestImpl implements RestClientRequest {
protected Future<Void> doEndWithUpload() {
request.setChunked(true);
- String boundary = "boundary" + UUID.randomUUID().toString();
+ String boundary = "boundary" + UUID.randomUUID();
putHeader(CONTENT_TYPE, MULTIPART_FORM_DATA + "; charset=UTF-8; boundary=" + boundary);
return genBodyForm(boundary).onSuccess(v -> attachFiles(boundary)).onFailure(e -> asyncResp.consumerFail(e));
diff --git a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/RestProducerInvocationCreatorTest.java b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/RestProducerInvocationCreatorTest.java
index f8159a60e..18697dbf5 100644
--- a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/RestProducerInvocationCreatorTest.java
+++ b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/RestProducerInvocationCreatorTest.java
@@ -181,4 +181,4 @@ public class RestProducerInvocationCreatorTest {
assertThat(invocation.getContext("k")).isEqualTo("v");
}
-}
\ No newline at end of file
+}
diff --git a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/VertxRestInvocationTest.java b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/VertxRestInvocationTest.java
index 28ab24b89..235699897 100644
--- a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/VertxRestInvocationTest.java
+++ b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/VertxRestInvocationTest.java
@@ -54,4 +54,4 @@ public class VertxRestInvocationTest {
Mockito.verify(routingContext, Mockito.times(1)).put(RestConst.REST_INVOCATION_CONTEXT, invocation);
}
-}
\ No newline at end of file
+}
diff --git a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecCsvTest.java b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecCsvTest.java
index 18e9ba48c..3d34e1097 100644
--- a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecCsvTest.java
+++ b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecCsvTest.java
@@ -114,4 +114,4 @@ class QueryCodecCsvTest extends QueryCodecTestBase {
should_decode(",,1", new int[] {0, 0, 1});
}
}
-}
\ No newline at end of file
+}
diff --git a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecMultiTest.java b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecMultiTest.java
index 948b83129..759b74d69 100644
--- a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecMultiTest.java
+++ b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecMultiTest.java
@@ -104,4 +104,4 @@ class QueryCodecMultiTest extends QueryCodecTestBase {
should_decode((String) null, null);
}
}
-}
\ No newline at end of file
+}
diff --git a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecPipesTest.java b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecPipesTest.java
index aaa071231..3b7f33459 100644
--- a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecPipesTest.java
+++ b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecPipesTest.java
@@ -114,4 +114,4 @@ class QueryCodecPipesTest extends QueryCodecTestBase {
should_decode("||1", new int[] {0, 0, 1});
}
}
-}
\ No newline at end of file
+}
diff --git a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecSsvTest.java b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecSsvTest.java
index bbbfb550c..c719eae08 100644
--- a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecSsvTest.java
+++ b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecSsvTest.java
@@ -114,4 +114,4 @@ class QueryCodecSsvTest extends QueryCodecTestBase {
should_decode(" 1", new int[] {0, 0, 1});
}
}
-}
\ No newline at end of file
+}
diff --git a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecTsvTest.java b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecTsvTest.java
index 2a8359915..2e913bf29 100644
--- a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecTsvTest.java
+++ b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecTsvTest.java
@@ -114,4 +114,4 @@ class QueryCodecTsvTest extends QueryCodecTestBase {
should_decode("\t\t1", new int[] {0, 0, 1});
}
}
-}
\ No newline at end of file
+}
diff --git a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecsTest.java b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecsTest.java
index c2c5fed1f..7ccdbb2b3 100644
--- a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecsTest.java
+++ b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecsTest.java
@@ -40,4 +40,4 @@ class QueryCodecsTest {
assertThat(queryCodecs.find(QueryCodecCsv.CODEC_NAME).getClass())
.isEqualTo(MyQueryCodecCsv.class);
}
-}
\ No newline at end of file
+}
diff --git a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/definition/path/PathVarParamWriterTest.java b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/definition/path/PathVarParamWriterTest.java
index 04ab59c92..81e8658fd 100644
--- a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/definition/path/PathVarParamWriterTest.java
+++ b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/definition/path/PathVarParamWriterTest.java
@@ -93,4 +93,4 @@ public class PathVarParamWriterTest {
}.getMockInstance();
return new PathVarParamWriter(restParam);
}
-}
\ No newline at end of file
+}
diff --git a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/definition/path/URLPathStringBuilderTest.java b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/definition/path/URLPathStringBuilderTest.java
index 80cc23705..5ccb4a7ef 100644
--- a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/definition/path/URLPathStringBuilderTest.java
+++ b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/definition/path/URLPathStringBuilderTest.java
@@ -50,4 +50,4 @@ public class URLPathStringBuilderTest {
builder.appendQuery("gh", "jk");
Assertions.assertEquals("?ab=cd&ef=&gh=jk", builder.build());
}
-}
\ No newline at end of file
+}
diff --git a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/filter/inner/RestServerCodecFilterTest.java b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/filter/inner/RestServerCodecFilterTest.java
index 24942a076..204dfe564 100644
--- a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/filter/inner/RestServerCodecFilterTest.java
+++ b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/filter/inner/RestServerCodecFilterTest.java
@@ -218,4 +218,4 @@ public class RestServerCodecFilterTest {
}
};
}
-}
\ No newline at end of file
+}
diff --git a/core/src/main/java/org/apache/servicecomb/core/event/InvocationHandlersStartEvent.java b/core/src/main/java/org/apache/servicecomb/core/event/InvocationHandlersStartEvent.java
index a064b1648..55d57001b 100644
--- a/core/src/main/java/org/apache/servicecomb/core/event/InvocationHandlersStartEvent.java
+++ b/core/src/main/java/org/apache/servicecomb/core/event/InvocationHandlersStartEvent.java
@@ -23,4 +23,4 @@ public class InvocationHandlersStartEvent extends InvocationBaseEvent {
public InvocationHandlersStartEvent(Invocation invocation) {
super(invocation);
}
-}
\ No newline at end of file
+}
diff --git a/core/src/main/java/org/apache/servicecomb/core/event/InvocationStartSendRequestEvent.java b/core/src/main/java/org/apache/servicecomb/core/event/InvocationStartSendRequestEvent.java
index a5bd8c8ac..9a8770ea8 100644
--- a/core/src/main/java/org/apache/servicecomb/core/event/InvocationStartSendRequestEvent.java
+++ b/core/src/main/java/org/apache/servicecomb/core/event/InvocationStartSendRequestEvent.java
@@ -23,4 +23,4 @@ public class InvocationStartSendRequestEvent extends InvocationBaseEvent {
public InvocationStartSendRequestEvent(Invocation invocation) {
super(invocation);
}
-}
\ No newline at end of file
+}
diff --git a/core/src/main/java/org/apache/servicecomb/core/event/InvocationTimeoutCheckEvent.java b/core/src/main/java/org/apache/servicecomb/core/event/InvocationTimeoutCheckEvent.java
index 168081eb8..3dc563161 100644
--- a/core/src/main/java/org/apache/servicecomb/core/event/InvocationTimeoutCheckEvent.java
+++ b/core/src/main/java/org/apache/servicecomb/core/event/InvocationTimeoutCheckEvent.java
@@ -23,4 +23,4 @@ public class InvocationTimeoutCheckEvent extends InvocationBaseEvent {
public InvocationTimeoutCheckEvent(Invocation invocation) {
super(invocation);
}
-}
\ No newline at end of file
+}
diff --git a/core/src/main/java/org/apache/servicecomb/core/filter/impl/JacksonPropertyNodeNameProvider.java b/core/src/main/java/org/apache/servicecomb/core/filter/impl/JacksonPropertyNodeNameProvider.java
index 403ca6cfd..f617f5fe5 100644
--- a/core/src/main/java/org/apache/servicecomb/core/filter/impl/JacksonPropertyNodeNameProvider.java
+++ b/core/src/main/java/org/apache/servicecomb/core/filter/impl/JacksonPropertyNodeNameProvider.java
@@ -54,4 +54,4 @@ public class JacksonPropertyNodeNameProvider implements PropertyNodeNameProvider
.findFirst()
.orElse(property.getName());
}
-}
\ No newline at end of file
+}
diff --git a/core/src/main/java/org/apache/servicecomb/core/filter/impl/ParameterValidatorFilter.java b/core/src/main/java/org/apache/servicecomb/core/filter/impl/ParameterValidatorFilter.java
index c1d1e70df..4b2bcaba2 100644
--- a/core/src/main/java/org/apache/servicecomb/core/filter/impl/ParameterValidatorFilter.java
+++ b/core/src/main/java/org/apache/servicecomb/core/filter/impl/ParameterValidatorFilter.java
@@ -90,7 +90,7 @@ public class ParameterValidatorFilter implements ProducerFilter, InitializingBea
public CompletableFuture<Response> onFilter(Invocation invocation, FilterNode nextNode) {
Set<ConstraintViolation<Object>> violations = doValidate(invocation);
if (violations.size() > 0) {
- LOGGER.error("Parameter validation failed : " + violations.toString());
+ LOGGER.error("Parameter validation failed : " + violations);
return AsyncUtils.completeExceptionally(new ConstraintViolationException(violations));
}
diff --git a/core/src/main/java/org/apache/servicecomb/core/invocation/endpoint/EndpointCacheUtils.java b/core/src/main/java/org/apache/servicecomb/core/invocation/endpoint/EndpointCacheUtils.java
index 316a48bf2..141a6e906 100644
--- a/core/src/main/java/org/apache/servicecomb/core/invocation/endpoint/EndpointCacheUtils.java
+++ b/core/src/main/java/org/apache/servicecomb/core/invocation/endpoint/EndpointCacheUtils.java
@@ -44,4 +44,4 @@ public final class EndpointCacheUtils {
public static Endpoint create(String uri) {
return EndpointUtils.parse(EndpointUtils.formatFromUri(uri));
}
-}
\ No newline at end of file
+}
diff --git a/core/src/main/java/org/apache/servicecomb/core/invocation/endpoint/EndpointUtils.java b/core/src/main/java/org/apache/servicecomb/core/invocation/endpoint/EndpointUtils.java
index 6aa4cc531..d906de63b 100644
--- a/core/src/main/java/org/apache/servicecomb/core/invocation/endpoint/EndpointUtils.java
+++ b/core/src/main/java/org/apache/servicecomb/core/invocation/endpoint/EndpointUtils.java
@@ -135,7 +135,7 @@ public final class EndpointUtils {
if (path.startsWith("/")) {
path = path.substring(1);
}
- if (path.indexOf("/") != -1) {
+ if (path.contains("/")) {
path = path.substring(0, path.indexOf("/"));
}
return path;
diff --git a/core/src/main/java/org/apache/servicecomb/core/provider/producer/ProducerProviderManager.java b/core/src/main/java/org/apache/servicecomb/core/provider/producer/ProducerProviderManager.java
index 6a2c484f3..752df947f 100644
--- a/core/src/main/java/org/apache/servicecomb/core/provider/producer/ProducerProviderManager.java
+++ b/core/src/main/java/org/apache/servicecomb/core/provider/producer/ProducerProviderManager.java
@@ -130,4 +130,4 @@ public class ProducerProviderManager {
swagger.setBasePath(urlPrefix + swagger.getBasePath());
}
}
-}
\ No newline at end of file
+}
diff --git a/core/src/test/java/org/apache/servicecomb/core/definition/OperationConfigTest.java b/core/src/test/java/org/apache/servicecomb/core/definition/OperationConfigTest.java
index dc8076bef..3a2ae4d1c 100644
--- a/core/src/test/java/org/apache/servicecomb/core/definition/OperationConfigTest.java
+++ b/core/src/test/java/org/apache/servicecomb/core/definition/OperationConfigTest.java
@@ -68,4 +68,4 @@ class OperationConfigTest {
assertThat(config.getMsInvocationTimeout()).isEqualTo(1);
}
}
-}
\ No newline at end of file
+}
diff --git a/core/src/test/java/org/apache/servicecomb/core/exception/ExceptionsTest.java b/core/src/test/java/org/apache/servicecomb/core/exception/ExceptionsTest.java
index c0cd78a95..1ff9aab9c 100644
--- a/core/src/test/java/org/apache/servicecomb/core/exception/ExceptionsTest.java
+++ b/core/src/test/java/org/apache/servicecomb/core/exception/ExceptionsTest.java
@@ -106,4 +106,4 @@ class ExceptionsTest {
+ "converter exception:org.apache.servicecomb.foundation.test.scaffolding.exception.RuntimeExceptionWithoutStackTrace: mock exception when convert\n");
}
}
-}
\ No newline at end of file
+}
diff --git a/core/src/test/java/org/apache/servicecomb/core/exception/converter/TimeoutExceptionConverterTest.java b/core/src/test/java/org/apache/servicecomb/core/exception/converter/TimeoutExceptionConverterTest.java
index e82e4636f..4de741c51 100644
--- a/core/src/test/java/org/apache/servicecomb/core/exception/converter/TimeoutExceptionConverterTest.java
+++ b/core/src/test/java/org/apache/servicecomb/core/exception/converter/TimeoutExceptionConverterTest.java
@@ -55,4 +55,4 @@ class TimeoutExceptionConverterTest {
"Request timeout, Details: The timeout period of 30000ms has been exceeded while executing GET /xxx for server 1.1.1.1:8080.");
}
}
-}
\ No newline at end of file
+}
diff --git a/core/src/test/java/org/apache/servicecomb/core/filter/FilterChainTest.java b/core/src/test/java/org/apache/servicecomb/core/filter/FilterChainTest.java
index aa78b07a5..aece3799a 100644
--- a/core/src/test/java/org/apache/servicecomb/core/filter/FilterChainTest.java
+++ b/core/src/test/java/org/apache/servicecomb/core/filter/FilterChainTest.java
@@ -216,4 +216,4 @@ public class FilterChainTest {
.get();
assertThat(msg).containsExactly("main", THREAD_NAME, THREAD_NAME);
}
-}
\ No newline at end of file
+}
diff --git a/core/src/test/java/org/apache/servicecomb/core/filter/impl/ParameterValidatorFilterTest.java b/core/src/test/java/org/apache/servicecomb/core/filter/impl/ParameterValidatorFilterTest.java
index d21e9a991..7942a355f 100644
--- a/core/src/test/java/org/apache/servicecomb/core/filter/impl/ParameterValidatorFilterTest.java
+++ b/core/src/test/java/org/apache/servicecomb/core/filter/impl/ParameterValidatorFilterTest.java
@@ -171,4 +171,4 @@ public class ParameterValidatorFilterTest {
assertThat(details.stream().map(ValidateDetail::getMessage))
.contains("not null", "can not be null", "can not be blank");
}
-}
\ No newline at end of file
+}
diff --git a/core/src/test/java/org/apache/servicecomb/core/filter/impl/ProducerOperationFilterTest.java b/core/src/test/java/org/apache/servicecomb/core/filter/impl/ProducerOperationFilterTest.java
index b7403e987..91cb0f832 100644
--- a/core/src/test/java/org/apache/servicecomb/core/filter/impl/ProducerOperationFilterTest.java
+++ b/core/src/test/java/org/apache/servicecomb/core/filter/impl/ProducerOperationFilterTest.java
@@ -201,4 +201,4 @@ public class ProducerOperationFilterTest {
CommonExceptionData data = (CommonExceptionData) throwable.getErrorData();
assertThat(data.getMessage()).isEqualTo("Parameters not valid or types not match.");
}
-}
\ No newline at end of file
+}
diff --git a/core/src/test/java/org/apache/servicecomb/core/filter/impl/SimpleLoadBalanceFilterTest.java b/core/src/test/java/org/apache/servicecomb/core/filter/impl/SimpleLoadBalanceFilterTest.java
index 589df771c..08c1eda3f 100644
--- a/core/src/test/java/org/apache/servicecomb/core/filter/impl/SimpleLoadBalanceFilterTest.java
+++ b/core/src/test/java/org/apache/servicecomb/core/filter/impl/SimpleLoadBalanceFilterTest.java
@@ -73,4 +73,4 @@ public class SimpleLoadBalanceFilterTest {
}
};
}
-}
\ No newline at end of file
+}
diff --git a/core/src/test/java/org/apache/servicecomb/core/invocation/ProducerInvocationFlowTest.java b/core/src/test/java/org/apache/servicecomb/core/invocation/ProducerInvocationFlowTest.java
index f1d3ef76d..1cc4b4db8 100644
--- a/core/src/test/java/org/apache/servicecomb/core/invocation/ProducerInvocationFlowTest.java
+++ b/core/src/test/java/org/apache/servicecomb/core/invocation/ProducerInvocationFlowTest.java
@@ -156,4 +156,4 @@ public class ProducerInvocationFlowTest {
}
};
}
-}
\ No newline at end of file
+}
diff --git a/core/src/test/java/org/apache/servicecomb/core/invocation/endpoint/EndpointTest.java b/core/src/test/java/org/apache/servicecomb/core/invocation/endpoint/EndpointTest.java
index aa9c3a8c6..d6203589c 100644
--- a/core/src/test/java/org/apache/servicecomb/core/invocation/endpoint/EndpointTest.java
+++ b/core/src/test/java/org/apache/servicecomb/core/invocation/endpoint/EndpointTest.java
@@ -93,4 +93,4 @@ public class EndpointTest {
assertThat(holder.value).isSameAs(endpoint);
}
-}
\ No newline at end of file
+}
diff --git a/core/src/test/java/org/apache/servicecomb/core/invocation/endpoint/EndpointUtilsTest.java b/core/src/test/java/org/apache/servicecomb/core/invocation/endpoint/EndpointUtilsTest.java
index 2338cca0c..43cc21ba4 100644
--- a/core/src/test/java/org/apache/servicecomb/core/invocation/endpoint/EndpointUtilsTest.java
+++ b/core/src/test/java/org/apache/servicecomb/core/invocation/endpoint/EndpointUtilsTest.java
@@ -117,4 +117,4 @@ class EndpointUtilsTest {
assertThat(formatFromUri("abc://host:123?q1=v1")).isEqualTo("abc://host:123?q1=v1");
}
}
-}
\ No newline at end of file
+}
diff --git a/core/src/test/java/org/apache/servicecomb/core/invocation/timeout/PassingTimeStrategyTest.java b/core/src/test/java/org/apache/servicecomb/core/invocation/timeout/PassingTimeStrategyTest.java
index 5aa991473..9481fd19e 100644
--- a/core/src/test/java/org/apache/servicecomb/core/invocation/timeout/PassingTimeStrategyTest.java
+++ b/core/src/test/java/org/apache/servicecomb/core/invocation/timeout/PassingTimeStrategyTest.java
@@ -75,4 +75,4 @@ class PassingTimeStrategyTest {
assertThat(elapsedNanoTime).isEqualTo(TimeUnit.MILLISECONDS.toNanos(90));
}
-}
\ No newline at end of file
+}
diff --git a/core/src/test/java/org/apache/servicecomb/core/invocation/timeout/ProcessingTimeStrategyTest.java b/core/src/test/java/org/apache/servicecomb/core/invocation/timeout/ProcessingTimeStrategyTest.java
index e348f1067..07d84e5b3 100644
--- a/core/src/test/java/org/apache/servicecomb/core/invocation/timeout/ProcessingTimeStrategyTest.java
+++ b/core/src/test/java/org/apache/servicecomb/core/invocation/timeout/ProcessingTimeStrategyTest.java
@@ -86,4 +86,4 @@ class ProcessingTimeStrategyTest {
assertThat(invocation.getContext(CHAIN_PROCESSING)).isEqualTo("60");
}
-}
\ No newline at end of file
+}
diff --git a/demo/demo-edge/consumer/src/main/java/org/apache/servicecomb/demo/edge/consumer/Consumer.java b/demo/demo-edge/consumer/src/main/java/org/apache/servicecomb/demo/edge/consumer/Consumer.java
index 6d00edbd3..015d3bd59 100644
--- a/demo/demo-edge/consumer/src/main/java/org/apache/servicecomb/demo/edge/consumer/Consumer.java
+++ b/demo/demo-edge/consumer/src/main/java/org/apache/servicecomb/demo/edge/consumer/Consumer.java
@@ -141,7 +141,7 @@ public class Consumer {
String expected = "{name=userName, age=10, userId=serviceTokenTest-userId, body1=b1, body2=b2, body3=b3}";
Assert.isTrue(expected.equalsIgnoreCase(result.toString()),
- String.format("expected: %s\nreal : %s", expected, result.toString()));
+ String.format("expected: %s\nreal : %s", expected, result));
}
protected void testRecursiveSelf() {
@@ -227,7 +227,7 @@ public class Consumer {
}
return null;
});
- Assert.isTrue(size.get() == 10 * 1024 * 1024, "size is : " + String.valueOf(size.get()) + " not 10 * 1024 * 1024");
+ Assert.isTrue(size.get() == 10 * 1024 * 1024, "size is : " + size.get() + " not 10 * 1024 * 1024");
System.out.println("test download bigFile finished");
}
diff --git a/demo/demo-edge/edge-service/src/main/java/org/apache/servicecomb/demo/edge/service/encrypt/filter/EdgeSignatureRequestFilter.java b/demo/demo-edge/edge-service/src/main/java/org/apache/servicecomb/demo/edge/service/encrypt/filter/EdgeSignatureRequestFilter.java
index 0eae860c2..3df32f6b4 100644
--- a/demo/demo-edge/edge-service/src/main/java/org/apache/servicecomb/demo/edge/service/encrypt/filter/EdgeSignatureRequestFilter.java
+++ b/demo/demo-edge/edge-service/src/main/java/org/apache/servicecomb/demo/edge/service/encrypt/filter/EdgeSignatureRequestFilter.java
@@ -60,7 +60,7 @@ public class EdgeSignatureRequestFilter implements HttpServerFilter {
hasher.putString(name, StandardCharsets.UTF_8);
hasher.putString(requestEx.getParameter(name), StandardCharsets.UTF_8);
}
- LOGGER.info("afterReceiveRequest signature: {}", hasher.hash().toString());
+ LOGGER.info("afterReceiveRequest signature: {}", hasher.hash());
return null;
}
diff --git a/demo/demo-edge/edge-service/src/main/resources/config/log4j.properties b/demo/demo-edge/edge-service/src/main/resources/config/log4j.properties
index efd6a27d9..0eb85f6a5 100644
--- a/demo/demo-edge/edge-service/src/main/resources/config/log4j.properties
+++ b/demo/demo-edge/edge-service/src/main/resources/config/log4j.properties
@@ -16,4 +16,4 @@
#
log4j.rootLogger=INFO,stdout
-log4j.appender.stdout.layout.ConversionPattern=[%d{yyyy-MM-dd HH:mm:ss,SSS/zzz}][%t][%p]%m %l%n
\ No newline at end of file
+log4j.appender.stdout.layout.ConversionPattern=[%d{yyyy-MM-dd HH:mm:ss,SSS/zzz}][%t][%p]%m %l%n
diff --git a/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/QueryParamWithListSchema.java b/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/QueryParamWithListSchema.java
index c1fcfd908..d63b313f6 100644
--- a/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/QueryParamWithListSchema.java
+++ b/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/QueryParamWithListSchema.java
@@ -33,30 +33,30 @@ public class QueryParamWithListSchema {
@Path("queryListCSV")
@GET
public String queryListCSV(@ApiParam(collectionFormat = "csv") @QueryParam("queryList") List<String> queryList) {
- return queryList == null ? "null" : queryList.size() + ":" + queryList.toString();
+ return queryList == null ? "null" : queryList.size() + ":" + queryList;
}
@Path("queryListSSV")
@GET
public String queryListSSV(@ApiParam(collectionFormat = "ssv") @QueryParam("queryList") List<String> queryList) {
- return queryList == null ? "null" : queryList.size() + ":" + queryList.toString();
+ return queryList == null ? "null" : queryList.size() + ":" + queryList;
}
@Path("queryListTSV")
@GET
public String queryListTSV(@ApiParam(collectionFormat = "tsv") @QueryParam("queryList") List<String> queryList) {
- return queryList == null ? "null" : queryList.size() + ":" + queryList.toString();
+ return queryList == null ? "null" : queryList.size() + ":" + queryList;
}
@Path("queryListPIPES")
@GET
public String queryListPIPES(@ApiParam(collectionFormat = "pipes") @QueryParam("queryList") List<String> queryList) {
- return queryList == null ? "null" : queryList.size() + ":" + queryList.toString();
+ return queryList == null ? "null" : queryList.size() + ":" + queryList;
}
@Path("queryListMULTI")
@GET
public String queryListMULTI(@ApiParam(collectionFormat = "multi") @QueryParam("queryList") List<String> queryList) {
- return queryList == null ? "null" : queryList.size() + ":" + queryList.toString();
+ return queryList == null ? "null" : queryList.size() + ":" + queryList;
}
}
diff --git a/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/SchemeInterfaceJaxrsImpl.java b/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/SchemeInterfaceJaxrsImpl.java
index 862db168d..a55164483 100644
--- a/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/SchemeInterfaceJaxrsImpl.java
+++ b/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/SchemeInterfaceJaxrsImpl.java
@@ -32,7 +32,7 @@ public class SchemeInterfaceJaxrsImpl implements SchemeInterfaceJaxrs {
}
public int add(String a, String b) {
- return Integer.valueOf(a) + Integer.valueOf(b);
+ return Integer.parseInt(a) + Integer.parseInt(b);
}
@Override
diff --git a/demo/demo-multi-service-center/demo-multi-service-center-client/src/main/java/org/apache/servicecomb/demo/multiServiceCenterClient/ServerBTest.java b/demo/demo-multi-service-center/demo-multi-service-center-client/src/main/java/org/apache/servicecomb/demo/multiServiceCenterClient/ServerBTest.java
index cbb2b42c0..f76836d4e 100644
--- a/demo/demo-multi-service-center/demo-multi-service-center-client/src/main/java/org/apache/servicecomb/demo/multiServiceCenterClient/ServerBTest.java
+++ b/demo/demo-multi-service-center/demo-multi-service-center-client/src/main/java/org/apache/servicecomb/demo/multiServiceCenterClient/ServerBTest.java
@@ -64,4 +64,4 @@ public class ServerBTest implements CategorizedTestCase {
public String getMicroserviceName() {
return "demo-multi-service-center-serverB";
}
-}
\ No newline at end of file
+}
diff --git a/demo/demo-multi-service-center/demo-multi-service-center-serverB/src/main/resources/application.properties b/demo/demo-multi-service-center/demo-multi-service-center-serverB/src/main/resources/application.properties
index 6072aab45..121f1aa95 100644
--- a/demo/demo-multi-service-center/demo-multi-service-center-serverB/src/main/resources/application.properties
+++ b/demo/demo-multi-service-center/demo-multi-service-center-serverB/src/main/resources/application.properties
@@ -17,4 +17,4 @@
demo.multi.service.center.serverB.actual.key6=key6
demo.multi.service.center.serverB.actual.key7.1=key71
-demo.multi.service.center.serverB.actual.key7.2=key72
\ No newline at end of file
+demo.multi.service.center.serverB.actual.key7.2=key72
diff --git a/demo/demo-pojo/pojo-client/src/main/java/org/apache/servicecomb/demo/pojo/client/invoker/ClientModel.java b/demo/demo-pojo/pojo-client/src/main/java/org/apache/servicecomb/demo/pojo/client/invoker/ClientModel.java
index 52f4bd92c..fd699064d 100644
--- a/demo/demo-pojo/pojo-client/src/main/java/org/apache/servicecomb/demo/pojo/client/invoker/ClientModel.java
+++ b/demo/demo-pojo/pojo-client/src/main/java/org/apache/servicecomb/demo/pojo/client/invoker/ClientModel.java
@@ -36,4 +36,4 @@ public class ClientModel {
public void setCode(int code) {
this.code = code;
}
-}
\ No newline at end of file
+}
diff --git a/demo/demo-pojo/pojo-server/src/main/java/org/apache/servicecomb/demo/pojo/server/TestImpl.java b/demo/demo-pojo/pojo-server/src/main/java/org/apache/servicecomb/demo/pojo/server/TestImpl.java
index be1bacab1..711f59007 100644
--- a/demo/demo-pojo/pojo-server/src/main/java/org/apache/servicecomb/demo/pojo/server/TestImpl.java
+++ b/demo/demo-pojo/pojo-server/src/main/java/org/apache/servicecomb/demo/pojo/server/TestImpl.java
@@ -37,7 +37,7 @@ public class TestImpl implements Test {
@Override
public String getTestString(String code) {
- return String.format("code is '%s'", String.valueOf(code));
+ return String.format("code is '%s'", code);
}
@Override
diff --git a/demo/demo-spring-boot-transport/demo-spring-boot-pojo-server/src/main/java/org/apache/servicecomb/demo/pojo/server/TestImpl.java b/demo/demo-spring-boot-transport/demo-spring-boot-pojo-server/src/main/java/org/apache/servicecomb/demo/pojo/server/TestImpl.java
index c842f9294..bfe57e670 100644
--- a/demo/demo-spring-boot-transport/demo-spring-boot-pojo-server/src/main/java/org/apache/servicecomb/demo/pojo/server/TestImpl.java
+++ b/demo/demo-spring-boot-transport/demo-spring-boot-pojo-server/src/main/java/org/apache/servicecomb/demo/pojo/server/TestImpl.java
@@ -35,7 +35,7 @@ public class TestImpl implements Test {
@Override
public String getTestString(String code) {
- return String.format("code is '%s'", String.valueOf(code));
+ return String.format("code is '%s'", code);
}
@Override
diff --git a/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/ConsumerTestsAfterBootup.java b/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/ConsumerTestsAfterBootup.java
index 1624a2145..aabf0d0bd 100644
--- a/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/ConsumerTestsAfterBootup.java
+++ b/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/ConsumerTestsAfterBootup.java
@@ -18,7 +18,7 @@ package org.apache.servicecomb.demo.springmvc.client;
import java.io.IOException;
import java.io.InputStream;
-import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
import org.apache.servicecomb.core.BootListener;
import org.apache.servicecomb.demo.TestMgr;
@@ -49,7 +49,7 @@ public class ConsumerTestsAfterBootup implements BootListener {
int len = inputStream.read(buffer);
TestMgr.check(2048 * 10 > len, true);
inputStream.close();
- return new String(buffer, 0, len, Charset.forName("UTF-8"));
+ return new String(buffer, 0, len, StandardCharsets.UTF_8);
} catch (IOException e) {
TestMgr.failed(e.getMessage(), e);
return null;
diff --git a/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/DownloadSchema.java b/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/DownloadSchema.java
index 5079017c0..c75775f24 100644
--- a/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/DownloadSchema.java
+++ b/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/DownloadSchema.java
@@ -48,7 +48,7 @@ public class DownloadSchema {
private File createTempFile(String name, String content) throws IOException {
if (name == null) {
- name = "download-" + UUID.randomUUID().toString() + ".txt";
+ name = "download-" + UUID.randomUUID() + ".txt";
}
File file = new File(tempDir, name);
FileUtils.write(file, content, StandardCharsets.UTF_8, false);
diff --git a/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/third/EarlyConsumer.java b/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/third/EarlyConsumer.java
index eb43fe1ae..6e282df8a 100644
--- a/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/third/EarlyConsumer.java
+++ b/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/third/EarlyConsumer.java
@@ -59,4 +59,4 @@ public class EarlyConsumer implements BootListener {
public void onAfterRegistry(BootEvent event) {
stopped = true;
}
-}
\ No newline at end of file
+}
diff --git a/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/third/HealthSchema.java b/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/third/HealthSchema.java
index d1f8be2b4..eab4a09e8 100644
--- a/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/third/HealthSchema.java
+++ b/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/third/HealthSchema.java
@@ -24,4 +24,4 @@ import org.springframework.web.bind.annotation.RequestMapping;
public interface HealthSchema {
@GetMapping(value = "/heartbeat")
void heartbeat();
-}
\ No newline at end of file
+}
diff --git a/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/third/NormalConsumer.java b/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/third/NormalConsumer.java
index 72ce2eca9..b9bd2daa7 100644
--- a/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/third/NormalConsumer.java
+++ b/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/third/NormalConsumer.java
@@ -53,4 +53,4 @@ public class NormalConsumer implements BootListener {
// 比ThirdServiceRegister晚
return 0;
}
-}
\ No newline at end of file
+}
diff --git a/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/third/Register.java b/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/third/Register.java
index 16cb416d7..687ade9e3 100644
--- a/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/third/Register.java
+++ b/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/third/Register.java
@@ -32,4 +32,4 @@ public class Register extends ThirdServiceWithInvokerRegister {
addSchema("heartbeat", HealthSchema.class);
setUrls("", Arrays.asList("rest://localhost:8080?sslEnabled=false"));
}
-}
\ No newline at end of file
+}
diff --git a/demo/demo-zeroconfig-schemadiscovery-registry/demo-zeroconfig-schemadiscovery-registry-client/src/main/java/org/apache/servicecomb/demo/zeroconfig/client/ClientServerEndpoint.java b/demo/demo-zeroconfig-schemadiscovery-registry/demo-zeroconfig-schemadiscovery-registry-client/src/main/java/org/apache/servicecomb/demo/zeroconfig/client/ClientServerEndpoint.java
index f2fb73285..33d0e22ba 100644
--- a/demo/demo-zeroconfig-schemadiscovery-registry/demo-zeroconfig-schemadiscovery-registry-client/src/main/java/org/apache/servicecomb/demo/zeroconfig/client/ClientServerEndpoint.java
+++ b/demo/demo-zeroconfig-schemadiscovery-registry/demo-zeroconfig-schemadiscovery-registry-client/src/main/java/org/apache/servicecomb/demo/zeroconfig/client/ClientServerEndpoint.java
@@ -83,4 +83,4 @@ public class ClientServerEndpoint {
public String getString(@RawJsonRequestBody String jsonString) {
return jsonString;
}
-}
\ No newline at end of file
+}
diff --git a/dynamic-config/config-cc/src/test/java/org/apache/servicecomb/config/ConfigCenterConfigurationSourceImplTest.java b/dynamic-config/config-cc/src/test/java/org/apache/servicecomb/config/ConfigCenterConfigurationSourceImplTest.java
index b40df787f..dc0dbb0e9 100644
--- a/dynamic-config/config-cc/src/test/java/org/apache/servicecomb/config/ConfigCenterConfigurationSourceImplTest.java
+++ b/dynamic-config/config-cc/src/test/java/org/apache/servicecomb/config/ConfigCenterConfigurationSourceImplTest.java
@@ -67,4 +67,4 @@ class ConfigCenterConfigurationSourceImplTest {
List<String> availableAZ = Deencapsulation.getField(addressManager, "availableZone");
Assertions.assertEquals("https://127.0.0.1:30100/v3/test", availableAZ.get(0));
}
-}
\ No newline at end of file
+}
diff --git a/dynamic-config/config-cc/src/test/java/org/apache/servicecomb/config/center/client/AddressManagerTest.java b/dynamic-config/config-cc/src/test/java/org/apache/servicecomb/config/center/client/AddressManagerTest.java
index 958a6a16b..fc8c0c95b 100644
--- a/dynamic-config/config-cc/src/test/java/org/apache/servicecomb/config/center/client/AddressManagerTest.java
+++ b/dynamic-config/config-cc/src/test/java/org/apache/servicecomb/config/center/client/AddressManagerTest.java
@@ -77,4 +77,4 @@ class AddressManagerTest {
Assertions.assertEquals("http://127.0.0.3:30100/v3/project", addressManager1.address());
}
-}
\ No newline at end of file
+}
diff --git a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/event/AlarmEvent.java b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/event/AlarmEvent.java
index 1f100c148..353976440 100644
--- a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/event/AlarmEvent.java
+++ b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/event/AlarmEvent.java
@@ -31,5 +31,5 @@ public class AlarmEvent {
public enum Type {
OPEN,
CLOSE
- };
+ }
}
diff --git a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/log/AbstractMarker.java b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/log/AbstractMarker.java
index d3a227557..15128c19b 100644
--- a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/log/AbstractMarker.java
+++ b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/log/AbstractMarker.java
@@ -65,4 +65,4 @@ public abstract class AbstractMarker implements Marker {
public String toString() {
return getName();
}
-}
\ No newline at end of file
+}
diff --git a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/JvmUtils.java b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/JvmUtils.java
index 04196d303..8e0507a6f 100644
--- a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/JvmUtils.java
+++ b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/JvmUtils.java
@@ -139,4 +139,4 @@ public final class JvmUtils {
public static ClassLoader findClassLoader() {
return correctClassLoader(null);
}
-}
\ No newline at end of file
+}
diff --git a/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/DynamicObjectTest.java b/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/DynamicObjectTest.java
index 25848c46e..686712454 100644
--- a/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/DynamicObjectTest.java
+++ b/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/DynamicObjectTest.java
@@ -39,4 +39,4 @@ class DynamicObjectTest {
assertThat(dynamicObject.getDynamic()).isEqualTo(map);
assertThat(Json.encode(dynamicObject)).isEqualTo("{\"k\":\"v\"}");
}
-}
\ No newline at end of file
+}
diff --git a/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/base/DynamicEnumTest.java b/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/base/DynamicEnumTest.java
index 665817287..836be5651 100644
--- a/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/base/DynamicEnumTest.java
+++ b/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/base/DynamicEnumTest.java
@@ -98,4 +98,4 @@ class DynamicEnumTest {
Color value2 = Json.decodeValue(UNKNOWN_COLOR, Color.class);
assertThat(value1).isNotSameAs(value2);
}
-}
\ No newline at end of file
+}
diff --git a/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/AsyncUtilsTest.java b/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/AsyncUtilsTest.java
index 8b38da0bc..7ec1a2150 100644
--- a/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/AsyncUtilsTest.java
+++ b/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/AsyncUtilsTest.java
@@ -41,4 +41,4 @@ class AsyncUtilsTest {
Throwable catchThrowable = catchThrowable(() -> AsyncUtils.toSync(future));
assertThat(catchThrowable).isSameAs(throwable);
}
-}
\ No newline at end of file
+}
diff --git a/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/DynamicWatchedConfigurationExt.java b/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/DynamicWatchedConfigurationExt.java
index 3ea8a0290..0aa3b0491 100644
--- a/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/DynamicWatchedConfigurationExt.java
+++ b/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/DynamicWatchedConfigurationExt.java
@@ -72,4 +72,4 @@ public class DynamicWatchedConfigurationExt extends ConcurrentMapConfiguration i
public void updateConfiguration(final WatchedUpdateResult result) {
updater.updateProperties(result, this, ignoreDeletesFromSource);
}
-}
\ No newline at end of file
+}
diff --git a/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/inject/PlaceholderResolver.java b/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/inject/PlaceholderResolver.java
index 08614178e..209356161 100644
--- a/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/inject/PlaceholderResolver.java
+++ b/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/inject/PlaceholderResolver.java
@@ -210,4 +210,4 @@ public class PlaceholderResolver {
}
return value;
}
-}
\ No newline at end of file
+}
diff --git a/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/priority/ConfigObjectFactory.java b/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/priority/ConfigObjectFactory.java
index 66fbf7917..695e3488a 100644
--- a/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/priority/ConfigObjectFactory.java
+++ b/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/priority/ConfigObjectFactory.java
@@ -225,4 +225,4 @@ public class ConfigObjectFactory {
return finalKeys.toArray(new String[0]);
}
-}
\ No newline at end of file
+}
diff --git a/foundations/foundation-config/src/test/java/org/apache/servicecomb/config/BootStrapPropertiesTest.java b/foundations/foundation-config/src/test/java/org/apache/servicecomb/config/BootStrapPropertiesTest.java
index 488546a04..7187bb8e3 100644
--- a/foundations/foundation-config/src/test/java/org/apache/servicecomb/config/BootStrapPropertiesTest.java
+++ b/foundations/foundation-config/src/test/java/org/apache/servicecomb/config/BootStrapPropertiesTest.java
@@ -145,4 +145,4 @@ class BootStrapPropertiesTest {
+ " \"k\" : \"new\"\n"
+ "}");
}
-}
\ No newline at end of file
+}
diff --git a/foundations/foundation-config/src/test/java/org/apache/servicecomb/config/priority/TestPriorityPropertyFactory.java b/foundations/foundation-config/src/test/java/org/apache/servicecomb/config/priority/TestPriorityPropertyFactory.java
index 9024d70ff..1e33e3af6 100644
--- a/foundations/foundation-config/src/test/java/org/apache/servicecomb/config/priority/TestPriorityPropertyFactory.java
+++ b/foundations/foundation-config/src/test/java/org/apache/servicecomb/config/priority/TestPriorityPropertyFactory.java
@@ -39,4 +39,4 @@ class TestPriorityPropertyFactory extends TestPriorityPropertyBase {
assertThat(p1).isNotSameAs(p2);
assertThat(propertyFactory.getProperties().count()).isEqualTo(2);
}
-}
\ No newline at end of file
+}
diff --git a/foundations/foundation-protobuf/src/main/java/io/protostuff/package-info.java b/foundations/foundation-protobuf/src/main/java/io/protostuff/package-info.java
index a518c0c53..fad90514b 100644
--- a/foundations/foundation-protobuf/src/main/java/io/protostuff/package-info.java
+++ b/foundations/foundation-protobuf/src/main/java/io/protostuff/package-info.java
@@ -33,4 +33,4 @@
* </pre>
*/
-package io.protostuff;
\ No newline at end of file
+package io.protostuff;
diff --git a/foundations/foundation-protobuf/src/main/java/org/apache/servicecomb/foundation/protobuf/internal/schema/serializer/repeated/AbstractWriters.java b/foundations/foundation-protobuf/src/main/java/org/apache/servicecomb/foundation/protobuf/internal/schema/serializer/repeated/AbstractWriters.java
index b448a5def..bb784ff76 100644
--- a/foundations/foundation-protobuf/src/main/java/org/apache/servicecomb/foundation/protobuf/internal/schema/serializer/repeated/AbstractWriters.java
+++ b/foundations/foundation-protobuf/src/main/java/org/apache/servicecomb/foundation/protobuf/internal/schema/serializer/repeated/AbstractWriters.java
@@ -84,4 +84,4 @@ public abstract class AbstractWriters<T> {
ProtoUtils.throwNotSupportWrite(protoField, value);
}
-}
\ No newline at end of file
+}
diff --git a/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/model/CustomGeneric.java b/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/model/CustomGeneric.java
index 5cbb1ef78..c57579ed1 100644
--- a/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/model/CustomGeneric.java
+++ b/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/model/CustomGeneric.java
@@ -18,4 +18,4 @@ package org.apache.servicecomb.foundation.protobuf.internal.model;
public class CustomGeneric<T> {
public T user;
-}
\ No newline at end of file
+}
diff --git a/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/model/ProtobufRoot.java b/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/model/ProtobufRoot.java
index 7fbb80f9c..11ac07631 100644
--- a/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/model/ProtobufRoot.java
+++ b/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/model/ProtobufRoot.java
@@ -7609,8 +7609,8 @@ org.apache.servicecomb.foundation.protobuf.internal.model.ProtobufRoot.User defa
}
private com.google.protobuf.MapField<java.lang.String, java.lang.String>
internalGetMutableSsMap() {
- onChanged();;
- if (ssMap_ == null) {
+ onChanged();
+ if (ssMap_ == null) {
ssMap_ = com.google.protobuf.MapField.newMapField(
SsMapDefaultEntryHolder.defaultEntry);
}
@@ -7740,8 +7740,8 @@ org.apache.servicecomb.foundation.protobuf.internal.model.ProtobufRoot.User defa
}
private com.google.protobuf.MapField<java.lang.String, java.lang.Integer>
internalGetMutableSint32Map() {
- onChanged();;
- if (sint32Map_ == null) {
+ onChanged();
+ if (sint32Map_ == null) {
sint32Map_ = com.google.protobuf.MapField.newMapField(
Sint32MapDefaultEntryHolder.defaultEntry);
}
@@ -7868,8 +7868,8 @@ org.apache.servicecomb.foundation.protobuf.internal.model.ProtobufRoot.User defa
}
private com.google.protobuf.MapField<java.lang.String, org.apache.servicecomb.foundation.protobuf.internal.model.ProtobufRoot.User>
internalGetMutableSpMap() {
- onChanged();;
- if (spMap_ == null) {
+ onChanged();
+ if (spMap_ == null) {
spMap_ = com.google.protobuf.MapField.newMapField(
SpMapDefaultEntryHolder.defaultEntry);
}
diff --git a/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/schema/scalar/TestFixed64Schema.java b/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/schema/scalar/TestFixed64Schema.java
index 95d103383..03ea489b2 100644
--- a/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/schema/scalar/TestFixed64Schema.java
+++ b/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/schema/scalar/TestFixed64Schema.java
@@ -22,4 +22,4 @@ public class TestFixed64Schema extends TestNumberBaseSchema {
maxValue = Long.MAX_VALUE;
initFields("fixed64", "objFixed64");
}
-}
\ No newline at end of file
+}
diff --git a/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/schema/scalar/TestUInt64Schema.java b/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/schema/scalar/TestUInt64Schema.java
index 6aef61edc..6235a4b3e 100644
--- a/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/schema/scalar/TestUInt64Schema.java
+++ b/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/schema/scalar/TestUInt64Schema.java
@@ -22,4 +22,4 @@ public class TestUInt64Schema extends TestNumberBaseSchema {
maxValue = Long.MAX_VALUE;
initFields("uint64", "objUint64");
}
-}
\ No newline at end of file
+}
diff --git a/foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/RegistrationManager.java b/foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/RegistrationManager.java
index 19687128c..2df6ab1df 100644
--- a/foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/RegistrationManager.java
+++ b/foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/RegistrationManager.java
@@ -357,4 +357,4 @@ public class RegistrationManager {
));
}
}
-}
\ No newline at end of file
+}
diff --git a/foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/consumer/AppManager.java b/foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/consumer/AppManager.java
index 82bea019b..f149516e9 100644
--- a/foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/consumer/AppManager.java
+++ b/foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/consumer/AppManager.java
@@ -98,4 +98,4 @@ public class AppManager {
.map(microserviceManager -> microserviceManager.getVersionsByName().get(microserviceName))
.ifPresent(MicroserviceVersions::markWaitingDelete);
}
-}
\ No newline at end of file
+}
diff --git a/foundations/foundation-ssl/src/main/java/org/apache/servicecomb/foundation/ssl/CertificateUtil.java b/foundations/foundation-ssl/src/main/java/org/apache/servicecomb/foundation/ssl/CertificateUtil.java
index 2091adba8..8fcf41af1 100644
--- a/foundations/foundation-ssl/src/main/java/org/apache/servicecomb/foundation/ssl/CertificateUtil.java
+++ b/foundations/foundation-ssl/src/main/java/org/apache/servicecomb/foundation/ssl/CertificateUtil.java
@@ -126,7 +126,7 @@ public final class CertificateUtil {
Object key = list.get(0);
Object value = list.get(1);
if (key instanceof Integer && value instanceof String) {
- int intKey = ((Integer) key).intValue();
+ int intKey = (Integer) key;
String strValue = (String) value;
if (intKey == SUBALTNAME_DNSNAME || intKey == SUBALTNAME_IPADDRESS) {
names.add(strValue);
diff --git a/foundations/foundation-ssl/src/main/java/org/apache/servicecomb/foundation/ssl/TrustManagerExt.java b/foundations/foundation-ssl/src/main/java/org/apache/servicecomb/foundation/ssl/TrustManagerExt.java
index b9c70e0bf..117708909 100644
--- a/foundations/foundation-ssl/src/main/java/org/apache/servicecomb/foundation/ssl/TrustManagerExt.java
+++ b/foundations/foundation-ssl/src/main/java/org/apache/servicecomb/foundation/ssl/TrustManagerExt.java
@@ -194,9 +194,9 @@ public class TrustManagerExt extends X509ExtendedTrustManager {
} else if (cnValid(cns, ipTmp)) {
return;
}
- LOG.error("CN does not match IP: e=" + cns.toString()
+ LOG.error("CN does not match IP: e=" + cns
+ ",t=" + ip);
- throw new CertificateException("CN does not match IP: e=" + cns.toString()
+ throw new CertificateException("CN does not match IP: e=" + cns
+ ",t=" + ip);
}
}
diff --git a/foundations/foundation-test-scaffolding/src/main/java/org/apache/servicecomb/foundation/test/scaffolding/AssertUtils.java b/foundations/foundation-test-scaffolding/src/main/java/org/apache/servicecomb/foundation/test/scaffolding/AssertUtils.java
index 84560543d..ef310a9da 100644
--- a/foundations/foundation-test-scaffolding/src/main/java/org/apache/servicecomb/foundation/test/scaffolding/AssertUtils.java
+++ b/foundations/foundation-test-scaffolding/src/main/java/org/apache/servicecomb/foundation/test/scaffolding/AssertUtils.java
@@ -30,4 +30,4 @@ public interface AssertUtils {
.replace(LineSeparator.WINDOWS.value(), LineSeparator.UNIX.value());
return assertThat(json);
}
-}
\ No newline at end of file
+}
diff --git a/foundations/foundation-test-scaffolding/src/main/resources/config/log4j.properties b/foundations/foundation-test-scaffolding/src/main/resources/config/log4j.properties
index a6911b4f6..b9da5260d 100644
--- a/foundations/foundation-test-scaffolding/src/main/resources/config/log4j.properties
+++ b/foundations/foundation-test-scaffolding/src/main/resources/config/log4j.properties
@@ -14,4 +14,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-paas.logs.dir=target/
\ No newline at end of file
+paas.logs.dir=target/
diff --git a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/server/TcpServer.java b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/server/TcpServer.java
index b378bf40b..49fbe0112 100644
--- a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/server/TcpServer.java
+++ b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/server/TcpServer.java
@@ -89,7 +89,7 @@ public class TcpServer {
}
// 监听失败
- String msg = String.format("listen failed, address=%s", socketAddress.toString());
+ String msg = String.format("listen failed, address=%s", socketAddress);
callback.fail(new Exception(msg, ar.cause()));
});
}
diff --git a/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/http/TestReadStreamPart.java b/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/http/TestReadStreamPart.java
index 47c66a533..ac55db2cc 100644
--- a/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/http/TestReadStreamPart.java
+++ b/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/http/TestReadStreamPart.java
@@ -175,7 +175,7 @@ public class TestReadStreamPart {
@Test
public void saveToFile() throws InterruptedException, ExecutionException, IOException {
- File dir = new File("target/notExist-" + UUID.randomUUID().toString());
+ File dir = new File("target/notExist-" + UUID.randomUUID());
File file = new File(dir, "a.txt");
Assertions.assertFalse(dir.exists());
@@ -190,7 +190,7 @@ public class TestReadStreamPart {
@Test
public void saveToFile_notExist_notCreate() throws InterruptedException, ExecutionException, IOException {
- File dir = new File("target/notExist-" + UUID.randomUUID().toString());
+ File dir = new File("target/notExist-" + UUID.randomUUID());
File file = new File(dir, "a.txt");
Assertions.assertFalse(dir.exists());
diff --git a/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/http/TestVertxServerResponseToHttpServletResponse.java b/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/http/TestVertxServerResponseToHttpServletResponse.java
index e98f65691..367eb60b8 100644
--- a/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/http/TestVertxServerResponseToHttpServletResponse.java
+++ b/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/http/TestVertxServerResponseToHttpServletResponse.java
@@ -397,7 +397,7 @@ public class TestVertxServerResponseToHttpServletResponse {
@Test
public void clearPartResource_deleteFile() throws IOException {
- File file = new File("target", UUID.randomUUID().toString() + ".txt");
+ File file = new File("target", UUID.randomUUID() + ".txt");
FileUtils.write(file, "content", StandardCharsets.UTF_8);
FilePart part = new FilePart(null, file).setDeleteAfterFinished(true);
@@ -408,7 +408,7 @@ public class TestVertxServerResponseToHttpServletResponse {
@Test
public void clearPartResource_notDeleteFile() throws IOException {
- File file = new File("target", UUID.randomUUID().toString() + ".txt");
+ File file = new File("target", UUID.randomUUID() + ".txt");
FileUtils.write(file, "content", StandardCharsets.UTF_8);
FilePart part = new FilePart(null, file);
diff --git a/governance/src/main/java/org/apache/servicecomb/governance/event/GovernanceConfigurationChangedEvent.java b/governance/src/main/java/org/apache/servicecomb/governance/event/GovernanceConfigurationChangedEvent.java
index 2d3e09c7e..bce4ec729 100644
--- a/governance/src/main/java/org/apache/servicecomb/governance/event/GovernanceConfigurationChangedEvent.java
+++ b/governance/src/main/java/org/apache/servicecomb/governance/event/GovernanceConfigurationChangedEvent.java
@@ -29,4 +29,4 @@ public class GovernanceConfigurationChangedEvent {
public Set<String> getChangedConfigurations() {
return changedConfigurations;
}
-}
\ No newline at end of file
+}
diff --git a/governance/src/main/java/org/apache/servicecomb/governance/marker/operator/MatchOperator.java b/governance/src/main/java/org/apache/servicecomb/governance/marker/operator/MatchOperator.java
index c4f157c47..db9290745 100644
--- a/governance/src/main/java/org/apache/servicecomb/governance/marker/operator/MatchOperator.java
+++ b/governance/src/main/java/org/apache/servicecomb/governance/marker/operator/MatchOperator.java
@@ -19,4 +19,4 @@ package org.apache.servicecomb.governance.marker.operator;
public interface MatchOperator {
boolean match(String targetStr, String patternStr);
-}
\ No newline at end of file
+}
diff --git a/governance/src/test/java/org/apache/servicecomb/router/ExampleDistributor.java b/governance/src/test/java/org/apache/servicecomb/router/ExampleDistributor.java
index 38f09686f..7c6aa04f9 100644
--- a/governance/src/test/java/org/apache/servicecomb/router/ExampleDistributor.java
+++ b/governance/src/test/java/org/apache/servicecomb/router/ExampleDistributor.java
@@ -25,4 +25,4 @@ public class ExampleDistributor extends AbstractRouterDistributor<ServiceIns, Se
public ExampleDistributor() {
init(a -> a, ServiceIns::getVersion, ServiceIns::getServerName, ServiceIns::getTags);
}
-}
\ No newline at end of file
+}
diff --git a/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/filter/IsolationDiscoveryFilterTest.java b/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/filter/IsolationDiscoveryFilterTest.java
index da282c975..fe9e50f5a 100644
--- a/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/filter/IsolationDiscoveryFilterTest.java
+++ b/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/filter/IsolationDiscoveryFilterTest.java
@@ -247,4 +247,4 @@ public class IsolationDiscoveryFilterTest {
Assertions.assertEquals(data.get("i2"), childNodeData.get("i2"));
Assertions.assertFalse(ServiceCombLoadBalancerStats.INSTANCE.getServiceCombServerStats(server0).isIsolated());
}
-}
\ No newline at end of file
+}
diff --git a/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/filter/PriorityInstancePropertyDiscoveryFilterTest.java b/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/filter/PriorityInstancePropertyDiscoveryFilterTest.java
index 2c29456bd..0ba2584b3 100644
--- a/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/filter/PriorityInstancePropertyDiscoveryFilterTest.java
+++ b/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/filter/PriorityInstancePropertyDiscoveryFilterTest.java
@@ -134,4 +134,4 @@ public class PriorityInstancePropertyDiscoveryFilterTest {
Map<String, MicroserviceInstance> filterInstance = node.data();
assertThat(filterInstance.keySet()).containsAnyElementsOf(expectedMatchedKeys);
}
-}
\ No newline at end of file
+}
diff --git a/integration-tests/dynamic-config-tests/src/test/java/org/apache/dynamicconfig/test/SimApolloServer.java b/integration-tests/dynamic-config-tests/src/test/java/org/apache/dynamicconfig/test/SimApolloServer.java
index fac81834a..be80ac289 100644
--- a/integration-tests/dynamic-config-tests/src/test/java/org/apache/dynamicconfig/test/SimApolloServer.java
+++ b/integration-tests/dynamic-config-tests/src/test/java/org/apache/dynamicconfig/test/SimApolloServer.java
@@ -42,4 +42,4 @@ public class SimApolloServer extends AbstractVerticle {
.end(response);
}).listen(23334);
}
-}
\ No newline at end of file
+}
diff --git a/integration-tests/it-common/src/main/java/org/apache/servicecomb/it/schema/objectparams/Color.java b/integration-tests/it-common/src/main/java/org/apache/servicecomb/it/schema/objectparams/Color.java
index 23ea5149e..e43c5c4d8 100644
--- a/integration-tests/it-common/src/main/java/org/apache/servicecomb/it/schema/objectparams/Color.java
+++ b/integration-tests/it-common/src/main/java/org/apache/servicecomb/it/schema/objectparams/Color.java
@@ -18,5 +18,5 @@
package org.apache.servicecomb.it.schema.objectparams;
public enum Color {
- RED,BLUE,GREEN;
+ RED,BLUE,GREEN
}
diff --git a/integration-tests/it-common/src/main/java/org/apache/servicecomb/it/schema/objectparams/FlattenObjectRequest.java b/integration-tests/it-common/src/main/java/org/apache/servicecomb/it/schema/objectparams/FlattenObjectRequest.java
index b0b134f33..71ff6b3de 100644
--- a/integration-tests/it-common/src/main/java/org/apache/servicecomb/it/schema/objectparams/FlattenObjectRequest.java
+++ b/integration-tests/it-common/src/main/java/org/apache/servicecomb/it/schema/objectparams/FlattenObjectRequest.java
@@ -284,4 +284,4 @@ public class FlattenObjectRequest {
request.setColor(Color.BLUE);
return request;
}
-}
\ No newline at end of file
+}
diff --git a/integration-tests/it-common/src/main/java/org/apache/servicecomb/it/schema/objectparams/FluentSetterFlattenObjectRequest.java b/integration-tests/it-common/src/main/java/org/apache/servicecomb/it/schema/objectparams/FluentSetterFlattenObjectRequest.java
index 90f0efd05..425080be9 100644
--- a/integration-tests/it-common/src/main/java/org/apache/servicecomb/it/schema/objectparams/FluentSetterFlattenObjectRequest.java
+++ b/integration-tests/it-common/src/main/java/org/apache/servicecomb/it/schema/objectparams/FluentSetterFlattenObjectRequest.java
@@ -301,4 +301,4 @@ public class FluentSetterFlattenObjectRequest {
.setString("abc")
.setColor(Color.BLUE);
}
-}
\ No newline at end of file
+}
diff --git a/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/Consumers.java b/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/Consumers.java
index 8a5698097..1ed20e743 100644
--- a/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/Consumers.java
+++ b/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/Consumers.java
@@ -85,4 +85,4 @@ public class Consumers<INTF> {
public CseAsyncRestTemplate getCseAsyncRestTemplate() {
return cseAsyncRestTemplate;
}
-}
\ No newline at end of file
+}
diff --git a/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/ResultPrinter.java b/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/ResultPrinter.java
index 2a35762bc..50854117d 100644
--- a/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/ResultPrinter.java
+++ b/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/ResultPrinter.java
@@ -60,6 +60,6 @@ public class ResultPrinter {
ITJUnitUtils.getRunCount(),
ITJUnitUtils.getFailures().size(),
totalTime));
- System.out.println(sb.toString());
+ System.out.println(sb);
}
}
diff --git a/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/testcase/TestDownload.java b/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/testcase/TestDownload.java
index 8a75f9ba0..31136077b 100644
--- a/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/testcase/TestDownload.java
+++ b/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/testcase/TestDownload.java
@@ -65,7 +65,7 @@ public class TestDownload {
private CompletableFuture<File> checkFile(ReadStreamPart part) {
CompletableFuture<File> future = part.saveToFile("target/download/"
- + UUID.randomUUID().toString()
+ + UUID.randomUUID()
+ "-"
+ part.getSubmittedFileName());
return checkFuture(future);
diff --git a/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/testcase/objectparams/TestSpringMVCObjectParamType.java b/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/testcase/objectparams/TestSpringMVCObjectParamType.java
index d2e327ab2..63ab0abd6 100644
--- a/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/testcase/objectparams/TestSpringMVCObjectParamType.java
+++ b/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/testcase/objectparams/TestSpringMVCObjectParamType.java
@@ -467,13 +467,13 @@ public class TestSpringMVCObjectParamType {
public void testQueryObjectWithHeader_rt() {
HttpHeaders headers = new HttpHeaders();
headers.add("prefix", prefix);
- Assertions.assertEquals(prefix + queryModel.toString(),
+ Assertions.assertEquals(prefix + queryModel,
queryObjectHeader(consumers, headers, "/testQueryObjectWithHeader?" + queryParam));
}
@Test
public void testQueryObjectWithHeader_pojo() {
- Assertions.assertEquals(prefix + queryModel.toString(),
+ Assertions.assertEquals(prefix + queryModel,
consumers.getIntf().testQueryObjectWithHeader(prefix, 23, "demo"));
}
@@ -481,13 +481,13 @@ public class TestSpringMVCObjectParamType {
public void testQueryObjectWithHeaderName_rt() {
HttpHeaders headers = new HttpHeaders();
headers.add("prefix", prefix);
- Assertions.assertEquals(prefix + queryModel.toString(),
+ Assertions.assertEquals(prefix + queryModel,
queryObjectHeader(consumers, headers, "/testQueryObjectWithHeaderName?" + queryParam));
}
@Test
public void testQueryObjectWithHeaderName_pojo() {
- Assertions.assertEquals(prefix + queryModel.toString(),
+ Assertions.assertEquals(prefix + queryModel,
consumers.getIntf().testQueryObjectWithHeaderName(prefix, 23, "demo"));
}
@@ -495,13 +495,13 @@ public class TestSpringMVCObjectParamType {
public void testQueryObjectWithHeaderValue_rt() {
HttpHeaders headers = new HttpHeaders();
headers.add("prefix", prefix);
- Assertions.assertEquals(prefix + queryModel.toString(),
+ Assertions.assertEquals(prefix + queryModel,
queryObjectHeader(consumers, headers, "/testQueryObjectWithHeaderValue?" + queryParam));
}
@Test
public void testQueryObjectWithHeaderValue_pojo() {
- Assertions.assertEquals(prefix + queryModel.toString(),
+ Assertions.assertEquals(prefix + queryModel,
consumers.getIntf().testQueryObjectWithHeaderValue(prefix, 23, "demo"));
}
@@ -510,49 +510,49 @@ public class TestSpringMVCObjectParamType {
HttpHeaders headers = new HttpHeaders();
headers.add("prefix", prefix);
headers.add("suffix", suffix);
- Assertions.assertEquals(prefix + queryModel.toString() + suffix,
+ Assertions.assertEquals(prefix + queryModel + suffix,
queryObjectHeader(consumers, headers, "/testQueryObjectWithHeaderValueAndName?" + queryParam));
}
@Test
public void testQueryObjectWithHeaderValueAndName_pojo() {
- Assertions.assertEquals(prefix + queryModel.toString() + suffix,
+ Assertions.assertEquals(prefix + queryModel + suffix,
consumers.getIntf().testQueryObjectWithHeaderValueAndName(prefix, suffix, 23, "demo"));
}
@Test
public void testQueryObjectWithParam_rt() {
- Assertions.assertEquals(prefix + queryModel.toString(), consumers.getSCBRestTemplate()
+ Assertions.assertEquals(prefix + queryModel, consumers.getSCBRestTemplate()
.getForObject("/testQueryObjectWithParam?prefix=" + prefix + "&" + queryParam, String.class));
}
@Test
public void testQueryObjectWithParam_pojo() {
- Assertions.assertEquals(prefix + queryModel.toString(),
+ Assertions.assertEquals(prefix + queryModel,
consumers.getIntf().testQueryObjectWithParam(prefix, 23, "demo"));
}
@Test
public void testQueryObjectWithParamName_rt() {
- Assertions.assertEquals(prefix + queryModel.toString(), consumers.getSCBRestTemplate()
+ Assertions.assertEquals(prefix + queryModel, consumers.getSCBRestTemplate()
.getForObject("/testQueryObjectWithParamName?prefix=" + prefix + "&" + queryParam, String.class));
}
@Test
public void testQueryObjectWithParamName_pojo() {
- Assertions.assertEquals(prefix + queryModel.toString(),
+ Assertions.assertEquals(prefix + queryModel,
consumers.getIntf().testQueryObjectWithParamName(prefix, 23, "demo"));
}
@Test
public void testQueryObjectWithParamValue_rt() {
- Assertions.assertEquals(prefix + queryModel.toString(), consumers.getSCBRestTemplate()
+ Assertions.assertEquals(prefix + queryModel, consumers.getSCBRestTemplate()
.getForObject("/testQueryObjectWithParamValue?prefix=" + prefix + "&" + queryParam, String.class));
}
@Test
public void testQueryObjectWithParamValue_pojo() {
- Assertions.assertEquals(prefix + queryModel.toString(),
+ Assertions.assertEquals(prefix + queryModel,
consumers.getIntf().testQueryObjectWithParamValue(prefix, 23, "demo"));
}
diff --git a/integration-tests/it-edge/src/main/java/org/apache/servicecomb/it/edge/PreLoadBootListener.java b/integration-tests/it-edge/src/main/java/org/apache/servicecomb/it/edge/PreLoadBootListener.java
index 45d4d8cf0..72ad93169 100644
--- a/integration-tests/it-edge/src/main/java/org/apache/servicecomb/it/edge/PreLoadBootListener.java
+++ b/integration-tests/it-edge/src/main/java/org/apache/servicecomb/it/edge/PreLoadBootListener.java
@@ -45,4 +45,4 @@ public class PreLoadBootListener implements BootListener {
}
}
}
-}
\ No newline at end of file
+}
diff --git a/integration-tests/it-edge/src/main/java/org/apache/servicecomb/it/edge/encrypt/filter/EdgeSignatureRequestFilter.java b/integration-tests/it-edge/src/main/java/org/apache/servicecomb/it/edge/encrypt/filter/EdgeSignatureRequestFilter.java
index 3eb60906e..6e00773d9 100644
--- a/integration-tests/it-edge/src/main/java/org/apache/servicecomb/it/edge/encrypt/filter/EdgeSignatureRequestFilter.java
+++ b/integration-tests/it-edge/src/main/java/org/apache/servicecomb/it/edge/encrypt/filter/EdgeSignatureRequestFilter.java
@@ -60,7 +60,7 @@ public class EdgeSignatureRequestFilter implements HttpServerFilter {
hasher.putString(name, StandardCharsets.UTF_8);
hasher.putString(requestEx.getParameter(name), StandardCharsets.UTF_8);
}
- LOGGER.info("afterReceiveRequest signature: {}", hasher.hash().toString());
+ LOGGER.info("afterReceiveRequest signature: {}", hasher.hash());
return null;
}
diff --git a/integration-tests/it-producer/src/main/java/org/apache/servicecomb/it/schema/DefaultJsonValueJaxrsSchema.java b/integration-tests/it-producer/src/main/java/org/apache/servicecomb/it/schema/DefaultJsonValueJaxrsSchema.java
index 65308533d..d8992f76e 100644
--- a/integration-tests/it-producer/src/main/java/org/apache/servicecomb/it/schema/DefaultJsonValueJaxrsSchema.java
+++ b/integration-tests/it-producer/src/main/java/org/apache/servicecomb/it/schema/DefaultJsonValueJaxrsSchema.java
@@ -34,7 +34,7 @@ public class DefaultJsonValueJaxrsSchema {
response.setType(request.getType());
StringBuilder sb = new StringBuilder();
sb.append(request.getDefaultValue());
- response.setMessage("expected:" + sb.toString() + ":" + (request.getItems() == null ? null
+ response.setMessage("expected:" + sb + ":" + (request.getItems() == null ? null
: request.getItems().size()));
return response;
}
diff --git a/integration-tests/it-producer/src/main/java/org/apache/servicecomb/it/schema/DownloadSchema.java b/integration-tests/it-producer/src/main/java/org/apache/servicecomb/it/schema/DownloadSchema.java
index 16dbd588f..ad274bbc8 100644
--- a/integration-tests/it-producer/src/main/java/org/apache/servicecomb/it/schema/DownloadSchema.java
+++ b/integration-tests/it-producer/src/main/java/org/apache/servicecomb/it/schema/DownloadSchema.java
@@ -92,7 +92,7 @@ public class DownloadSchema implements BootListener {
protected File createTempFile(String name, String content) throws IOException {
if (name == null) {
- name = "download-" + UUID.randomUUID().toString() + ".txt";
+ name = "download-" + UUID.randomUUID() + ".txt";
}
File file = new File(tempDir, name);
FileUtils.write(file, content, StandardCharsets.UTF_8, false);
diff --git a/integration-tests/pojo-test/src/test/java/org/apache/servicecomb/demo/pojo/test/endpoints/TestImpl.java b/integration-tests/pojo-test/src/test/java/org/apache/servicecomb/demo/pojo/test/endpoints/TestImpl.java
index 46d1bf704..2b0d7e6e5 100644
--- a/integration-tests/pojo-test/src/test/java/org/apache/servicecomb/demo/pojo/test/endpoints/TestImpl.java
+++ b/integration-tests/pojo-test/src/test/java/org/apache/servicecomb/demo/pojo/test/endpoints/TestImpl.java
@@ -38,7 +38,7 @@ public class TestImpl implements Test {
@Override
public String getTestString(String code) {
- return String.format("code is '%s'", String.valueOf(code));
+ return String.format("code is '%s'", code);
}
@Override
diff --git a/integration-tests/spring-pojo-connection-limit-test/src/test/java/org/apache/servicecomb/demo/pojo/test/PojoSpringConnectionLimitIntegrationTest.java b/integration-tests/spring-pojo-connection-limit-test/src/test/java/org/apache/servicecomb/demo/pojo/test/PojoSpringConnectionLimitIntegrationTest.java
index f254d436f..001ec7f6c 100644
--- a/integration-tests/spring-pojo-connection-limit-test/src/test/java/org/apache/servicecomb/demo/pojo/test/PojoSpringConnectionLimitIntegrationTest.java
+++ b/integration-tests/spring-pojo-connection-limit-test/src/test/java/org/apache/servicecomb/demo/pojo/test/PojoSpringConnectionLimitIntegrationTest.java
@@ -39,4 +39,4 @@ public class PojoSpringConnectionLimitIntegrationTest {
Assertions.assertEquals("io.vertx.core.http.HttpClosedException: Connection was closed", e.getCause().toString());
}
}
-}
\ No newline at end of file
+}
diff --git a/integration-tests/spring-pojo-connection-limit-test/src/test/resources/log4j.properties b/integration-tests/spring-pojo-connection-limit-test/src/test/resources/log4j.properties
index 8cc015c91..705b2f7c5 100644
--- a/integration-tests/spring-pojo-connection-limit-test/src/test/resources/log4j.properties
+++ b/integration-tests/spring-pojo-connection-limit-test/src/test/resources/log4j.properties
@@ -17,4 +17,4 @@
log4j.rootLogger=WARN, stdout
log4j.appender.stdout=org.apache.log4j.ConsoleAppender
log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
-log4j.appender.stdout.layout.ConversionPattern=%d [%-15.15t] %-5p %-30.30c{1} - %m%n
\ No newline at end of file
+log4j.appender.stdout.layout.ConversionPattern=%d [%-15.15t] %-5p %-30.30c{1} - %m%n
diff --git a/integration-tests/spring-pojo-connection-limit-test/src/test/resources/microservice.yaml b/integration-tests/spring-pojo-connection-limit-test/src/test/resources/microservice.yaml
index 62bdc4ac8..ecb1b3d82 100644
--- a/integration-tests/spring-pojo-connection-limit-test/src/test/resources/microservice.yaml
+++ b/integration-tests/spring-pojo-connection-limit-test/src/test/resources/microservice.yaml
@@ -26,4 +26,4 @@ servicecomb:
rest:
address: 0.0.0.0:7070
server:
- connection-limit: 0
\ No newline at end of file
+ connection-limit: 0
diff --git a/integration-tests/spring-pojo-tests/src/test/java/org/apache/servicecomb/demo/pojo/test/PojoSpringIntegrationTest.java b/integration-tests/spring-pojo-tests/src/test/java/org/apache/servicecomb/demo/pojo/test/PojoSpringIntegrationTest.java
index cfbe610ee..ab413d269 100644
--- a/integration-tests/spring-pojo-tests/src/test/java/org/apache/servicecomb/demo/pojo/test/PojoSpringIntegrationTest.java
+++ b/integration-tests/spring-pojo-tests/src/test/java/org/apache/servicecomb/demo/pojo/test/PojoSpringIntegrationTest.java
@@ -35,4 +35,4 @@ public class PojoSpringIntegrationTest extends PojoIntegrationTestBase {
public static void teardownClass() {
SCBEngine.getInstance().destroy();
}
-}
\ No newline at end of file
+}
diff --git a/integration-tests/spring-pojo-tests/src/test/resources/microservice.yaml b/integration-tests/spring-pojo-tests/src/test/resources/microservice.yaml
index 322f22ba9..fbfebd4b2 100644
--- a/integration-tests/spring-pojo-tests/src/test/resources/microservice.yaml
+++ b/integration-tests/spring-pojo-tests/src/test/resources/microservice.yaml
@@ -18,4 +18,4 @@
servicecomb:
service:
registry:
- enabled: false
\ No newline at end of file
+ enabled: false
diff --git a/integration-tests/test-common/src/test/java/org/apache/servicecomb/tests/tracing/TracingTestBase.java b/integration-tests/test-common/src/test/java/org/apache/servicecomb/tests/tracing/TracingTestBase.java
index 7f4c712bb..9f1a1de80 100644
--- a/integration-tests/test-common/src/test/java/org/apache/servicecomb/tests/tracing/TracingTestBase.java
+++ b/integration-tests/test-common/src/test/java/org/apache/servicecomb/tests/tracing/TracingTestBase.java
@@ -72,7 +72,7 @@ public class TracingTestBase {
spans = zipkin.getTrace(traceId(loggedIds));
tracedValues = tracedValues(spans);
} catch (InterruptedException e) {
- log.error("Thread interrupted, ", e.getMessage());
+ log.error("Thread interrupted, {}", e.getMessage());
Thread.currentThread().interrupt();
}
}
diff --git a/metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/meter/os/net/InterfaceUsage.java b/metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/meter/os/net/InterfaceUsage.java
index 4bc4f1d0e..c29d9598f 100644
--- a/metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/meter/os/net/InterfaceUsage.java
+++ b/metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/meter/os/net/InterfaceUsage.java
@@ -67,4 +67,4 @@ public class InterfaceUsage {
public List<NetStat> getNetStats() {
return netStats;
}
-}
\ No newline at end of file
+}
diff --git a/metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/meter/os/net/NetStat.java b/metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/meter/os/net/NetStat.java
index 876c8c99d..3d3f08b70 100644
--- a/metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/meter/os/net/NetStat.java
+++ b/metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/meter/os/net/NetStat.java
@@ -59,4 +59,4 @@ public class NetStat {
public Id getId() {
return id;
}
-}
\ No newline at end of file
+}
diff --git a/metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/publish/DefaultLogPublisher.java b/metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/publish/DefaultLogPublisher.java
index 5b8af2986..ac2b7a63c 100644
--- a/metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/publish/DefaultLogPublisher.java
+++ b/metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/publish/DefaultLogPublisher.java
@@ -197,7 +197,7 @@ public class DefaultLogPublisher implements MetricsInitializer {
interfaceNode.getName());
}
if (tmpSb.length() != 0) {
- sb.append(tmpSb.toString());
+ sb.append(tmpSb);
}
}
diff --git a/metrics/metrics-core/src/test/java/org/apache/servicecomb/metrics/core/TestHealthBootListener.java b/metrics/metrics-core/src/test/java/org/apache/servicecomb/metrics/core/TestHealthBootListener.java
index c14704103..1c8624fc0 100644
--- a/metrics/metrics-core/src/test/java/org/apache/servicecomb/metrics/core/TestHealthBootListener.java
+++ b/metrics/metrics-core/src/test/java/org/apache/servicecomb/metrics/core/TestHealthBootListener.java
@@ -101,4 +101,4 @@ public class TestHealthBootListener {
MatcherAssert.assertThat(producerMetas, Matchers.empty());
}
-}
\ No newline at end of file
+}
diff --git a/providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncRestTemplate.java b/providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncRestTemplate.java
index 683c1b4f5..c30985420 100644
--- a/providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncRestTemplate.java
+++ b/providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncRestTemplate.java
@@ -59,4 +59,4 @@ public class CseAsyncRestTemplate extends org.springframework.web.client.AsyncRe
Type responseType) {
return new CseAsyncRequestCallback<T>(requestBody);
}
-}
\ No newline at end of file
+}
diff --git a/providers/provider-springmvc/src/test/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequestFactoryTest.java b/providers/provider-springmvc/src/test/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequestFactoryTest.java
index 7475fff10..5c81868e8 100644
--- a/providers/provider-springmvc/src/test/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequestFactoryTest.java
+++ b/providers/provider-springmvc/src/test/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequestFactoryTest.java
@@ -30,4 +30,4 @@ public class CseAsyncClientHttpRequestFactoryTest {
Assertions.assertEquals(HttpMethod.GET,
cseAsyncClientHttpRequestFactory.createAsyncRequest(URI.create("/test"), HttpMethod.GET).getMethod());
}
-}
\ No newline at end of file
+}
diff --git a/providers/provider-springmvc/src/test/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequestTest.java b/providers/provider-springmvc/src/test/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequestTest.java
index 60c8ac6ad..251cfbea4 100644
--- a/providers/provider-springmvc/src/test/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequestTest.java
+++ b/providers/provider-springmvc/src/test/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequestTest.java
@@ -122,4 +122,4 @@ public class CseAsyncClientHttpRequestTest {
}
);
}
-}
\ No newline at end of file
+}
diff --git a/service-registry/registry-lightweight/src/main/java/org/apache/servicecomb/registry/lightweight/AbstractLightweightDiscovery.java b/service-registry/registry-lightweight/src/main/java/org/apache/servicecomb/registry/lightweight/AbstractLightweightDiscovery.java
index 921ab08ff..11cf2c8da 100644
--- a/service-registry/registry-lightweight/src/main/java/org/apache/servicecomb/registry/lightweight/AbstractLightweightDiscovery.java
+++ b/service-registry/registry-lightweight/src/main/java/org/apache/servicecomb/registry/lightweight/AbstractLightweightDiscovery.java
@@ -124,4 +124,4 @@ public abstract class AbstractLightweightDiscovery implements Discovery, Initial
String revision) {
return store.findServiceInstances(appId, serviceName, revision);
}
-}
\ No newline at end of file
+}
diff --git a/service-registry/registry-lightweight/src/main/java/org/apache/servicecomb/registry/lightweight/AbstractLightweightRegistration.java b/service-registry/registry-lightweight/src/main/java/org/apache/servicecomb/registry/lightweight/AbstractLightweightRegistration.java
index 39ce59dff..ac2799cee 100644
--- a/service-registry/registry-lightweight/src/main/java/org/apache/servicecomb/registry/lightweight/AbstractLightweightRegistration.java
+++ b/service-registry/registry-lightweight/src/main/java/org/apache/servicecomb/registry/lightweight/AbstractLightweightRegistration.java
@@ -143,4 +143,4 @@ public abstract class AbstractLightweightRegistration implements Registration {
}
protected abstract void doSendUnregister() throws IOException;
-}
\ No newline at end of file
+}
diff --git a/service-registry/registry-lightweight/src/main/java/org/apache/servicecomb/registry/lightweight/store/Store.java b/service-registry/registry-lightweight/src/main/java/org/apache/servicecomb/registry/lightweight/store/Store.java
index cd9ca8c87..dedc35cf6 100644
--- a/service-registry/registry-lightweight/src/main/java/org/apache/servicecomb/registry/lightweight/store/Store.java
+++ b/service-registry/registry-lightweight/src/main/java/org/apache/servicecomb/registry/lightweight/store/Store.java
@@ -129,4 +129,4 @@ public class Store {
.filter(instanceStore -> instanceStore.isHeartBeatTimeout(nanoNow, nanoTimeout))
.map(InstanceStore::getInstance);
}
-}
\ No newline at end of file
+}
diff --git a/service-registry/registry-lightweight/src/test/java/org/apache/servicecomb/registry/lightweight/MessageTest.java b/service-registry/registry-lightweight/src/test/java/org/apache/servicecomb/registry/lightweight/MessageTest.java
index c91a14b86..66181ce87 100644
--- a/service-registry/registry-lightweight/src/test/java/org/apache/servicecomb/registry/lightweight/MessageTest.java
+++ b/service-registry/registry-lightweight/src/test/java/org/apache/servicecomb/registry/lightweight/MessageTest.java
@@ -77,4 +77,4 @@ class MessageTest {
assertThat(message.getBody()).isInstanceOf(UnregisterRequest.class);
}
-}
\ No newline at end of file
+}
diff --git a/service-registry/registry-lightweight/src/test/java/org/apache/servicecomb/registry/lightweight/StoreServiceTest.java b/service-registry/registry-lightweight/src/test/java/org/apache/servicecomb/registry/lightweight/StoreServiceTest.java
index f443ed5ea..1858c87f7 100644
--- a/service-registry/registry-lightweight/src/test/java/org/apache/servicecomb/registry/lightweight/StoreServiceTest.java
+++ b/service-registry/registry-lightweight/src/test/java/org/apache/servicecomb/registry/lightweight/StoreServiceTest.java
@@ -146,4 +146,4 @@ class StoreServiceTest extends TestBase {
should_register_microservice_and_instance_when_both_not_exist();
assertThat(instanceStore.getLastHeartBeat()).isEqualTo(1);
}
-}
\ No newline at end of file
+}
diff --git a/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/api/Type.java b/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/api/Type.java
index d198f9f17..da6202213 100644
--- a/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/api/Type.java
+++ b/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/api/Type.java
@@ -22,4 +22,4 @@ public enum Type {
KIE,
CseConfigCenter,
CseMonitoring
-}
\ No newline at end of file
+}
diff --git a/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/client/http/RestClientUtil.java b/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/client/http/RestClientUtil.java
index f7dd6e5bf..565fcd655 100644
--- a/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/client/http/RestClientUtil.java
+++ b/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/client/http/RestClientUtil.java
@@ -144,7 +144,7 @@ final class RestClientUtil {
}).onFailure(failure -> {
LOGGER.error("{} {} fail, endpoint is {}:{}, message: {}",
httpMethod,
- url.toString(),
+ url,
ipPort.getHostOrIp(),
ipPort.getPort(),
failure.getMessage());
@@ -176,7 +176,7 @@ final class RestClientUtil {
try {
signReq.setEndpoint(new URI(endpoint.toString()));
} catch (URISyntaxException e) {
- LOGGER.error("set uri failed, uri is {}, message: {}", endpoint.toString(), e.getMessage());
+ LOGGER.error("set uri failed, uri is {}, message: {}", endpoint, e.getMessage());
}
signReq.setContent((requestParam.getBody() != null && requestParam.getBody().length > 0)
? new ByteArrayInputStream(requestParam.getBody())
diff --git a/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java b/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
index 3e9918759..4657dc3ef 100644
--- a/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
+++ b/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
@@ -178,7 +178,7 @@ public final class ServiceRegistryClientImpl implements ServiceRegistryClient {
}
}
} catch (IOException e) {
- LOGGER.warn("read value failed from buffer {}", bodyBuffer.toString());
+ LOGGER.warn("read value failed from buffer {}", bodyBuffer);
}
}
@@ -287,7 +287,7 @@ public final class ServiceRegistryClientImpl implements ServiceRegistryClient {
mInstances.setMicroserviceNotExist(true);
mInstances.setNeedRefresh(false);
}
- LOGGER.warn("failed to findInstances: " + bodyBuffer.toString());
+ LOGGER.warn("failed to findInstances: " + bodyBuffer);
}
break;
default:
diff --git a/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/client/http/WebsocketClientUtil.java b/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/client/http/WebsocketClientUtil.java
index 12b81dff9..d73b1016c 100644
--- a/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/client/http/WebsocketClientUtil.java
+++ b/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/client/http/WebsocketClientUtil.java
@@ -118,7 +118,7 @@ public final class WebsocketClientUtil {
try {
signReq.setEndpoint(new URI(endpoint.toString()));
} catch (URISyntaxException e) {
- LOGGER.error("set uri failed, uri is {}, message: {}", endpoint.toString(), e.getMessage());
+ LOGGER.error("set uri failed, uri is {}, message: {}", endpoint, e.getMessage());
}
signReq.setContent((requestParam.getBody() != null && requestParam.getBody().length > 0)
? new ByteArrayInputStream(requestParam.getBody())
diff --git a/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/diagnosis/instance/InstanceCacheChecker.java b/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/diagnosis/instance/InstanceCacheChecker.java
index a2593d232..3ec0cea7c 100644
--- a/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/diagnosis/instance/InstanceCacheChecker.java
+++ b/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/diagnosis/instance/InstanceCacheChecker.java
@@ -121,7 +121,7 @@ public class InstanceCacheChecker {
+ "current cache: {}\n",
microserviceVersions.getAppId(),
microserviceVersions.getMicroserviceName(),
- remoteInstances.toString());
+ remoteInstances);
instanceCacheResult.setStatus(Status.NORMAL);
return instanceCacheResult;
}
@@ -132,7 +132,7 @@ public class InstanceCacheChecker {
microserviceVersions.getAppId(),
microserviceVersions.getMicroserviceName(),
microserviceVersions.getPulledInstances().toString(),
- remoteInstances.toString());
+ remoteInstances);
instanceCacheResult.setStatus(Status.ABNORMAL);
instanceCacheResult.setDetail("instance cache not match");
diff --git a/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceInstanceStatusSyncTask.java b/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceInstanceStatusSyncTask.java
index b4aa9f8d2..e932d638f 100644
--- a/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceInstanceStatusSyncTask.java
+++ b/service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceInstanceStatusSyncTask.java
@@ -87,4 +87,4 @@ public class MicroserviceInstanceStatusSyncTask extends AbstractTask {
}
return serviceInstance;
}
-}
\ No newline at end of file
+}
diff --git a/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/RegistryUtilsTest.java b/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/RegistryUtilsTest.java
index 4e6453c86..93e0395e9 100644
--- a/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/RegistryUtilsTest.java
+++ b/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/RegistryUtilsTest.java
@@ -74,4 +74,4 @@ public class RegistryUtilsTest {
Assertions.assertEquals("0166f3c18702617d5e55cf911e4e412cc8760dab", microserviceInstances.getRevision());
Assertions.assertNull(microserviceInstances.getInstancesResponse());
}
-}
\ No newline at end of file
+}
diff --git a/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/ServiceRegistryTest.java b/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/ServiceRegistryTest.java
index 987c90b65..41a285cc2 100644
--- a/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/ServiceRegistryTest.java
+++ b/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/ServiceRegistryTest.java
@@ -63,4 +63,4 @@ public class ServiceRegistryTest {
matcher = ServiceRegistry.REGISTRY_NAME_PATTERN.matcher("ab@c");
Assertions.assertFalse(matcher.matches());
}
-}
\ No newline at end of file
+}
diff --git a/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/auth/TestRBACBootStrapService.java b/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/auth/TestRBACBootStrapService.java
index 95b6e4c14..aa8ea632d 100644
--- a/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/auth/TestRBACBootStrapService.java
+++ b/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/auth/TestRBACBootStrapService.java
@@ -33,4 +33,4 @@ public class TestRBACBootStrapService {
String result = String.valueOf(cipher.decrypt(encrypted));
Assertions.assertEquals(result, "test");
}
-}
\ No newline at end of file
+}
diff --git a/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/auth/TokenCacheManagerTest.java b/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/auth/TokenCacheManagerTest.java
index 2f0b2f503..5be2c12a8 100644
--- a/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/auth/TokenCacheManagerTest.java
+++ b/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/auth/TokenCacheManagerTest.java
@@ -37,4 +37,4 @@ public class TokenCacheManagerTest {
request.setPassword(new String(cipher.decrypt("testtest".toCharArray())));
Assertions.assertEquals(request.getPassword(), "test");
}
-}
\ No newline at end of file
+}
diff --git a/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/refresh/AddressManagerTest.java b/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/refresh/AddressManagerTest.java
index 8a28f426d..de34af90d 100644
--- a/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/refresh/AddressManagerTest.java
+++ b/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/refresh/AddressManagerTest.java
@@ -99,4 +99,4 @@ class AddressManagerTest {
Assertions.assertEquals("[2008::7:957f:b2d6:1af4:a1f8]", ipPort.getHostOrIp());
Assertions.assertEquals(30100, ipPort.getPort());
}
-}
\ No newline at end of file
+}
diff --git a/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/registry/cache/AggregateServiceRegistryCacheTest.java b/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/registry/cache/AggregateServiceRegistryCacheTest.java
index 9cc76686a..1380881f8 100644
--- a/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/registry/cache/AggregateServiceRegistryCacheTest.java
+++ b/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/registry/cache/AggregateServiceRegistryCacheTest.java
@@ -205,4 +205,4 @@ public class AggregateServiceRegistryCacheTest {
Assertions.assertEquals(1, aggregateServiceRegistryCache.microserviceCache.size());
Assertions.assertSame(serviceCache2, aggregateServiceRegistryCache.microserviceCache.get(microserviceCacheKey2));
}
-}
\ No newline at end of file
+}
diff --git a/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/registry/cache/MicroserviceCacheKeyTest.java b/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/registry/cache/MicroserviceCacheKeyTest.java
index 1666bbb95..715bc5a57 100644
--- a/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/registry/cache/MicroserviceCacheKeyTest.java
+++ b/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/registry/cache/MicroserviceCacheKeyTest.java
@@ -83,4 +83,4 @@ public class MicroserviceCacheKeyTest {
MicroserviceCacheKey.builder().env("env").appId("app").serviceName("svc").build();
Assertions.assertEquals("svc@app@env@0.0.0.0+", microserviceCacheKey.plainKey());
}
-}
\ No newline at end of file
+}
diff --git a/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/registry/cache/RefreshableMicroserviceCacheTest.java b/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/registry/cache/RefreshableMicroserviceCacheTest.java
index 3de3c30ec..143128afa 100644
--- a/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/registry/cache/RefreshableMicroserviceCacheTest.java
+++ b/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/registry/cache/RefreshableMicroserviceCacheTest.java
@@ -315,4 +315,4 @@ public class RefreshableMicroserviceCacheTest {
microserviceCache.refresh();
Assertions.assertEquals(Integer.valueOf(2), assertCounter.value);
}
-}
\ No newline at end of file
+}
diff --git a/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/registry/cache/RefreshableServiceRegistryCacheTest.java b/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/registry/cache/RefreshableServiceRegistryCacheTest.java
index 0c49a0851..1af465116 100644
--- a/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/registry/cache/RefreshableServiceRegistryCacheTest.java
+++ b/service-registry/registry-service-center/src/test/java/org/apache/servicecomb/serviceregistry/registry/cache/RefreshableServiceRegistryCacheTest.java
@@ -179,4 +179,4 @@ public class RefreshableServiceRegistryCacheTest {
};
return statusHolder;
}
-}
\ No newline at end of file
+}
diff --git a/spring-boot/spring-boot-starters/java-chassis-spring-boot-starter-servlet/src/main/java/org/apache/servicecomb/springboot2/starter/servlet/RestServletInitializer.java b/spring-boot/spring-boot-starters/java-chassis-spring-boot-starter-servlet/src/main/java/org/apache/servicecomb/springboot2/starter/servlet/RestServletInitializer.java
index b5ffc4bd2..bba62e0ec 100644
--- a/spring-boot/spring-boot-starters/java-chassis-spring-boot-starter-servlet/src/main/java/org/apache/servicecomb/springboot2/starter/servlet/RestServletInitializer.java
+++ b/spring-boot/spring-boot-starters/java-chassis-spring-boot-starter-servlet/src/main/java/org/apache/servicecomb/springboot2/starter/servlet/RestServletInitializer.java
@@ -78,4 +78,4 @@ public class RestServletInitializer
throw new ServletException(e);
}
}
-}
\ No newline at end of file
+}
diff --git a/spring-boot/spring-boot-starters/java-chassis-spring-boot-starter-servlet/src/main/java/org/apache/servicecomb/springboot2/starter/servlet/package-info.java b/spring-boot/spring-boot-starters/java-chassis-spring-boot-starter-servlet/src/main/java/org/apache/servicecomb/springboot2/starter/servlet/package-info.java
index 041302864..e8ac3f10c 100644
--- a/spring-boot/spring-boot-starters/java-chassis-spring-boot-starter-servlet/src/main/java/org/apache/servicecomb/springboot2/starter/servlet/package-info.java
+++ b/spring-boot/spring-boot-starters/java-chassis-spring-boot-starter-servlet/src/main/java/org/apache/servicecomb/springboot2/starter/servlet/package-info.java
@@ -15,4 +15,4 @@
* limitations under the License.
*/
-package org.apache.servicecomb.springboot2.starter.servlet;
\ No newline at end of file
+package org.apache.servicecomb.springboot2.starter.servlet;
diff --git a/swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/processor/parameter/JsonViewProcessor.java b/swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/processor/parameter/JsonViewProcessor.java
index acbe566cd..e099a7158 100644
--- a/swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/processor/parameter/JsonViewProcessor.java
+++ b/swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/processor/parameter/JsonViewProcessor.java
@@ -61,4 +61,4 @@ public class JsonViewProcessor implements ParameterProcessor<Parameter, Annotati
}
parameter.getVendorExtensions().put(SwaggerConst.EXT_JSON_VIEW, jvValue[0].getName());
}
-}
\ No newline at end of file
+}
diff --git a/swagger/swagger-generator/generator-core/src/test/java/org/apache/servicecomb/swagger/converter/ConverterMgrTest.java b/swagger/swagger-generator/generator-core/src/test/java/org/apache/servicecomb/swagger/converter/ConverterMgrTest.java
index 51c15e7d7..889b20417 100644
--- a/swagger/swagger-generator/generator-core/src/test/java/org/apache/servicecomb/swagger/converter/ConverterMgrTest.java
+++ b/swagger/swagger-generator/generator-core/src/test/java/org/apache/servicecomb/swagger/converter/ConverterMgrTest.java
@@ -183,4 +183,4 @@ public class ConverterMgrTest {
assertThat(ConverterMgr.findJavaType(swagger, property).getRawClass())
.isEqualTo(Object.class);
}
-}
\ No newline at end of file
+}
diff --git a/swagger/swagger-generator/generator-springmvc/src/test/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/RequestPartAnnotationProcessorTest.java b/swagger/swagger-generator/generator-springmvc/src/test/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/RequestPartAnnotationProcessorTest.java
index 36cee10cb..7ad611b28 100644
--- a/swagger/swagger-generator/generator-springmvc/src/test/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/RequestPartAnnotationProcessorTest.java
+++ b/swagger/swagger-generator/generator-springmvc/src/test/java/org/apache/servicecomb/swagger/generator/springmvc/processor/annotation/RequestPartAnnotationProcessorTest.java
@@ -167,4 +167,4 @@ public class RequestPartAnnotationProcessorTest {
@RequestPart("fileCollection") List<MultipartFile> fileCollection) {
}
}
-}
\ No newline at end of file
+}
diff --git a/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/context/InvocationContextCompletableFuture.java b/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/context/InvocationContextCompletableFuture.java
index d780be784..363025afa 100644
--- a/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/context/InvocationContextCompletableFuture.java
+++ b/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/context/InvocationContextCompletableFuture.java
@@ -29,4 +29,4 @@ public class InvocationContextCompletableFuture<T> extends CompletableFuture<T>
public InvocationContext getContext() {
return context;
}
-}
\ No newline at end of file
+}
diff --git a/swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/converter/impl/part/PartListToPartArrayConverterTest.java b/swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/converter/impl/part/PartListToPartArrayConverterTest.java
index 6ea420501..d985f9681 100644
--- a/swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/converter/impl/part/PartListToPartArrayConverterTest.java
+++ b/swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/converter/impl/part/PartListToPartArrayConverterTest.java
@@ -49,4 +49,4 @@ public class PartListToPartArrayConverterTest {
public void should_got_null_when_convert_null() {
Assertions.assertNull(converter.convert(null));
}
-}
\ No newline at end of file
+}
diff --git a/swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/converter/impl/part/PartListToPartListConverterTest.java b/swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/converter/impl/part/PartListToPartListConverterTest.java
index 11dfb0990..9b5111ae2 100644
--- a/swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/converter/impl/part/PartListToPartListConverterTest.java
+++ b/swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/converter/impl/part/PartListToPartListConverterTest.java
@@ -43,4 +43,4 @@ public class PartListToPartListConverterTest {
List<Part> parts = Arrays.asList(new FilePart("name", "file"));
Assertions.assertSame(parts, converter.convert(parts));
}
-}
\ No newline at end of file
+}
diff --git a/swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/converter/impl/part/PartToPartConverterTest.java b/swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/converter/impl/part/PartToPartConverterTest.java
index d6fc0639c..13125dbb9 100644
--- a/swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/converter/impl/part/PartToPartConverterTest.java
+++ b/swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/converter/impl/part/PartToPartConverterTest.java
@@ -40,4 +40,4 @@ public class PartToPartConverterTest {
Part part = new FilePart("name", "file");
Assertions.assertSame(part, converter.convert(part));
}
-}
\ No newline at end of file
+}
diff --git a/swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/exception/CommonExceptionDataTest.java b/swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/exception/CommonExceptionDataTest.java
index d30bb05fa..39a071f1f 100644
--- a/swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/exception/CommonExceptionDataTest.java
+++ b/swagger/swagger-invocation/invocation-core/src/test/java/org/apache/servicecomb/swagger/invocation/exception/CommonExceptionDataTest.java
@@ -56,4 +56,4 @@ class CommonExceptionDataTest {
assertThat(data.getDynamic()).isEqualTo(of("k", "v"));
assertThat(Json.encode(data)).isEqualTo(json);
}
-}
\ No newline at end of file
+}
diff --git a/swagger/swagger-invocation/invocation-validator/src/main/java/org/apache/servicecomb/swagger/invocation/validator/ParameterValidator.java b/swagger/swagger-invocation/invocation-validator/src/main/java/org/apache/servicecomb/swagger/invocation/validator/ParameterValidator.java
index 4209475bf..9fc573e45 100644
--- a/swagger/swagger-invocation/invocation-validator/src/main/java/org/apache/servicecomb/swagger/invocation/validator/ParameterValidator.java
+++ b/swagger/swagger-invocation/invocation-validator/src/main/java/org/apache/servicecomb/swagger/invocation/validator/ParameterValidator.java
@@ -77,7 +77,7 @@ public class ParameterValidator implements ProducerInvokeExtension {
args,
Default.class);
if (violations.size() > 0) {
- LOGGER.warn("Parameter validation failed : " + violations.toString());
+ LOGGER.warn("Parameter validation failed : " + violations);
throw new ConstraintViolationException(violations);
}
}
diff --git a/transports/transport-highway/src/test/java/org/apache/servicecomb/transport/highway/HighwayServerCodecFilterTest.java b/transports/transport-highway/src/test/java/org/apache/servicecomb/transport/highway/HighwayServerCodecFilterTest.java
index a331a2ddc..7539e1386 100644
--- a/transports/transport-highway/src/test/java/org/apache/servicecomb/transport/highway/HighwayServerCodecFilterTest.java
+++ b/transports/transport-highway/src/test/java/org/apache/servicecomb/transport/highway/HighwayServerCodecFilterTest.java
@@ -172,4 +172,4 @@ public class HighwayServerCodecFilterTest {
}
};
}
-}
\ No newline at end of file
+}
diff --git a/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/BoundaryFactory.java b/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/BoundaryFactory.java
index a5bb2e8f5..d50193b4a 100644
--- a/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/BoundaryFactory.java
+++ b/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/BoundaryFactory.java
@@ -20,7 +20,7 @@ import java.util.UUID;
import java.util.concurrent.atomic.AtomicLong;
public interface BoundaryFactory {
- String BOUNDARY_PREFIX = "boundary-" + UUID.randomUUID().toString() + "-";
+ String BOUNDARY_PREFIX = "boundary-" + UUID.randomUUID() + "-";
AtomicLong BOUNDARY_INDEX = new AtomicLong();
diff --git a/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/HttpClientRequestFactory.java b/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/HttpClientRequestFactory.java
index cf01542a0..fe36469be 100644
--- a/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/HttpClientRequestFactory.java
+++ b/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/HttpClientRequestFactory.java
@@ -46,4 +46,5 @@ public interface HttpClientRequestFactory {
Future<HttpClientRequest> create(Invocation invocation, HttpClient httpClient, RequestOptions options)
throws Throwable;
-}
\ No newline at end of file
+}
+
diff --git a/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/RestClientCodecFilterTest.java b/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/RestClientCodecFilterTest.java
index 625c7111c..893c2a80a 100644
--- a/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/RestClientCodecFilterTest.java
+++ b/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/RestClientCodecFilterTest.java
@@ -60,4 +60,4 @@ class RestClientCodecFilterTest extends RestClientTestBase {
// assertThat(invocation.getInvocationStageTrace().getStartClientFiltersRequest()).isNotEqualTo(0);
// assertThat(invocation.getInvocationStageTrace().getFinishClientFiltersResponse()).isNotEqualTo(0);
// }
-}
\ No newline at end of file
+}
diff --git a/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/RestClientDecoderTest.java b/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/RestClientDecoderTest.java
index 84c6adbc2..f4b35dacb 100644
--- a/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/RestClientDecoderTest.java
+++ b/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/RestClientDecoderTest.java
@@ -97,4 +97,4 @@ class RestClientDecoderTest extends RestClientTestBase {
// assertThat(throwable.toString()).isEqualTo(
// "InvocationException: code=400;msg=CommonExceptionData{code='scb_rest_client.40000003', message='failed to decode fail response body.', dynamic={}}");
// }
-}
\ No newline at end of file
+}
diff --git a/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/RestClientEncoderTest.java b/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/RestClientEncoderTest.java
index b133d7537..3d0ea1ba8 100644
--- a/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/RestClientEncoderTest.java
+++ b/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/RestClientEncoderTest.java
@@ -167,4 +167,4 @@ class RestClientEncoderTest extends RestClientTestBase {
// assertThat(((FilePart) parts.get(0)).getAbsolutePath()).endsWith("f1");
// assertThat(((FilePart) parts.get(1)).getAbsolutePath()).endsWith("f2");
// }
-}
\ No newline at end of file
+}
diff --git a/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/RestClientTransportContextFactoryTest.java b/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/RestClientTransportContextFactoryTest.java
index c89163681..a5a299ac6 100644
--- a/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/RestClientTransportContextFactoryTest.java
+++ b/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/RestClientTransportContextFactoryTest.java
@@ -104,4 +104,4 @@ class RestClientTransportContextFactoryTest extends RestClientTestBase {
//
// factory.setHttpClientRequestFactory(HttpClientRequestFactory.DEFAULT);
// }
-}
\ No newline at end of file
+}