You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/09/21 18:26:54 UTC
[GitHub] [helix] alirezazamani opened a new pull request #1385: Drop currentState if requestedState is equal to DROPPED
alirezazamani opened a new pull request #1385:
URL: https://github.com/apache/helix/pull/1385
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
Fixes #1384
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
This PR makes sure that paMap will not be overwritten by something else other than DROPPED in AbstractTaskDispatcher and currentState will be DROPPED. Without this PR, the outcome of the scheduling decision in non-deterministic and is based on the order that instances being processed for scheduling. With this PR, we make sure that that there will not be any scheduling decision unless the requested state of DROPPED in being respected.
### Tests
- [x] The following tests are written for this issue:
TestDropCurrentStateRunningTask
- [x] The following is the result of the "mvn test" command on the appropriate module:
```
[INFO] Tests run: 1200, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4,280.547 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1200, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:11 h
[INFO] Finished at: 2020-09-21T11:20:25-07:00
[INFO] ------------------------------------------------------------------------
```
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani commented on pull request #1385: Drop currentState if requestedState is equal to DROPPED
Posted by GitBox <gi...@apache.org>.
alirezazamani commented on pull request #1385:
URL: https://github.com/apache/helix/pull/1385#issuecomment-698498452
This PR is ready to be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani merged pull request #1385: Drop currentState if REQUESTED_STATE is equal to DROPPED
Posted by GitBox <gi...@apache.org>.
alirezazamani merged pull request #1385:
URL: https://github.com/apache/helix/pull/1385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani merged pull request #1385: Drop currentState if REQUESTED_STATE is equal to DROPPED
Posted by GitBox <gi...@apache.org>.
alirezazamani merged pull request #1385:
URL: https://github.com/apache/helix/pull/1385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani commented on pull request #1385: Drop currentState if requestedState is equal to DROPPED
Posted by GitBox <gi...@apache.org>.
alirezazamani commented on pull request #1385:
URL: https://github.com/apache/helix/pull/1385#issuecomment-698498452
This PR is ready to be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org