[GitHub] [spark] wankunde commented on pull request #37594: [SPARK-40159][SQL] Aggregate should be group only after collapse project to aggregate

[GitBox <gi...@apache.org>]

wankunde commented on PR #37594:
URL: https://github.com/apache/spark/pull/37594#issuecomment-1225429044

   Bad case : 
   ```
   explain cost select cast(id as smallint) from ( select distinct id from range(10)) t;
   +----------------------------------------------------+
   |                        plan                        |
   +----------------------------------------------------+
   | == Optimized Logical Plan ==
   Aggregate [id#760L], [cast(id#760L as smallint) AS id#761], Statistics(sizeInBytes=50.0 B)
   +- Range (0, 10, step=1, splits=None), Statistics(sizeInBytes=80.0 B)
   
   == Physical Plan ==
   AdaptiveSparkPlan isFinalPlan=false
   +- HashAggregate(keys=[id#760L], functions=[], output=[id#761]), OptimizeTags: [created by RemoveRedundantPartialAggregates]
      +- Range (0, 10, step=1, splits=300)
   ```
   Close this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org