[GitHub] [hbase] Apache9 commented on a change in pull request #3845: HBASE-26454 CreateTableProcedure still relies on temp dir and renames…

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #3845:
URL: https://github.com/apache/hbase/pull/3845#discussion_r748671886



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java
##########
@@ -336,41 +335,21 @@ private void postCreate(final MasterProcedureEnv env)
       final TableDescriptor tableDescriptor, List<RegionInfo> newRegions,
       final CreateHdfsRegions hdfsRegionHandler) throws IOException {
     final MasterFileSystem mfs = env.getMasterServices().getMasterFileSystem();
-    final Path tempdir = mfs.getTempDir();
 
     // 1. Create Table Descriptor
     // using a copy of descriptor, table will be created enabling first
-    final Path tempTableDir = CommonFSUtils.getTableDir(tempdir, tableDescriptor.getTableName());
+    final Path tableDir = CommonFSUtils.getTableDir(mfs.getRootDir(), tableDescriptor.getTableName());

Review comment:
       We do not need to delete or clean the old tableDir if exists first?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org