You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vaibhav Gumashta <vg...@hortonworks.com> on 2014/03/26 01:40:34 UTC

Review Request 19659: Hive printing debug information in stdout after the end of CLI session

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19659/
-----------------------------------------------------------

Review request for hive, Ashutosh Chauhan and Navis Ryu.


Bugs: HIVE-6750
    https://issues.apache.org/jira/browse/HIVE-6750


Repository: hive-git


Description
-------

Test jira: https://issues.apache.org/jira/browse/HIVE-6750


Diffs
-----

  common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 7d3980f 

Diff: https://reviews.apache.org/r/19659/diff/


Testing
-------

Using CLI


Thanks,

Vaibhav Gumashta


Re: Review Request 19659: Hive printing debug information in stdout after the end of CLI session

Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19659/
-----------------------------------------------------------

(Updated March 26, 2014, 1:57 a.m.)


Review request for hive, Ashutosh Chauhan and Navis Ryu.


Changes
-------

Addressed the review comment.


Bugs: HIVE-6750
    https://issues.apache.org/jira/browse/HIVE-6750


Repository: hive-git


Description
-------

Test jira: https://issues.apache.org/jira/browse/HIVE-6750


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 7d3980f 

Diff: https://reviews.apache.org/r/19659/diff/


Testing
-------

Using CLI


Thanks,

Vaibhav Gumashta


Re: Review Request 19659: Hive printing debug information in stdout after the end of CLI session

Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19659/#review38571
-----------------------------------------------------------


Minor comment. Looks good otherwise.


common/src/java/org/apache/hadoop/hive/common/JavaUtils.java
<https://reviews.apache.org/r/19659/#comment70844>

    You can do LOG.debug() thats sufficient.


- Ashutosh Chauhan


On March 26, 2014, 12:40 a.m., Vaibhav Gumashta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19659/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 12:40 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Navis Ryu.
> 
> 
> Bugs: HIVE-6750
>     https://issues.apache.org/jira/browse/HIVE-6750
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Test jira: https://issues.apache.org/jira/browse/HIVE-6750
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 7d3980f 
> 
> Diff: https://reviews.apache.org/r/19659/diff/
> 
> 
> Testing
> -------
> 
> Using CLI
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>