You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2023/01/05 17:04:13 UTC
[GitHub] [camel] Croway opened a new pull request, #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Croway opened a new pull request, #9001:
URL: https://github.com/apache/camel/pull/9001
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
This PR update the test-infra-artemis module and the following components:
* camel-jms
* camel-sjms
* camel-amqp
camel-sjms2 will be updated later on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9001:
URL: https://github.com/apache/camel/pull/9001#issuecomment-1372485237
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #9001:
URL: https://github.com/apache/camel/pull/9001#issuecomment-1375721417
Ah yeah its how the output is printed, so / 1 failed is accumulative so it was the same eg in core as you noticed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a diff in pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
orpiske commented on code in PR #9001:
URL: https://github.com/apache/camel/pull/9001#discussion_r1062711834
##########
components/camel-sjms/src/test/java/org/apache/camel/component/sjms/producer/QueueProducerQoSTest.java:
##########
@@ -106,8 +99,9 @@ public void testInOutQueueProducerTTL() throws Exception {
MockEndpoint.assertIsSatisfied(context);
- DestinationViewMBean queue = service.getQueueMBean(TEST_INOUT_DESTINATION_NAME);
- assertEquals(0, queue.getQueueSize(),
+ //TODO - I've exposed service.getMBeanServer(), do you think it can be used here?
Review Comment:
Maybe a leftover here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Croway commented on a diff in pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
Croway commented on code in PR #9001:
URL: https://github.com/apache/camel/pull/9001#discussion_r1063774146
##########
components/camel-sjms/src/test/java/org/apache/camel/component/sjms/producer/QueueProducerQoSTest.java:
##########
@@ -106,8 +99,9 @@ public void testInOutQueueProducerTTL() throws Exception {
MockEndpoint.assertIsSatisfied(context);
- DestinationViewMBean queue = service.getQueueMBean(TEST_INOUT_DESTINATION_NAME);
- assertEquals(0, queue.getQueueSize(),
+ //TODO - I've exposed service.getMBeanServer(), do you think it can be used here?
Review Comment:
Exactly, I tried to re-implement that test with JMX but Artemis expose a ManagementService that did the trick.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #9001:
URL: https://github.com/apache/camel/pull/9001#issuecomment-1375584194
> ### Components tested:
> Total Tested Failed ❌ Passed ✅
> 3 3 1 2
Failed due to a flaky on:
```
[ERROR] org.apache.camel.component.jms.ManagedJmsEndpointTopicTest.testJmsEndpoint
[ERROR] Run 1: ManagedJmsEndpointTopicTest.testJmsEndpoint:72 mock://result Received message count. Expected: <2> but was: <1>
[ERROR] Run 2: ManagedJmsEndpointTopicTest.testJmsEndpoint:72 mock://result Received message count. Expected: <2> but was: <1>
[ERROR] Run 3: ManagedJmsEndpointTopicTest.testJmsEndpoint:72 mock://result Received message count. Expected: <2> but was: <1>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #9001:
URL: https://github.com/apache/camel/pull/9001#issuecomment-1375403685
> ↩️ There are either **too many** changes to be tested in this PR or the code **needs be rebased**: (42 components likely to be affected)
@Croway please, can you rebase and push again, so that we have a clean test with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Croway commented on pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
Croway commented on PR #9001:
URL: https://github.com/apache/camel/pull/9001#issuecomment-1375434715
> > leftwards_arrow_with_hook There are either **too many** changes to be tested in this PR or the code **needs be rebased**: (42 components likely to be affected)
>
> @Croway please, can you rebase and push again, so that we have a clean test with this?
Sure, rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Croway commented on pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
Croway commented on PR #9001:
URL: https://github.com/apache/camel/pull/9001#issuecomment-1375714692
> I wonder if there is a flaky in sjms
>
> components/camel-sjms test completed successfully: 3 verified / 1 failed
this is strange, from test-logs I see that camel-sjms is successful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9001:
URL: https://github.com/apache/camel/pull/9001#issuecomment-1375527054
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 3 | 3 | 1 | 2 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
davsclaus merged PR #9001:
URL: https://github.com/apache/camel/pull/9001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a diff in pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
orpiske commented on code in PR #9001:
URL: https://github.com/apache/camel/pull/9001#discussion_r1062708532
##########
components/camel-jms/src/test/java/org/apache/camel/component/jms/ActiveMQOriginalDestinationTest.java:
##########
@@ -55,10 +56,11 @@ public void testActiveMQOriginalDestination() throws Exception {
JmsMessage msg = out.getIn(JmsMessage.class);
Message jms = msg.getJmsMessage();
ActiveMQMessage amq = assertIsInstanceOf(ActiveMQMessage.class, jms);
- ActiveMQDestination original = amq.getOriginalDestination();
+ ActiveMQDestination original = (ActiveMQDestination) amq.getJMSDestination();
assertNotNull(original);
- assertEquals("ActiveMQOriginalDestinationTest", original.getPhysicalName());
- assertEquals("Queue", original.getDestinationTypeAsString());
+ assertEquals("ActiveMQOriginalDestinationTest.dest", original.getName());
+ // assertEquals("Queue", original.getDestinationTypeAsString());
Review Comment:
Maybe remove this commented code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Croway commented on pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
Croway commented on PR #9001:
URL: https://github.com/apache/camel/pull/9001#issuecomment-1375712264
`org.apache.camel.processor.PooledExchangeTest.testSameExchange` in camel-core failed on the ci, I've executed it locally and it works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #9001:
URL: https://github.com/apache/camel/pull/9001#issuecomment-1375587615
yeah since the counters are in mbeans then it can be "off". You can use awailability in the test instead of hardcoded timeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9001:
URL: https://github.com/apache/camel/pull/9001#issuecomment-1372557323
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 3 | 3 | 1 | 2 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9001:
URL: https://github.com/apache/camel/pull/9001#issuecomment-1375706786
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 3 | 3 | 1 | 3 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #9001:
URL: https://github.com/apache/camel/pull/9001#issuecomment-1375721794
This looks good lets get this merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9001:
URL: https://github.com/apache/camel/pull/9001#issuecomment-1374164263
:leftwards_arrow_with_hook: There are either **too many** changes to be tested in this PR or the code **needs be rebased**: (42 components likely to be affected)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #9001:
URL: https://github.com/apache/camel/pull/9001#issuecomment-1375711139
I wonder if there is a flaky in sjms
components/camel-sjms test completed successfully: 3 verified / 1 failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Croway commented on pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
Croway commented on PR #9001:
URL: https://github.com/apache/camel/pull/9001#issuecomment-1375585431
> > ### Components tested:
> > Total Tested Failed x Passed white_check_mark
> > 3 3 1 2
>
> Failed due to a flaky on:
>
> ```
> [ERROR] org.apache.camel.component.jms.ManagedJmsEndpointTopicTest.testJmsEndpoint
> [ERROR] Run 1: ManagedJmsEndpointTopicTest.testJmsEndpoint:72 mock://result Received message count. Expected: <2> but was: <1>
> [ERROR] Run 2: ManagedJmsEndpointTopicTest.testJmsEndpoint:72 mock://result Received message count. Expected: <2> but was: <1>
> [ERROR] Run 3: ManagedJmsEndpointTopicTest.testJmsEndpoint:72 mock://result Received message count. Expected: <2> but was: <1>
> ```
Exactly, I noticed that a 100 ms timeout fix this flakiness, should I add the timeout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #9001:
URL: https://github.com/apache/camel/pull/9001#issuecomment-1373389476
> ### Components tested:
> Total Tested Failed ❌ Passed ✅
> 7 7 1 6
I haven't had these failures locally when I tried. I suspect they may be flaky on GH only. I am attaching the JMS log (the only component that had failures).
In this case, I think it may be OK to disable them using the following:
```
@DisabledIfSystemProperty(named = "ci.env.name", matches = "github.com", disabledReason = "Flaky on Github CI")
```
[components-camel-jms.log](https://github.com/apache/camel/files/10359024/components-camel-jms.log)
[camel-jms-test.log](https://github.com/apache/camel/files/10359021/camel-jms-test.log)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9001: CAMEL-18779: Replace ActiveMQ with Artemis
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9001:
URL: https://github.com/apache/camel/pull/9001#issuecomment-1372592662
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 7 | 7 | 1 | 6 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org