You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/11/09 01:22:17 UTC
[GitHub] [netbeans] lkishalmi opened a new pull request, #4943: Prevent CCE NbGradleProjectImpl to DataObject
lkishalmi opened a new pull request, #4943:
URL: https://github.com/apache/netbeans/pull/4943
Playing with Ernies composite build in #4865 I've encountered the following exception
```
java.lang.ClassCastException: class org.netbeans.modules.gradle.NbGradleProjectImpl cannot be cast to class org.openide.loaders.DataObject (org.netbeans.modules.gradle.NbGradleProjectImpl is in unnamed module of loader org.netbeans.StandardModule$OneModuleClassLoader @512bad4a; org.openide.loaders.DataObject is in unnamed module of loader org.netbeans.StandardModule$OneModuleClassLoader @657680c2)
at org.netbeans.modules.editor.hints.HintsControllerImpl.setErrors(HintsControllerImpl.java:68)
at org.netbeans.spi.editor.hints.HintsController$1.run(HintsController.java:59)
at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418)
at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
```
It seems some other NetBeans parts expecting a `DataObject` in a Document `Document.StreamDescriptionProperty` as Stream descriptor. I used that property ages ago probably seen that on some other editor. This PR just change the property name used for the code completion provider.
It seems if this exception does not happen, then the registration of the JDPA listener would g through, fixing #4865 entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4943: Prevent CCE NbGradleProjectImpl to DataObject
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4943:
URL: https://github.com/apache/netbeans/pull/4943#issuecomment-1308450424
Great, thanks @lkishalmi . I've seen that exception a couple of times recently testing 16, but could never reproduce what triggered it. Should have opened an issue with it though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #4943: Prevent CCE NbGradleProjectImpl to DataObject
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #4943:
URL: https://github.com/apache/netbeans/pull/4943#issuecomment-1308235288
>
> It seems some other NetBeans parts expecting a `DataObject` in a Document `Document.StreamDescriptionProperty` as Stream descriptor. I used that property ages ago probably seen that on some other editor. This PR just change the property
Yes,there's even an editor API for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a diff in pull request #4943: Prevent CCE NbGradleProjectImpl to DataObject
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on code in PR #4943:
URL: https://github.com/apache/netbeans/pull/4943#discussion_r1017455429
##########
extide/gradle/src/org/netbeans/modules/gradle/api/execute/GradleCommandLine.java:
##########
@@ -60,6 +60,7 @@
*/
public final class GradleCommandLine implements Serializable {
+ private static final String GRADLE_PROJECT_PROPERTY = "gradle-project"; //NOI18N
Review Comment:
Kind of. Did not want to change the API so late in NB16 cycle, so marked that private and made the two now public non apu one with a comment. Will pick that up for NB17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #4943: Prevent CCE NbGradleProjectImpl to DataObject
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #4943:
URL: https://github.com/apache/netbeans/pull/4943#issuecomment-1308167798
> gh might be having issues since I can't label this PR (or other PRs). Unfortunately this means the Gradle tests won't run.
>
> nevermind. was a temporary issue. Restarted the build.
Oh, I knew I forgot something! I'm sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #4943: Prevent CCE NbGradleProjectImpl to DataObject
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged PR #4943:
URL: https://github.com/apache/netbeans/pull/4943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a diff in pull request #4943: Prevent CCE NbGradleProjectImpl to DataObject
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on code in PR #4943:
URL: https://github.com/apache/netbeans/pull/4943#discussion_r1017455429
##########
extide/gradle/src/org/netbeans/modules/gradle/api/execute/GradleCommandLine.java:
##########
@@ -60,6 +60,7 @@
*/
public final class GradleCommandLine implements Serializable {
+ private static final String GRADLE_PROJECT_PROPERTY = "gradle-project"; //NOI18N
Review Comment:
Kind of. Did not want to change the API so late in NB16 cycle, so marked that private and made the two now public non API one with a comment. Will pick that up for NB17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a diff in pull request #4943: Prevent CCE NbGradleProjectImpl to DataObject
Posted by GitBox <gi...@apache.org>.
sdedic commented on code in PR #4943:
URL: https://github.com/apache/netbeans/pull/4943#discussion_r1017448055
##########
extide/gradle/src/org/netbeans/modules/gradle/api/execute/GradleCommandLine.java:
##########
@@ -60,6 +60,7 @@
*/
public final class GradleCommandLine implements Serializable {
+ private static final String GRADLE_PROJECT_PROPERTY = "gradle-project"; //NOI18N
Review Comment:
Leftover ?
But maybe declare the property as `public` somewhere to have a shared constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4943: Prevent CCE NbGradleProjectImpl to DataObject
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4943:
URL: https://github.com/apache/netbeans/pull/4943#issuecomment-1308081862
gh might be having issues since I can't label this PR (or other PRs). Unfortunately this means the Gradle tests won't run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists