You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yongjun Zhang (Code Review)" <ge...@cloudera.org> on 2018/10/04 01:09:37 UTC
[Impala-ASF-CR] IMPALA-7166: ExecSummary should be a first class object.
Yongjun Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11555
Change subject: IMPALA-7166: ExecSummary should be a first class object.
......................................................................
IMPALA-7166: ExecSummary should be a first class object.
Impala RuntimeProfile currently contains "ExecSummary" as a string. We should make it a
first class thrift object, so that tools can extract these fields (Est rows etc..).
Testing:
Modified unit test.
Change-Id: I4791237a5579f16c9efda8e57876d48980739e13
---
M be/src/service/impala-server.cc
M be/src/util/runtime-profile-test.cc
M be/src/util/runtime-profile.cc
M be/src/util/runtime-profile.h
M common/thrift/RuntimeProfile.thrift
5 files changed, 47 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/11555/2
--
To view, visit http://gerrit.cloudera.org:8080/11555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4791237a5579f16c9efda8e57876d48980739e13
Gerrit-Change-Number: 11555
Gerrit-PatchSet: 2
Gerrit-Owner: Yongjun Zhang <yj...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Yongjun Zhang <yj...@apache.org>
[Impala-ASF-CR] IMPALA-7166: ExecSummary should be a first class object.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11555 )
Change subject: IMPALA-7166: ExecSummary should be a first class object.
......................................................................
IMPALA-7166: ExecSummary should be a first class object.
Impala RuntimeProfile currently contains "ExecSummary" as a string. We should make it a
first class thrift object, so that tools can extract these fields (Est rows etc..).
Testing:
Modified unit test.
Change-Id: I4791237a5579f16c9efda8e57876d48980739e13
Reviewed-on: http://gerrit.cloudera.org:8080/11555
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/service/impala-server.cc
M be/src/util/runtime-profile-test.cc
M be/src/util/runtime-profile.cc
M be/src/util/runtime-profile.h
M common/thrift/RuntimeProfile.thrift
5 files changed, 48 insertions(+), 3 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4791237a5579f16c9efda8e57876d48980739e13
Gerrit-Change-Number: 11555
Gerrit-PatchSet: 5
Gerrit-Owner: Yongjun Zhang <yj...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Yongjun Zhang <yj...@apache.org>
[Impala-ASF-CR] IMPALA-7166: ExecSummary should be a first class object.
Posted by "Yongjun Zhang (Code Review)" <ge...@cloudera.org>.
Yongjun Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11555 )
Change subject: IMPALA-7166: ExecSummary should be a first class object.
......................................................................
Patch Set 2:
> (1 comment)
>
> We're having some non-trivial discussions here so let's publish
> this code review so it's visible to everyone else.
> (1 comment)
>
> We're having some non-trivial discussions here so let's publish
> this code review so it's visible to everyone else.
Thanks Tim.
> (1 comment)
>
> We're having some non-trivial discussions here so let's publish
> this code review so it's visible to everyone else.
> (1 comment)
>
> We're having some non-trivial discussions here so let's publish
> this code review so it's visible to everyone else.
Thanks Tim, good info. I will work on IMPALA-6742.
--
To view, visit http://gerrit.cloudera.org:8080/11555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4791237a5579f16c9efda8e57876d48980739e13
Gerrit-Change-Number: 11555
Gerrit-PatchSet: 2
Gerrit-Owner: Yongjun Zhang <yj...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Yongjun Zhang <yj...@apache.org>
Gerrit-Comment-Date: Thu, 04 Oct 2018 01:11:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7166: ExecSummary should be a first class object.
Posted by "Yongjun Zhang (Code Review)" <ge...@cloudera.org>.
Yongjun Zhang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11555 )
Change subject: IMPALA-7166: ExecSummary should be a first class object.
......................................................................
IMPALA-7166: ExecSummary should be a first class object.
Impala RuntimeProfile currently contains "ExecSummary" as a string. We should make it a
first class thrift object, so that tools can extract these fields (Est rows etc..).
Testing:
Modified unit test.
Change-Id: I4791237a5579f16c9efda8e57876d48980739e13
---
M be/src/service/impala-server.cc
M be/src/util/runtime-profile-test.cc
M be/src/util/runtime-profile.cc
M be/src/util/runtime-profile.h
M common/thrift/RuntimeProfile.thrift
5 files changed, 48 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/11555/3
--
To view, visit http://gerrit.cloudera.org:8080/11555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4791237a5579f16c9efda8e57876d48980739e13
Gerrit-Change-Number: 11555
Gerrit-PatchSet: 3
Gerrit-Owner: Yongjun Zhang <yj...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Yongjun Zhang <yj...@apache.org>
[Impala-ASF-CR] IMPALA-7166: ExecSummary should be a first class object.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11555 )
Change subject: IMPALA-7166: ExecSummary should be a first class object.
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4791237a5579f16c9efda8e57876d48980739e13
Gerrit-Change-Number: 11555
Gerrit-PatchSet: 4
Gerrit-Owner: Yongjun Zhang <yj...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Yongjun Zhang <yj...@apache.org>
Gerrit-Comment-Date: Mon, 29 Oct 2018 21:06:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7166: ExecSummary should be a first class object.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11555 )
Change subject: IMPALA-7166: ExecSummary should be a first class object.
......................................................................
Patch Set 2:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/929/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/11555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4791237a5579f16c9efda8e57876d48980739e13
Gerrit-Change-Number: 11555
Gerrit-PatchSet: 2
Gerrit-Owner: Yongjun Zhang <yj...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Yongjun Zhang <yj...@apache.org>
Gerrit-Comment-Date: Thu, 04 Oct 2018 02:20:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7166: ExecSummary should be a first class object.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11555 )
Change subject: IMPALA-7166: ExecSummary should be a first class object.
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4791237a5579f16c9efda8e57876d48980739e13
Gerrit-Change-Number: 11555
Gerrit-PatchSet: 3
Gerrit-Owner: Yongjun Zhang <yj...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Yongjun Zhang <yj...@apache.org>
Gerrit-Comment-Date: Mon, 29 Oct 2018 21:06:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7166: ExecSummary should be a first class object.
Posted by "Yongjun Zhang (Code Review)" <ge...@cloudera.org>.
Yongjun Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11555 )
Change subject: IMPALA-7166: ExecSummary should be a first class object.
......................................................................
Patch Set 3:
Thanks for the review Tim. I uploaded new rev to address other comments for completeness here. But I think let me fix IMPALA-6742 first.
--
To view, visit http://gerrit.cloudera.org:8080/11555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4791237a5579f16c9efda8e57876d48980739e13
Gerrit-Change-Number: 11555
Gerrit-PatchSet: 3
Gerrit-Owner: Yongjun Zhang <yj...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Yongjun Zhang <yj...@apache.org>
Gerrit-Comment-Date: Thu, 04 Oct 2018 23:19:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7166: ExecSummary should be a first class object.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11555 )
Change subject: IMPALA-7166: ExecSummary should be a first class object.
......................................................................
Patch Set 3:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/951/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/11555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4791237a5579f16c9efda8e57876d48980739e13
Gerrit-Change-Number: 11555
Gerrit-PatchSet: 3
Gerrit-Owner: Yongjun Zhang <yj...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Yongjun Zhang <yj...@apache.org>
Gerrit-Comment-Date: Thu, 04 Oct 2018 23:56:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7166: ExecSummary should be a first class object.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11555 )
Change subject: IMPALA-7166: ExecSummary should be a first class object.
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4791237a5579f16c9efda8e57876d48980739e13
Gerrit-Change-Number: 11555
Gerrit-PatchSet: 4
Gerrit-Owner: Yongjun Zhang <yj...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Yongjun Zhang <yj...@apache.org>
Gerrit-Comment-Date: Tue, 30 Oct 2018 01:11:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7166: ExecSummary should be a first class object.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11555 )
Change subject: IMPALA-7166: ExecSummary should be a first class object.
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3375/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4791237a5579f16c9efda8e57876d48980739e13
Gerrit-Change-Number: 11555
Gerrit-PatchSet: 4
Gerrit-Owner: Yongjun Zhang <yj...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Yongjun Zhang <yj...@apache.org>
Gerrit-Comment-Date: Mon, 29 Oct 2018 21:06:30 +0000
Gerrit-HasComments: No