[GitHub] [incubator-superset] ktmud commented on a change in pull request #11626: feat(sankey-viz): allow sort by metric and bump superset-ui packages

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #11626:
URL: https://github.com/apache/incubator-superset/pull/11626#discussion_r520950033



##########
File path: superset/viz.py
##########
@@ -1854,6 +1854,8 @@ def query_obj(self) -> QueryObjectDict:
                 _("Pick exactly 2 columns as [Source / Target]")
             )
         qry["metrics"] = [self.form_data["metric"]]
+        if self.form_data.get("sort_by_metric", False):

Review comment:
       I thought supplying a default helps indicating this parameter is a boolean.
   
   Since CI is green, I think I'll leave it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org