[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #12357: serialization RpcException bug pr rebase

["AlbumenJ (via GitHub)" <gi...@apache.org>]

AlbumenJ commented on code in PR #12357:
URL: https://github.com/apache/dubbo/pull/12357#discussion_r1213993023


##########
dubbo-remoting/dubbo-remoting-api/src/test/java/org/apache/dubbo/remoting/codec/DeprecatedExchangeCodec.java:
##########
@@ -282,7 +282,7 @@ protected void encodeResponse(Channel channel, OutputStream os, Response res) th
                     logger.warn(TRANSPORT_FAILED_RESPONSE, "", "", "Fail to encode response: " + res + ", send bad_response info instead, cause: " + t.getMessage(), t);
 
                     Response r = new Response(res.getId(), res.getVersion());
-                    r.setStatus(Response.BAD_RESPONSE);
+                    r.setStatus(Response.SERIALIZATION_ERROR);

Review Comment:
   Check if `t` is instance of `IOException`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org