You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "YI-HUNG JEN (JIRA)" <ji...@apache.org> on 2014/12/01 08:03:12 UTC

[jira] [Commented] (THRIFT-2858) Enable header field case insensitive match in THttpServer

    [ https://issues.apache.org/jira/browse/THRIFT-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229475#comment-14229475 ] 

YI-HUNG JEN commented on THRIFT-2858:
-------------------------------------

Terribly sorry for the late reply.  I thought it would send me an email.

Regarding the question, I haven't tested it yet.  I am hosting an RPC server calling C++ libraries, so I don't know how other Http parser in other languages would behave.  My guess is for other more "user friendly" frameworks this would not be an issue.

> Enable header field case insensitive match in THttpServer
> ---------------------------------------------------------
>
>                 Key: THRIFT-2858
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2858
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9.1, 0.9.2
>         Environment: ubuntu 14.04 LTS
> gcc 4.8
>            Reporter: YI-HUNG JEN
>              Labels: patch
>             Fix For: 0.9.3
>
>         Attachments: thrift-2858-enable-THttpServer_cpp-header-case-insensitive-match.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Communications between THttpServer in cpp lib and nodejs http client caused unexpected ECONNRESET.  This was caused by nodejs client setting "Content-length" instead of "Content-Length" in the header field, causing THttpServer to terminate the request prematurely.
> Per HTTP specification, header field name is case insensitive, therefore this patch used case insensitive match to identify "Content-Length" field.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)