You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2020/11/18 08:15:30 UTC

[GitHub] [avro] RyanSkraba commented on a change in pull request #981: AVRO-2961: Support .NET 5.0

RyanSkraba commented on a change in pull request #981:
URL: https://github.com/apache/avro/pull/981#discussion_r525889572



##########
File path: lang/csharp/common.props
##########
@@ -45,6 +45,7 @@
 
   <ItemGroup>
     <None Include="$(MSBuildThisFileDirectory)\LICENSE" Pack="true" Visible="false" PackagePath=""/>
+    <None Include="$(MSBuildThisFileDirectory)\..\..\doc\src\resources\images\avro-logo.png" Pack="true" PackagePath=""/>

Review comment:
       Thanks!  It looks like this change is necessary to build the 1.10.1 release artifacts -- but I managed to cherry-pick your commits into https://github.com/apache/avro/pull/1006, so it should be easy to rebase once they're merged!
   
   (At least, I think the cherry-pick origin info survives the merge-squash... I know your authorship does!)
   
   In any case, thanks for the help.  Especially thanks for the fine-grained and detailed commits :+1: 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org