You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/11 22:21:56 UTC

[GitHub] [airflow] eladkal commented on a change in pull request #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next…

eladkal commented on a change in pull request #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next…
URL: https://github.com/apache/airflow/pull/5565#discussion_r302763278
 
 

 ##########
 File path: airflow/contrib/hooks/bigquery_hook.py
 ##########
 @@ -1681,6 +1681,8 @@ def get_datasets_list(self, project_id=None):
         :param project_id: Google Cloud Project for which you
             try to get all datasets
         :type project_id: str
+        :param max_results: Max number of datasets excpected
 
 Review comment:
   Better to use the same definition of the API.
   max_results: The maximum number of results to return in a single response page. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services