You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2010/02/03 21:17:12 UTC
[Bug 6322] New: In DKIM ADSP eval test check_dkim_adsp() the '*' is
handled incorrectly
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6322
Summary: In DKIM ADSP eval test check_dkim_adsp() the '*' is
handled incorrectly
Product: Spamassassin
Version: 3.3.0
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P5
Component: Plugins
AssignedTo: dev@spamassassin.apache.org
ReportedBy: Mark.Martinec@ijs.si
A rule like:
header DKIM_ADSP_ALL_YG1 eval:check_dkim_adsp('*', gmail.com, yahoo.com)
should not have fired if a message contains at least one valid author domain
signature.
The problem is that a shorthand '*' is handled incorrectly, and fires
even when there are no ADSP policies (as it the case when AD signatures
are present)
A fix is fairly trivial, coming...
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6322] [review] In DKIM ADSP eval test check_dkim_adsp() the '*'
is handled incorrectly
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6322
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@pccc.com
--- Comment #2 from Kevin A. McGrail <km...@pccc.com> 2010-02-04 13:16:25 UTC ---
+1 Wow, that added a lot of tests!
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6322] [review] In DKIM ADSP eval test check_dkim_adsp() the '*'
is handled incorrectly
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6322
Justin Mason <jm...@jmason.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jm@jmason.org
--- Comment #4 from Justin Mason <jm...@jmason.org> 2010-02-12 17:32:11 UTC ---
+1
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6322] [review] In DKIM ADSP eval test check_dkim_adsp() the '*'
is handled incorrectly
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6322
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard| |1 more vote needed
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6322] [review] In DKIM ADSP eval test check_dkim_adsp() the '*'
is handled incorrectly
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6322
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #5 from Mark Martinec <Ma...@ijs.si> 2010-02-12 18:32:34 UTC ---
Thanks.
3.3:
Bug 6322: In DKIM ADSP eval test check_dkim_adsp() the '*' is handled
incorrectly
Sending lib/Mail/SpamAssassin/Plugin/DKIM.pm
Sending t/dkim2.t
Committed revision 909551.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6322] [review] In DKIM ADSP eval test check_dkim_adsp() the '*'
is handled incorrectly
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6322
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 |P2
Target Milestone|Undefined |3.3.1
Summary|In DKIM ADSP eval test |[review] In DKIM ADSP eval
|check_dkim_adsp() the '*' |test check_dkim_adsp() the
|is handled incorrectly |'*' is handled incorrectly
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6322] [review] In DKIM ADSP eval test check_dkim_adsp() the '*'
is handled incorrectly
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6322
Karsten Bräckelmann <gu...@rudersport.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|1 more vote needed |ready for commit
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6322] In DKIM ADSP eval test check_dkim_adsp() the '*' is
handled incorrectly
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6322
--- Comment #1 from Mark Martinec <Ma...@ijs.si> 2010-02-03 12:20:20 UTC ---
Bug 6322 - In DKIM ADSP eval test check_dkim_adsp() the '*' is handled
incorrectly
(updated also the test to detect such a bug)
Sending lib/Mail/SpamAssassin/Plugin/DKIM.pm
Sending t/dkim2.t
Committed revision 906219.
Please review/vote: svn diff -c906219
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6322] [review] In DKIM ADSP eval test check_dkim_adsp() the '*'
is handled incorrectly
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6322
--- Comment #3 from Mark Martinec <Ma...@ijs.si> 2010-02-04 13:19:28 UTC ---
(In reply to comment #2)
> +1 Wow, that added a lot of tests!
Well, yes, but they consume no additional time,
they just check the result against additional criteria.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.