You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@tsfile.apache.org by "jt2594838 (via GitHub)" <gi...@apache.org> on 2025/04/23 03:31:34 UTC
[PR] Optimizations regarding chunk metadata sort & timeseries medata serialization [tsfile]
jt2594838 opened a new pull request, #470:
URL: https://github.com/apache/tsfile/pull/470
When closing a TsFile:
1. The sort of chunk metadata is refactored to reduce redundant calculation;
2. Introduce no-sync streams to reduce synchronization cost during serializing TimeSeriesMetadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimizations regarding chunk metadata sort & timeseries metadata serialization [tsfile]
Posted by "shuwenwei (via GitHub)" <gi...@apache.org>.
shuwenwei commented on code in PR #470:
URL: https://github.com/apache/tsfile/pull/470#discussion_r2055314951
##########
java/tsfile/src/main/java/org/apache/tsfile/file/metadata/TimeseriesMetadata.java:
##########
@@ -394,4 +400,37 @@ public String toString() {
+ chunkMetadataList
+ '}';
}
+
+ public static void main(String[] args) throws IOException {
Review Comment:
Should this test be deleted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimizations regarding chunk metadata sort & timeseries metadata serialization [tsfile]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 commented on code in PR #470:
URL: https://github.com/apache/tsfile/pull/470#discussion_r2055325377
##########
java/tsfile/src/main/java/org/apache/tsfile/file/metadata/TimeseriesMetadata.java:
##########
@@ -394,4 +400,37 @@ public String toString() {
+ chunkMetadataList
+ '}';
}
+
+ public static void main(String[] args) throws IOException {
Review Comment:
Well, the serialization still accounts for a significant part in my experiment, so I would like to keep this a little longer in case I find some further optimizations in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimizations regarding chunk metadata sort & timeseries metadata serialization [tsfile]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #470:
URL: https://github.com/apache/tsfile/pull/470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org