[GitHub] [nutch] sebastian-nagel commented on a change in pull request #647: NUTCH-2864 Upgrade Dockerfile to use JDK 11

[GitBox <gi...@apache.org>]

sebastian-nagel commented on a change in pull request #647:
URL: https://github.com/apache/nutch/pull/647#discussion_r644720262



##########
File path: docker/Dockerfile
##########
@@ -13,21 +13,21 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-FROM ubuntu:18.04
+FROM alpine:3.13
 MAINTAINER Apache Nutch Committers <de...@nutch.apache.org>
 
 WORKDIR /root/
 
-
 # Install dependencies
-RUN apt update
-RUN apt install -y ant git openjdk-8-jdk-headless
-
-# Set up JAVA_HOME
-RUN echo 'export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64' >> $HOME/.bashrc

Review comment:
       JAVA_HOME needs to be set
   ```
   RUN echo 'export JAVA_HOME=/usr/lib/jvm/java-11-openjdk' >> $HOME/.bashrc
   ```
   otherwise bin/nutch fails:
   ```
   bash-5.1# bin/nutch parsechecker https://nutch.apache.org/
   Error: JAVA_HOME is not set.
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org