You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "lostluck (via GitHub)" <gi...@apache.org> on 2024/10/16 23:46:14 UTC
[PR] [#30703][prism] Update logging handling [beam]
lostluck opened a new pull request, #32826:
URL: https://github.com/apache/beam/pull/32826
* Migrate the SDK to consistently use "log/slog" since we've moved to Go 1.21 as base.
* Improve SDK side logging: logs should be emitted to the prism process at least.
* TODO in separate PR: Check that Prism is outputting to stderr for local Java and Python execution.
* Improve the format, clarify the log source for SDK logs. Better field grouping.
* Include SDK sourced Custom Data structured logging fields if present.
* Improve Prism's ability to debug issues in the Docker image
* Print the Docker log when an unexpected context cancellation occurs.
* Add new debug print when we're unable to copy the Google Auth file to the container.
* Standalone Prism logging improvements:
* New flag "log_kind" which sets the log formatting, to one of "json", "text", and "dev". "dev" is the default.
* "dev" uses the zero dependency "github.com/golang-cz/devslog" package to format console logs instead of the default slog behavior.
* Adds colour and better structure, more suitable for development.
* New flag "debug" which sets the log level for the Prism binary to Debug, printing all the various debuging prints. Intended for Core SDK developers and Prism developers.
* Enables Source file lines for prism locations.
* Improve plumbing of a logger through a job. This work is ongoing, eg. TODO: element manager.
* Various minor improvements to logging messages, to wrap with slog.Attrs to reduce allocations.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#30703][prism] Update logging handling [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32826:
URL: https://github.com/apache/beam/pull/32826#issuecomment-2418173878
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#30703][prism] Update logging handling [beam]
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #32826:
URL: https://github.com/apache/beam/pull/32826#issuecomment-2418168965
R: @byronellis @damondouglas
This is a smaller change than it looks, it only touches so many files because of the swap to the Standard Library slog package. Otherwise most files can be reviewed independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#30703][prism] Update logging handling [beam]
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck merged PR #32826:
URL: https://github.com/apache/beam/pull/32826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org