You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/02/09 06:17:44 UTC
[kudu-CR] Random cleanups in RaftConsensus
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9267
to review the following change.
Change subject: Random cleanups in RaftConsensus
......................................................................
Random cleanups in RaftConsensus
This patch implements various random cleanups in RaftConsensus and
ConsensusMetadata, including adding a DCHECK and an AssertWaitAllowed(),
in addition to only acquiring the RaftConsensus lock once in the
election callback.
Change-Id: Ie470a526a4a0b0595b3d4310a961876e52a99b0a
---
M src/kudu/consensus/consensus_meta.h
M src/kudu/consensus/raft_consensus.cc
2 files changed, 35 insertions(+), 37 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/9267/1
--
To view, visit http://gerrit.cloudera.org:8080/9267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie470a526a4a0b0595b3d4310a961876e52a99b0a
Gerrit-Change-Number: 9267
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] Random cleanups in RaftConsensus
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9267 )
Change subject: Random cleanups in RaftConsensus
......................................................................
Patch Set 1:
It seems TsTabletManagerITest.ReportOnReplicaHealthStatus starts failing.
--
To view, visit http://gerrit.cloudera.org:8080/9267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie470a526a4a0b0595b3d4310a961876e52a99b0a
Gerrit-Change-Number: 9267
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 09 Feb 2018 07:41:13 +0000
Gerrit-HasComments: No
[kudu-CR] Random cleanups in RaftConsensus
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9267 )
Change subject: Random cleanups in RaftConsensus
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie470a526a4a0b0595b3d4310a961876e52a99b0a
Gerrit-Change-Number: 9267
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 10 Feb 2018 02:23:27 +0000
Gerrit-HasComments: No
[kudu-CR] Random cleanups in RaftConsensus
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9267 )
Change subject: Random cleanups in RaftConsensus
......................................................................
Random cleanups in RaftConsensus
This patch implements various random cleanups in RaftConsensus and
ConsensusMetadata, including adding a DCHECK and an AssertWaitAllowed(),
in addition to only acquiring the RaftConsensus lock once in the
election callback.
Change-Id: Ie470a526a4a0b0595b3d4310a961876e52a99b0a
Reviewed-on: http://gerrit.cloudera.org:8080/9267
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/consensus/consensus_meta.h
M src/kudu/consensus/raft_consensus.cc
2 files changed, 35 insertions(+), 37 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie470a526a4a0b0595b3d4310a961876e52a99b0a
Gerrit-Change-Number: 9267
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>