You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Alexey Goncharuk <al...@gmail.com> on 2018/04/02 09:48:18 UTC
Re: IGNITE-6827 - Review needed.
Guys, especially Vladimir Ozerov, Yakov Zhanov, Dmitriy Setrakyan,
While the technical side of the change is being reviewed, I would also ask
you to pay attention to the public API changes here.
--AG
2018-03-21 23:43 GMT+03:00 Pavel Tupitsyn <pt...@apache.org>:
> Hi Alexei,
>
> > Pavel Tupitsyn, could you lend a hand to help completing .NET part (two
> new
> public API methods are added as a part of working on [3], java code in
> branch [2])
>
> Please file a separate ticket for .NET changes.
> I would like to help, but maybe some time later. No need to delay your
> changes because of that.
>
> Thanks,
> Pavel
>
> On Wed, Mar 21, 2018 at 1:08 PM, Dmitry Pavlov <dp...@gmail.com>
> wrote:
>
> > Hi Alexei ,
> >
> > Thank you for contribution, unfortunately there is too much tests failed
> > there:
> > .NET is broken
> >
> > Ignite Platform .NET Long Running [ tests 3 ]
> > CachePartitionedNearEnabledTest.TestTransactionScopeMultiCache(True)
> > CachePartitionedTest.TestTransactionScopeMultiCache(True)
> > CacheReplicatedTest.TestTransactionScopeMultiCache(True)
> >
> > Ignite Platform .NET Core Linux [ tests 2 TC_EXIT_CODE ]
> > TransactionsParityTest.TestTransactions (fail rate 0,0%)
> > CachePartitionedTest.TestTransactionScopeMultiCache(True) (fail
> rate
> > 0,0%)
> >
> > Ignite Platform .NET [ tests 1 ] agoncharuk More info >>
> > Test fail rate less than 1%, probably new failure exe:
> > TransactionsParityTest.TestTransactions (fail rate 0,0%)
> >
> > Too much timeouts:
> > Ignite Cache Failover [2]
> > with CacheAsyncOperationsFailoverTxTest.testPutAllAsyncFailover (last
> > started)
> >
> > ~[Obsolete] Ignite Cache Expiry Policy [ tests 1 ]
> > with IgniteCacheExpiryPolicyTestSuite:
> > IgniteCacheTtlCleanupSelfTest.testDeferredDeleteTtl
> >
> > Ignite Cache Restarts [2]
> > with
> > GridCachePutAllFailoverSelfTest.testPutAllFailoverNearDisabled
> ThreeBackups
> > (last started)
> >
> > Ignite Cache Restarts [1]
> > with
> > GridCachePartitionedNearDisabledOptimisticTxNodeRestartTest.
> > testRestartWithTxTenNodesTwoBackups
> > (last started)
> >
> > Cache [6]
> > with WalModeChangeAdvancedSelfTest.testServerRestartNonCoordinator
> > (last started)
> > it is not all.
> >
> > Please fix tests before review. Also you could change ticket status to
> 'In
> > Progress'.
> >
> > As easy option, you can merge current master to your branch, it is
> probably
> > that some test were fixed already.
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > ср, 21 мар. 2018 г. в 9:58, Alexei Scherbakov <
> > alexey.scherbakoff@gmail.com
> > >:
> >
> > > Igniters,
> > >
> > > I prepared rather important patch [1] related to grid stability and
> need
> > a
> > > review and some help to finish it.
> > >
> > > Semyon Boikov, could you please take a look on patch code ? [2]
> > >
> > > Pavel Tupitsyn, could you lend a hand to help completing .NET part (two
> > new
> > > public API methods are added as a part of working on [3], java code in
> > > branch [2])
> > >
> > > [1] https://issues.apache.org/jira/browse/IGNITE-6827
> > >
> > > [2] https://github.com/gridgain/apache-ignite/tree/ignite-6827-2
> > >
> > > [3] https://issues.apache.org/jira/browse/IGNITE-7910
> > >
> > > --
> > >
> > > Best regards,
> > > Alexei Scherbakov
> > >
> >
>
Re: IGNITE-6827 - Review needed.
Posted by Dmitry Pavlov <dp...@gmail.com>.
Hi Nick,
I can't find any timeouts specified for transaction creation in IGNITE-6967
code (for services cache), so I'm not sure current fix wil help. But anyway
soon it can be double-checked with 2.5 release.
I hope IGNITE-6967 will be fixed soon in the IEP-17. Vyacheslav Daradur
picked up this task. So workaround will not be necessary.
Sincerely,
Dmitriy Pavlov
чт, 17 мая 2018 г. в 20:36, npordash <ni...@gmail.com>:
> Hi,
>
> Would IGNITE-6827 potentially be a workaround for IGNITE-6967? I understand
> that eventually IGNITE-6967 will not be applicable once the service grid
> stops using the utility cache and switches to discovery messages, but I've
> encountered odd deadlocks with PME and I'm growing more suspicious that
> it's
> happening due to IGNITE-6967 because it seems to only happen when nodes
> start flapping (f.e. due to faulty VM hardware).
>
> -Nick
>
>
>
>
>
> --
> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>
Re: IGNITE-6827 - Review needed.
Posted by npordash <ni...@gmail.com>.
Hi,
Would IGNITE-6827 potentially be a workaround for IGNITE-6967? I understand
that eventually IGNITE-6967 will not be applicable once the service grid
stops using the utility cache and switches to discovery messages, but I've
encountered odd deadlocks with PME and I'm growing more suspicious that it's
happening due to IGNITE-6967 because it seems to only happen when nodes
start flapping (f.e. due to faulty VM hardware).
-Nick
--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: IGNITE-6827 - Review needed.
Posted by Ivan Daschinsky <iv...@gmail.com>.
Hi all, I've implemented corresponded .NET api.
Pavel, could you review my PR, please?
https://issues.apache.org/jira/browse/IGNITE-8075
2018-04-10 21:06 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
> Hi Pavel,
>
> thank you for bring up test questions. It seems my previous comments were
> not taken into account.
>
> Igniters,
>
> let me remind we should get passing TC suites before merge,
> https://cwiki.apache.org/confluence/display/IGNITE/How+
> to+Contribute#HowtoContribute-ReviewProcessandMaintainers
> (highlighted
> note).
>
> For disabling parity test checks please consider steps describled in
> https://cwiki.apache.org/confluence/display/IGNITE/Ignite+Tests+How+To#
> IgniteTestsHowTo-Testof.NETAPIparitywithJavaAPI
>
> Sincerely,
> Dmitriy Pavlov
>
>
> пн, 9 апр. 2018 г. в 21:18, Pavel Tupitsyn <pt...@apache.org>:
>
> > > Pavel Tupitsyn, what about .NET stuff ?
> >
> > 1) Thank you for filing the ticket, personally I have no plans to work on
> > it in the near future.
> >
> > 2) .NET tests fail, please make sure they are fixed before merging:
> > https://ci.ignite.apache.org/viewLog.html?buildId=1175956
> >
> > TransactionsParityTest should be fixed by adding new properties to ignore
> > list with a reference to IGNITE-8075, this is simple.
> >
> > But I have concerns about
> > *CachePartitionedTest.TestTransactionScopeMultiCache, *
> > seems like something is broken with multi-cache transactions. Please
> > investigate this one.
> >
> > Thanks,
> > Pavel
> >
> >
> > On Mon, Apr 9, 2018 at 6:24 PM, Alexei Scherbakov <
> > alexey.scherbakoff@gmail.com> wrote:
> >
> > > Guys,
> > >
> > > I've slightly modified public API javadoc as Denis Magda has suggested
> in
> > > PR review.
> > >
> > > Please take a look.
> > >
> > > Pavel Tupitsyn, what about .NET stuff ?
> > >
> > > I provided all necessary information in ticket [2]
> > >
> > > Upsource link [1]
> > >
> > > [1] https://reviews.ignite.apache.org/ignite/branch/PR%203624
> > >
> > > [2] https://issues.apache.org/jira/browse/IGNITE-8075
> > >
> > >
> > >
> > > пн, 9 апр. 2018 г. в 16:57, Alexey Goncharuk <
> alexey.goncharuk@gmail.com
> > >:
> > >
> > > > I am not aware of any additional timeouts that we are willing to add
> in
> > > the
> > > > nearest future.
> > > >
> > > > 2018-04-09 16:01 GMT+03:00 Dmitriy Setrakyan <dsetrakyan@apache.org
> >:
> > > >
> > > > > On Mon, Apr 9, 2018 at 5:42 AM, Alexey Goncharuk <
> > > > > alexey.goncharuk@gmail.com
> > > > > > wrote:
> > > > >
> > > > > > Guys,
> > > > > >
> > > > > > After the review in Upsource the configuration parameter was
> > renamed
> > > > > > to txTimeoutOnPartMapSync, and it makes sense to me because PME
> is
> > an
> > > > > > implementation detail and it may change in future, partition map
> > sync
> > > > is
> > > > > a
> > > > > > more abstract term. For the same reason I like this parameter
> being
> > > > > placed
> > > > > > on transactions configuration - we do not have any parameters for
> > > PME,
> > > > so
> > > > > > the configuration property goes to an object which affects a
> > > > user-exposed
> > > > > > API.
> > > > > >
> > > > >
> > > > > AG, are we going to have any other timeouts on PME, like locks? If
> > yes,
> > > > > then I would still vote of adding PmeTimeout property.
> > > > >
> > > >
> > >
> > >
> > > --
> > >
> > > Best regards,
> > > Alexei Scherbakov
> > >
> >
>
--
Sincerely yours, Ivan Daschinskiy
Re: IGNITE-6827 - Review needed.
Posted by Dmitry Pavlov <dp...@gmail.com>.
Hi Pavel,
thank you for bring up test questions. It seems my previous comments were
not taken into account.
Igniters,
let me remind we should get passing TC suites before merge,
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers
(highlighted
note).
For disabling parity test checks please consider steps describled in
https://cwiki.apache.org/confluence/display/IGNITE/Ignite+Tests+How+To#IgniteTestsHowTo-Testof.NETAPIparitywithJavaAPI
Sincerely,
Dmitriy Pavlov
пн, 9 апр. 2018 г. в 21:18, Pavel Tupitsyn <pt...@apache.org>:
> > Pavel Tupitsyn, what about .NET stuff ?
>
> 1) Thank you for filing the ticket, personally I have no plans to work on
> it in the near future.
>
> 2) .NET tests fail, please make sure they are fixed before merging:
> https://ci.ignite.apache.org/viewLog.html?buildId=1175956
>
> TransactionsParityTest should be fixed by adding new properties to ignore
> list with a reference to IGNITE-8075, this is simple.
>
> But I have concerns about
> *CachePartitionedTest.TestTransactionScopeMultiCache, *
> seems like something is broken with multi-cache transactions. Please
> investigate this one.
>
> Thanks,
> Pavel
>
>
> On Mon, Apr 9, 2018 at 6:24 PM, Alexei Scherbakov <
> alexey.scherbakoff@gmail.com> wrote:
>
> > Guys,
> >
> > I've slightly modified public API javadoc as Denis Magda has suggested in
> > PR review.
> >
> > Please take a look.
> >
> > Pavel Tupitsyn, what about .NET stuff ?
> >
> > I provided all necessary information in ticket [2]
> >
> > Upsource link [1]
> >
> > [1] https://reviews.ignite.apache.org/ignite/branch/PR%203624
> >
> > [2] https://issues.apache.org/jira/browse/IGNITE-8075
> >
> >
> >
> > пн, 9 апр. 2018 г. в 16:57, Alexey Goncharuk <alexey.goncharuk@gmail.com
> >:
> >
> > > I am not aware of any additional timeouts that we are willing to add in
> > the
> > > nearest future.
> > >
> > > 2018-04-09 16:01 GMT+03:00 Dmitriy Setrakyan <ds...@apache.org>:
> > >
> > > > On Mon, Apr 9, 2018 at 5:42 AM, Alexey Goncharuk <
> > > > alexey.goncharuk@gmail.com
> > > > > wrote:
> > > >
> > > > > Guys,
> > > > >
> > > > > After the review in Upsource the configuration parameter was
> renamed
> > > > > to txTimeoutOnPartMapSync, and it makes sense to me because PME is
> an
> > > > > implementation detail and it may change in future, partition map
> sync
> > > is
> > > > a
> > > > > more abstract term. For the same reason I like this parameter being
> > > > placed
> > > > > on transactions configuration - we do not have any parameters for
> > PME,
> > > so
> > > > > the configuration property goes to an object which affects a
> > > user-exposed
> > > > > API.
> > > > >
> > > >
> > > > AG, are we going to have any other timeouts on PME, like locks? If
> yes,
> > > > then I would still vote of adding PmeTimeout property.
> > > >
> > >
> >
> >
> > --
> >
> > Best regards,
> > Alexei Scherbakov
> >
>
Re: IGNITE-6827 - Review needed.
Posted by Pavel Tupitsyn <pt...@apache.org>.
> Pavel Tupitsyn, what about .NET stuff ?
1) Thank you for filing the ticket, personally I have no plans to work on
it in the near future.
2) .NET tests fail, please make sure they are fixed before merging:
https://ci.ignite.apache.org/viewLog.html?buildId=1175956
TransactionsParityTest should be fixed by adding new properties to ignore
list with a reference to IGNITE-8075, this is simple.
But I have concerns about
*CachePartitionedTest.TestTransactionScopeMultiCache, *
seems like something is broken with multi-cache transactions. Please
investigate this one.
Thanks,
Pavel
On Mon, Apr 9, 2018 at 6:24 PM, Alexei Scherbakov <
alexey.scherbakoff@gmail.com> wrote:
> Guys,
>
> I've slightly modified public API javadoc as Denis Magda has suggested in
> PR review.
>
> Please take a look.
>
> Pavel Tupitsyn, what about .NET stuff ?
>
> I provided all necessary information in ticket [2]
>
> Upsource link [1]
>
> [1] https://reviews.ignite.apache.org/ignite/branch/PR%203624
>
> [2] https://issues.apache.org/jira/browse/IGNITE-8075
>
>
>
> пн, 9 апр. 2018 г. в 16:57, Alexey Goncharuk <al...@gmail.com>:
>
> > I am not aware of any additional timeouts that we are willing to add in
> the
> > nearest future.
> >
> > 2018-04-09 16:01 GMT+03:00 Dmitriy Setrakyan <ds...@apache.org>:
> >
> > > On Mon, Apr 9, 2018 at 5:42 AM, Alexey Goncharuk <
> > > alexey.goncharuk@gmail.com
> > > > wrote:
> > >
> > > > Guys,
> > > >
> > > > After the review in Upsource the configuration parameter was renamed
> > > > to txTimeoutOnPartMapSync, and it makes sense to me because PME is an
> > > > implementation detail and it may change in future, partition map sync
> > is
> > > a
> > > > more abstract term. For the same reason I like this parameter being
> > > placed
> > > > on transactions configuration - we do not have any parameters for
> PME,
> > so
> > > > the configuration property goes to an object which affects a
> > user-exposed
> > > > API.
> > > >
> > >
> > > AG, are we going to have any other timeouts on PME, like locks? If yes,
> > > then I would still vote of adding PmeTimeout property.
> > >
> >
>
>
> --
>
> Best regards,
> Alexei Scherbakov
>
Re: IGNITE-6827 - Review needed.
Posted by Alexei Scherbakov <al...@gmail.com>.
Guys,
I've slightly modified public API javadoc as Denis Magda has suggested in
PR review.
Please take a look.
Pavel Tupitsyn, what about .NET stuff ?
I provided all necessary information in ticket [2]
Upsource link [1]
[1] https://reviews.ignite.apache.org/ignite/branch/PR%203624
[2] https://issues.apache.org/jira/browse/IGNITE-8075
пн, 9 апр. 2018 г. в 16:57, Alexey Goncharuk <al...@gmail.com>:
> I am not aware of any additional timeouts that we are willing to add in the
> nearest future.
>
> 2018-04-09 16:01 GMT+03:00 Dmitriy Setrakyan <ds...@apache.org>:
>
> > On Mon, Apr 9, 2018 at 5:42 AM, Alexey Goncharuk <
> > alexey.goncharuk@gmail.com
> > > wrote:
> >
> > > Guys,
> > >
> > > After the review in Upsource the configuration parameter was renamed
> > > to txTimeoutOnPartMapSync, and it makes sense to me because PME is an
> > > implementation detail and it may change in future, partition map sync
> is
> > a
> > > more abstract term. For the same reason I like this parameter being
> > placed
> > > on transactions configuration - we do not have any parameters for PME,
> so
> > > the configuration property goes to an object which affects a
> user-exposed
> > > API.
> > >
> >
> > AG, are we going to have any other timeouts on PME, like locks? If yes,
> > then I would still vote of adding PmeTimeout property.
> >
>
--
Best regards,
Alexei Scherbakov
Re: IGNITE-6827 - Review needed.
Posted by Alexey Goncharuk <al...@gmail.com>.
I am not aware of any additional timeouts that we are willing to add in the
nearest future.
2018-04-09 16:01 GMT+03:00 Dmitriy Setrakyan <ds...@apache.org>:
> On Mon, Apr 9, 2018 at 5:42 AM, Alexey Goncharuk <
> alexey.goncharuk@gmail.com
> > wrote:
>
> > Guys,
> >
> > After the review in Upsource the configuration parameter was renamed
> > to txTimeoutOnPartMapSync, and it makes sense to me because PME is an
> > implementation detail and it may change in future, partition map sync is
> a
> > more abstract term. For the same reason I like this parameter being
> placed
> > on transactions configuration - we do not have any parameters for PME, so
> > the configuration property goes to an object which affects a user-exposed
> > API.
> >
>
> AG, are we going to have any other timeouts on PME, like locks? If yes,
> then I would still vote of adding PmeTimeout property.
>
Re: IGNITE-6827 - Review needed.
Posted by Dmitriy Setrakyan <ds...@apache.org>.
On Mon, Apr 9, 2018 at 5:42 AM, Alexey Goncharuk <alexey.goncharuk@gmail.com
> wrote:
> Guys,
>
> After the review in Upsource the configuration parameter was renamed
> to txTimeoutOnPartMapSync, and it makes sense to me because PME is an
> implementation detail and it may change in future, partition map sync is a
> more abstract term. For the same reason I like this parameter being placed
> on transactions configuration - we do not have any parameters for PME, so
> the configuration property goes to an object which affects a user-exposed
> API.
>
AG, are we going to have any other timeouts on PME, like locks? If yes,
then I would still vote of adding PmeTimeout property.
Re: IGNITE-6827 - Review needed.
Posted by Alexey Goncharuk <al...@gmail.com>.
Guys,
After the review in Upsource the configuration parameter was renamed
to txTimeoutOnPartMapSync, and it makes sense to me because PME is an
implementation detail and it may change in future, partition map sync is a
more abstract term. For the same reason I like this parameter being placed
on transactions configuration - we do not have any parameters for PME, so
the configuration property goes to an object which affects a user-exposed
API.
2018-04-03 15:13 GMT+03:00 Andrey Gura <ag...@apache.org>:
> Alexey,
>
> could you please create code review in Upsource? The PR is huge and it
> would be great to have an ability to discuss changes in more
> convenient way.
>
> Thanks.
>
> On Tue, Apr 3, 2018 at 12:42 AM, Dmitriy Setrakyan
> <ds...@apache.org> wrote:
> > I looked into the ticket and do not understand this property
> > name: RollbackOnTopologyChangeTimeout
> >
> > I think what we need to configure is a forceful kill of transactions in
> > case of partition map exchange, right? In that case, the timeout should
> be
> > configured for PME, not transactions. The property name should be
> > PartitionMapExchangePreparationTimeout or PartitionMapExchangeTxTimeout.
> >
> > Am I missing something?
> >
> > D.
> >
> > On Mon, Apr 2, 2018 at 2:48 AM, Alexey Goncharuk <
> alexey.goncharuk@gmail.com
> >> wrote:
> >
> >> Guys, especially Vladimir Ozerov, Yakov Zhanov, Dmitriy Setrakyan,
> >>
> >> While the technical side of the change is being reviewed, I would also
> ask
> >> you to pay attention to the public API changes here.
> >>
> >> --AG
> >>
> >> 2018-03-21 23:43 GMT+03:00 Pavel Tupitsyn <pt...@apache.org>:
> >>
> >> > Hi Alexei,
> >> >
> >> > > Pavel Tupitsyn, could you lend a hand to help completing .NET part
> >> (two
> >> > new
> >> > public API methods are added as a part of working on [3], java code in
> >> > branch [2])
> >> >
> >> > Please file a separate ticket for .NET changes.
> >> > I would like to help, but maybe some time later. No need to delay your
> >> > changes because of that.
> >> >
> >> > Thanks,
> >> > Pavel
> >> >
> >> > On Wed, Mar 21, 2018 at 1:08 PM, Dmitry Pavlov <dpavlov.spb@gmail.com
> >
> >> > wrote:
> >> >
> >> > > Hi Alexei ,
> >> > >
> >> > > Thank you for contribution, unfortunately there is too much tests
> >> failed
> >> > > there:
> >> > > .NET is broken
> >> > >
> >> > > Ignite Platform .NET Long Running [ tests 3 ]
> >> > > CachePartitionedNearEnabledTest.TestTransactionScopeMultiCache
> >> (True)
> >> > > CachePartitionedTest.TestTransactionScopeMultiCache(True)
> >> > > CacheReplicatedTest.TestTransactionScopeMultiCache(True)
> >> > >
> >> > > Ignite Platform .NET Core Linux [ tests 2 TC_EXIT_CODE ]
> >> > > TransactionsParityTest.TestTransactions (fail rate 0,0%)
> >> > > CachePartitionedTest.TestTransactionScopeMultiCache(True)
> (fail
> >> > rate
> >> > > 0,0%)
> >> > >
> >> > > Ignite Platform .NET [ tests 1 ] agoncharuk More info >>
> >> > > Test fail rate less than 1%, probably new failure exe:
> >> > > TransactionsParityTest.TestTransactions (fail rate 0,0%)
> >> > >
> >> > > Too much timeouts:
> >> > > Ignite Cache Failover [2]
> >> > > with CacheAsyncOperationsFailoverTxTest.testPutAllAsyncFailover
> (last
> >> > > started)
> >> > >
> >> > > ~[Obsolete] Ignite Cache Expiry Policy [ tests 1 ]
> >> > > with IgniteCacheExpiryPolicyTestSuite:
> >> > > IgniteCacheTtlCleanupSelfTest.testDeferredDeleteTtl
> >> > >
> >> > > Ignite Cache Restarts [2]
> >> > > with
> >> > > GridCachePutAllFailoverSelfTest.testPutAllFailoverNearDisabled
> >> > ThreeBackups
> >> > > (last started)
> >> > >
> >> > > Ignite Cache Restarts [1]
> >> > > with
> >> > > GridCachePartitionedNearDisabledOptimisticTxNodeRestartTest.
> >> > > testRestartWithTxTenNodesTwoBackups
> >> > > (last started)
> >> > >
> >> > > Cache [6]
> >> > > with WalModeChangeAdvancedSelfTest.
> testServerRestartNonCoordinator
> >> > > (last started)
> >> > > it is not all.
> >> > >
> >> > > Please fix tests before review. Also you could change ticket status
> to
> >> > 'In
> >> > > Progress'.
> >> > >
> >> > > As easy option, you can merge current master to your branch, it is
> >> > probably
> >> > > that some test were fixed already.
> >> > >
> >> > > Sincerely,
> >> > > Dmitriy Pavlov
> >> > >
> >> > > ср, 21 мар. 2018 г. в 9:58, Alexei Scherbakov <
> >> > > alexey.scherbakoff@gmail.com
> >> > > >:
> >> > >
> >> > > > Igniters,
> >> > > >
> >> > > > I prepared rather important patch [1] related to grid stability
> and
> >> > need
> >> > > a
> >> > > > review and some help to finish it.
> >> > > >
> >> > > > Semyon Boikov, could you please take a look on patch code ? [2]
> >> > > >
> >> > > > Pavel Tupitsyn, could you lend a hand to help completing .NET part
> >> (two
> >> > > new
> >> > > > public API methods are added as a part of working on [3], java
> code
> >> in
> >> > > > branch [2])
> >> > > >
> >> > > > [1] https://issues.apache.org/jira/browse/IGNITE-6827
> >> > > >
> >> > > > [2] https://github.com/gridgain/apache-ignite/tree/ignite-6827-2
> >> > > >
> >> > > > [3] https://issues.apache.org/jira/browse/IGNITE-7910
> >> > > >
> >> > > > --
> >> > > >
> >> > > > Best regards,
> >> > > > Alexei Scherbakov
> >> > > >
> >> > >
> >> >
> >>
>
Re: IGNITE-6827 - Review needed.
Posted by Andrey Gura <ag...@apache.org>.
Alexey,
could you please create code review in Upsource? The PR is huge and it
would be great to have an ability to discuss changes in more
convenient way.
Thanks.
On Tue, Apr 3, 2018 at 12:42 AM, Dmitriy Setrakyan
<ds...@apache.org> wrote:
> I looked into the ticket and do not understand this property
> name: RollbackOnTopologyChangeTimeout
>
> I think what we need to configure is a forceful kill of transactions in
> case of partition map exchange, right? In that case, the timeout should be
> configured for PME, not transactions. The property name should be
> PartitionMapExchangePreparationTimeout or PartitionMapExchangeTxTimeout.
>
> Am I missing something?
>
> D.
>
> On Mon, Apr 2, 2018 at 2:48 AM, Alexey Goncharuk <alexey.goncharuk@gmail.com
>> wrote:
>
>> Guys, especially Vladimir Ozerov, Yakov Zhanov, Dmitriy Setrakyan,
>>
>> While the technical side of the change is being reviewed, I would also ask
>> you to pay attention to the public API changes here.
>>
>> --AG
>>
>> 2018-03-21 23:43 GMT+03:00 Pavel Tupitsyn <pt...@apache.org>:
>>
>> > Hi Alexei,
>> >
>> > > Pavel Tupitsyn, could you lend a hand to help completing .NET part
>> (two
>> > new
>> > public API methods are added as a part of working on [3], java code in
>> > branch [2])
>> >
>> > Please file a separate ticket for .NET changes.
>> > I would like to help, but maybe some time later. No need to delay your
>> > changes because of that.
>> >
>> > Thanks,
>> > Pavel
>> >
>> > On Wed, Mar 21, 2018 at 1:08 PM, Dmitry Pavlov <dp...@gmail.com>
>> > wrote:
>> >
>> > > Hi Alexei ,
>> > >
>> > > Thank you for contribution, unfortunately there is too much tests
>> failed
>> > > there:
>> > > .NET is broken
>> > >
>> > > Ignite Platform .NET Long Running [ tests 3 ]
>> > > CachePartitionedNearEnabledTest.TestTransactionScopeMultiCache
>> (True)
>> > > CachePartitionedTest.TestTransactionScopeMultiCache(True)
>> > > CacheReplicatedTest.TestTransactionScopeMultiCache(True)
>> > >
>> > > Ignite Platform .NET Core Linux [ tests 2 TC_EXIT_CODE ]
>> > > TransactionsParityTest.TestTransactions (fail rate 0,0%)
>> > > CachePartitionedTest.TestTransactionScopeMultiCache(True) (fail
>> > rate
>> > > 0,0%)
>> > >
>> > > Ignite Platform .NET [ tests 1 ] agoncharuk More info >>
>> > > Test fail rate less than 1%, probably new failure exe:
>> > > TransactionsParityTest.TestTransactions (fail rate 0,0%)
>> > >
>> > > Too much timeouts:
>> > > Ignite Cache Failover [2]
>> > > with CacheAsyncOperationsFailoverTxTest.testPutAllAsyncFailover (last
>> > > started)
>> > >
>> > > ~[Obsolete] Ignite Cache Expiry Policy [ tests 1 ]
>> > > with IgniteCacheExpiryPolicyTestSuite:
>> > > IgniteCacheTtlCleanupSelfTest.testDeferredDeleteTtl
>> > >
>> > > Ignite Cache Restarts [2]
>> > > with
>> > > GridCachePutAllFailoverSelfTest.testPutAllFailoverNearDisabled
>> > ThreeBackups
>> > > (last started)
>> > >
>> > > Ignite Cache Restarts [1]
>> > > with
>> > > GridCachePartitionedNearDisabledOptimisticTxNodeRestartTest.
>> > > testRestartWithTxTenNodesTwoBackups
>> > > (last started)
>> > >
>> > > Cache [6]
>> > > with WalModeChangeAdvancedSelfTest.testServerRestartNonCoordinator
>> > > (last started)
>> > > it is not all.
>> > >
>> > > Please fix tests before review. Also you could change ticket status to
>> > 'In
>> > > Progress'.
>> > >
>> > > As easy option, you can merge current master to your branch, it is
>> > probably
>> > > that some test were fixed already.
>> > >
>> > > Sincerely,
>> > > Dmitriy Pavlov
>> > >
>> > > ср, 21 мар. 2018 г. в 9:58, Alexei Scherbakov <
>> > > alexey.scherbakoff@gmail.com
>> > > >:
>> > >
>> > > > Igniters,
>> > > >
>> > > > I prepared rather important patch [1] related to grid stability and
>> > need
>> > > a
>> > > > review and some help to finish it.
>> > > >
>> > > > Semyon Boikov, could you please take a look on patch code ? [2]
>> > > >
>> > > > Pavel Tupitsyn, could you lend a hand to help completing .NET part
>> (two
>> > > new
>> > > > public API methods are added as a part of working on [3], java code
>> in
>> > > > branch [2])
>> > > >
>> > > > [1] https://issues.apache.org/jira/browse/IGNITE-6827
>> > > >
>> > > > [2] https://github.com/gridgain/apache-ignite/tree/ignite-6827-2
>> > > >
>> > > > [3] https://issues.apache.org/jira/browse/IGNITE-7910
>> > > >
>> > > > --
>> > > >
>> > > > Best regards,
>> > > > Alexei Scherbakov
>> > > >
>> > >
>> >
>>
Re: IGNITE-6827 - Review needed.
Posted by Dmitriy Setrakyan <ds...@apache.org>.
I looked into the ticket and do not understand this property
name: RollbackOnTopologyChangeTimeout
I think what we need to configure is a forceful kill of transactions in
case of partition map exchange, right? In that case, the timeout should be
configured for PME, not transactions. The property name should be
PartitionMapExchangePreparationTimeout or PartitionMapExchangeTxTimeout.
Am I missing something?
D.
On Mon, Apr 2, 2018 at 2:48 AM, Alexey Goncharuk <alexey.goncharuk@gmail.com
> wrote:
> Guys, especially Vladimir Ozerov, Yakov Zhanov, Dmitriy Setrakyan,
>
> While the technical side of the change is being reviewed, I would also ask
> you to pay attention to the public API changes here.
>
> --AG
>
> 2018-03-21 23:43 GMT+03:00 Pavel Tupitsyn <pt...@apache.org>:
>
> > Hi Alexei,
> >
> > > Pavel Tupitsyn, could you lend a hand to help completing .NET part
> (two
> > new
> > public API methods are added as a part of working on [3], java code in
> > branch [2])
> >
> > Please file a separate ticket for .NET changes.
> > I would like to help, but maybe some time later. No need to delay your
> > changes because of that.
> >
> > Thanks,
> > Pavel
> >
> > On Wed, Mar 21, 2018 at 1:08 PM, Dmitry Pavlov <dp...@gmail.com>
> > wrote:
> >
> > > Hi Alexei ,
> > >
> > > Thank you for contribution, unfortunately there is too much tests
> failed
> > > there:
> > > .NET is broken
> > >
> > > Ignite Platform .NET Long Running [ tests 3 ]
> > > CachePartitionedNearEnabledTest.TestTransactionScopeMultiCache
> (True)
> > > CachePartitionedTest.TestTransactionScopeMultiCache(True)
> > > CacheReplicatedTest.TestTransactionScopeMultiCache(True)
> > >
> > > Ignite Platform .NET Core Linux [ tests 2 TC_EXIT_CODE ]
> > > TransactionsParityTest.TestTransactions (fail rate 0,0%)
> > > CachePartitionedTest.TestTransactionScopeMultiCache(True) (fail
> > rate
> > > 0,0%)
> > >
> > > Ignite Platform .NET [ tests 1 ] agoncharuk More info >>
> > > Test fail rate less than 1%, probably new failure exe:
> > > TransactionsParityTest.TestTransactions (fail rate 0,0%)
> > >
> > > Too much timeouts:
> > > Ignite Cache Failover [2]
> > > with CacheAsyncOperationsFailoverTxTest.testPutAllAsyncFailover (last
> > > started)
> > >
> > > ~[Obsolete] Ignite Cache Expiry Policy [ tests 1 ]
> > > with IgniteCacheExpiryPolicyTestSuite:
> > > IgniteCacheTtlCleanupSelfTest.testDeferredDeleteTtl
> > >
> > > Ignite Cache Restarts [2]
> > > with
> > > GridCachePutAllFailoverSelfTest.testPutAllFailoverNearDisabled
> > ThreeBackups
> > > (last started)
> > >
> > > Ignite Cache Restarts [1]
> > > with
> > > GridCachePartitionedNearDisabledOptimisticTxNodeRestartTest.
> > > testRestartWithTxTenNodesTwoBackups
> > > (last started)
> > >
> > > Cache [6]
> > > with WalModeChangeAdvancedSelfTest.testServerRestartNonCoordinator
> > > (last started)
> > > it is not all.
> > >
> > > Please fix tests before review. Also you could change ticket status to
> > 'In
> > > Progress'.
> > >
> > > As easy option, you can merge current master to your branch, it is
> > probably
> > > that some test were fixed already.
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > ср, 21 мар. 2018 г. в 9:58, Alexei Scherbakov <
> > > alexey.scherbakoff@gmail.com
> > > >:
> > >
> > > > Igniters,
> > > >
> > > > I prepared rather important patch [1] related to grid stability and
> > need
> > > a
> > > > review and some help to finish it.
> > > >
> > > > Semyon Boikov, could you please take a look on patch code ? [2]
> > > >
> > > > Pavel Tupitsyn, could you lend a hand to help completing .NET part
> (two
> > > new
> > > > public API methods are added as a part of working on [3], java code
> in
> > > > branch [2])
> > > >
> > > > [1] https://issues.apache.org/jira/browse/IGNITE-6827
> > > >
> > > > [2] https://github.com/gridgain/apache-ignite/tree/ignite-6827-2
> > > >
> > > > [3] https://issues.apache.org/jira/browse/IGNITE-7910
> > > >
> > > > --
> > > >
> > > > Best regards,
> > > > Alexei Scherbakov
> > > >
> > >
> >
>
Re: IGNITE-6827 - Review needed.
Posted by Andrey Gura <ag...@apache.org>.
Guys,
I've looked at IGNITE-6827 implementation and have comment. I think
that rollbackOnTopologyChangeTimeout parameter isn't related with
implemented functionality. It's responsibility of PME to rollback
transactions that blocks exchange, so rollbackOnTopologyChangeTimeout
should be configured for PME not for transactions.
On Mon, Apr 2, 2018 at 2:53 PM, Dmitry Pavlov <dp...@gmail.com> wrote:
> Hi Igniters,
>
> A number of .NET tests failed, it seems it requied to be updated/fixed first
> Ignite Platform .NET Core Linux [ tests 2 ]
> dll: TransactionsParityTest.TestTransactions (master fail rate 0,0%)
> dll: CachePartitionedTest.TestTransactionScopeMultiCache(True)
> (master fail rate 0,0%)
>
> Ignite Queries [1] [ tests 1 ]
> IgniteBinaryCacheQueryTestSuite:
> IgniteSqlSplitterSelfTest.testReplicatedTablesUsingPartitionedCacheSegmentedClient
> (master fail rate 0,0%)
>
> Ignite Platform .NET
> exe: TransactionsParityTest.TestTransactions (master fail rate 0,0%)
>
> Ignite Platform .NET Long Running [ tests 4 TIMEOUT ]
> exe:
> CachePartitionedNearEnabledTest.TestTransactionScopeMultiCache(True)
> (master fail rate 0,0%)
> exe: CachePartitionedTest.TestTransactionScopeMultiCache(True)
> (master fail rate 0,0%)
> exe: CacheReplicatedTest.TestTransactionScopeMultiCache(True) (master
> fail rate 0,0%)
>
>
> And I don't have statitsics on test timeouts, but several timeouts still
> ocurred:
> Cache (Restarts) [1] [ tests 0 TIMEOUT , Exit Code ]
> GridCachePartitionedNearDisabledOptimisticTxNodeRestartTest.testRestartWithTxTenNodesTwoBackups
> (last started) More >>
>
> Client Nodes [ tests 0 TIMEOUT , Exit Code warn 1 ]
> IgniteClientReconnectFailoverTest.testReconnectStreamerApi (last started)
>
> Ignite PDS Indexing [ tests 0 TIMEOUT , Exit Code warn 9 ]
> IgnitePdsDiskErrorsRecoveringTest.testRecoveringOnWALErrorWithoutMmap (last
> started)
>
> Sincerely,
> Dmitriy Pavlov
>
> пн, 2 апр. 2018 г. в 12:48, Alexey Goncharuk <al...@gmail.com>:
>
>> Guys, especially Vladimir Ozerov, Yakov Zhanov, Dmitriy Setrakyan,
>>
>> While the technical side of the change is being reviewed, I would also ask
>> you to pay attention to the public API changes here.
>>
>> --AG
>>
>> 2018-03-21 23:43 GMT+03:00 Pavel Tupitsyn <pt...@apache.org>:
>>
>> > Hi Alexei,
>> >
>> > > Pavel Tupitsyn, could you lend a hand to help completing .NET part
>> (two
>> > new
>> > public API methods are added as a part of working on [3], java code in
>> > branch [2])
>> >
>> > Please file a separate ticket for .NET changes.
>> > I would like to help, but maybe some time later. No need to delay your
>> > changes because of that.
>> >
>> > Thanks,
>> > Pavel
>> >
>> > On Wed, Mar 21, 2018 at 1:08 PM, Dmitry Pavlov <dp...@gmail.com>
>> > wrote:
>> >
>> > > Hi Alexei ,
>> > >
>> > > Thank you for contribution, unfortunately there is too much tests
>> failed
>> > > there:
>> > > .NET is broken
>> > >
>> > > Ignite Platform .NET Long Running [ tests 3 ]
>> > >
>> CachePartitionedNearEnabledTest.TestTransactionScopeMultiCache(True)
>> > > CachePartitionedTest.TestTransactionScopeMultiCache(True)
>> > > CacheReplicatedTest.TestTransactionScopeMultiCache(True)
>> > >
>> > > Ignite Platform .NET Core Linux [ tests 2 TC_EXIT_CODE ]
>> > > TransactionsParityTest.TestTransactions (fail rate 0,0%)
>> > > CachePartitionedTest.TestTransactionScopeMultiCache(True) (fail
>> > rate
>> > > 0,0%)
>> > >
>> > > Ignite Platform .NET [ tests 1 ] agoncharuk More info >>
>> > > Test fail rate less than 1%, probably new failure exe:
>> > > TransactionsParityTest.TestTransactions (fail rate 0,0%)
>> > >
>> > > Too much timeouts:
>> > > Ignite Cache Failover [2]
>> > > with CacheAsyncOperationsFailoverTxTest.testPutAllAsyncFailover (last
>> > > started)
>> > >
>> > > ~[Obsolete] Ignite Cache Expiry Policy [ tests 1 ]
>> > > with IgniteCacheExpiryPolicyTestSuite:
>> > > IgniteCacheTtlCleanupSelfTest.testDeferredDeleteTtl
>> > >
>> > > Ignite Cache Restarts [2]
>> > > with
>> > > GridCachePutAllFailoverSelfTest.testPutAllFailoverNearDisabled
>> > ThreeBackups
>> > > (last started)
>> > >
>> > > Ignite Cache Restarts [1]
>> > > with
>> > > GridCachePartitionedNearDisabledOptimisticTxNodeRestartTest.
>> > > testRestartWithTxTenNodesTwoBackups
>> > > (last started)
>> > >
>> > > Cache [6]
>> > > with WalModeChangeAdvancedSelfTest.testServerRestartNonCoordinator
>> > > (last started)
>> > > it is not all.
>> > >
>> > > Please fix tests before review. Also you could change ticket status to
>> > 'In
>> > > Progress'.
>> > >
>> > > As easy option, you can merge current master to your branch, it is
>> > probably
>> > > that some test were fixed already.
>> > >
>> > > Sincerely,
>> > > Dmitriy Pavlov
>> > >
>> > > ср, 21 мар. 2018 г. в 9:58, Alexei Scherbakov <
>> > > alexey.scherbakoff@gmail.com
>> > > >:
>> > >
>> > > > Igniters,
>> > > >
>> > > > I prepared rather important patch [1] related to grid stability and
>> > need
>> > > a
>> > > > review and some help to finish it.
>> > > >
>> > > > Semyon Boikov, could you please take a look on patch code ? [2]
>> > > >
>> > > > Pavel Tupitsyn, could you lend a hand to help completing .NET part
>> (two
>> > > new
>> > > > public API methods are added as a part of working on [3], java code
>> in
>> > > > branch [2])
>> > > >
>> > > > [1] https://issues.apache.org/jira/browse/IGNITE-6827
>> > > >
>> > > > [2] https://github.com/gridgain/apache-ignite/tree/ignite-6827-2
>> > > >
>> > > > [3] https://issues.apache.org/jira/browse/IGNITE-7910
>> > > >
>> > > > --
>> > > >
>> > > > Best regards,
>> > > > Alexei Scherbakov
>> > > >
>> > >
>> >
>>
Re: IGNITE-6827 - Review needed.
Posted by Dmitry Pavlov <dp...@gmail.com>.
Hi Igniters,
A number of .NET tests failed, it seems it requied to be updated/fixed first
Ignite Platform .NET Core Linux [ tests 2 ]
dll: TransactionsParityTest.TestTransactions (master fail rate 0,0%)
dll: CachePartitionedTest.TestTransactionScopeMultiCache(True)
(master fail rate 0,0%)
Ignite Queries [1] [ tests 1 ]
IgniteBinaryCacheQueryTestSuite:
IgniteSqlSplitterSelfTest.testReplicatedTablesUsingPartitionedCacheSegmentedClient
(master fail rate 0,0%)
Ignite Platform .NET
exe: TransactionsParityTest.TestTransactions (master fail rate 0,0%)
Ignite Platform .NET Long Running [ tests 4 TIMEOUT ]
exe:
CachePartitionedNearEnabledTest.TestTransactionScopeMultiCache(True)
(master fail rate 0,0%)
exe: CachePartitionedTest.TestTransactionScopeMultiCache(True)
(master fail rate 0,0%)
exe: CacheReplicatedTest.TestTransactionScopeMultiCache(True) (master
fail rate 0,0%)
And I don't have statitsics on test timeouts, but several timeouts still
ocurred:
Cache (Restarts) [1] [ tests 0 TIMEOUT , Exit Code ]
GridCachePartitionedNearDisabledOptimisticTxNodeRestartTest.testRestartWithTxTenNodesTwoBackups
(last started) More >>
Client Nodes [ tests 0 TIMEOUT , Exit Code warn 1 ]
IgniteClientReconnectFailoverTest.testReconnectStreamerApi (last started)
Ignite PDS Indexing [ tests 0 TIMEOUT , Exit Code warn 9 ]
IgnitePdsDiskErrorsRecoveringTest.testRecoveringOnWALErrorWithoutMmap (last
started)
Sincerely,
Dmitriy Pavlov
пн, 2 апр. 2018 г. в 12:48, Alexey Goncharuk <al...@gmail.com>:
> Guys, especially Vladimir Ozerov, Yakov Zhanov, Dmitriy Setrakyan,
>
> While the technical side of the change is being reviewed, I would also ask
> you to pay attention to the public API changes here.
>
> --AG
>
> 2018-03-21 23:43 GMT+03:00 Pavel Tupitsyn <pt...@apache.org>:
>
> > Hi Alexei,
> >
> > > Pavel Tupitsyn, could you lend a hand to help completing .NET part
> (two
> > new
> > public API methods are added as a part of working on [3], java code in
> > branch [2])
> >
> > Please file a separate ticket for .NET changes.
> > I would like to help, but maybe some time later. No need to delay your
> > changes because of that.
> >
> > Thanks,
> > Pavel
> >
> > On Wed, Mar 21, 2018 at 1:08 PM, Dmitry Pavlov <dp...@gmail.com>
> > wrote:
> >
> > > Hi Alexei ,
> > >
> > > Thank you for contribution, unfortunately there is too much tests
> failed
> > > there:
> > > .NET is broken
> > >
> > > Ignite Platform .NET Long Running [ tests 3 ]
> > >
> CachePartitionedNearEnabledTest.TestTransactionScopeMultiCache(True)
> > > CachePartitionedTest.TestTransactionScopeMultiCache(True)
> > > CacheReplicatedTest.TestTransactionScopeMultiCache(True)
> > >
> > > Ignite Platform .NET Core Linux [ tests 2 TC_EXIT_CODE ]
> > > TransactionsParityTest.TestTransactions (fail rate 0,0%)
> > > CachePartitionedTest.TestTransactionScopeMultiCache(True) (fail
> > rate
> > > 0,0%)
> > >
> > > Ignite Platform .NET [ tests 1 ] agoncharuk More info >>
> > > Test fail rate less than 1%, probably new failure exe:
> > > TransactionsParityTest.TestTransactions (fail rate 0,0%)
> > >
> > > Too much timeouts:
> > > Ignite Cache Failover [2]
> > > with CacheAsyncOperationsFailoverTxTest.testPutAllAsyncFailover (last
> > > started)
> > >
> > > ~[Obsolete] Ignite Cache Expiry Policy [ tests 1 ]
> > > with IgniteCacheExpiryPolicyTestSuite:
> > > IgniteCacheTtlCleanupSelfTest.testDeferredDeleteTtl
> > >
> > > Ignite Cache Restarts [2]
> > > with
> > > GridCachePutAllFailoverSelfTest.testPutAllFailoverNearDisabled
> > ThreeBackups
> > > (last started)
> > >
> > > Ignite Cache Restarts [1]
> > > with
> > > GridCachePartitionedNearDisabledOptimisticTxNodeRestartTest.
> > > testRestartWithTxTenNodesTwoBackups
> > > (last started)
> > >
> > > Cache [6]
> > > with WalModeChangeAdvancedSelfTest.testServerRestartNonCoordinator
> > > (last started)
> > > it is not all.
> > >
> > > Please fix tests before review. Also you could change ticket status to
> > 'In
> > > Progress'.
> > >
> > > As easy option, you can merge current master to your branch, it is
> > probably
> > > that some test were fixed already.
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > ср, 21 мар. 2018 г. в 9:58, Alexei Scherbakov <
> > > alexey.scherbakoff@gmail.com
> > > >:
> > >
> > > > Igniters,
> > > >
> > > > I prepared rather important patch [1] related to grid stability and
> > need
> > > a
> > > > review and some help to finish it.
> > > >
> > > > Semyon Boikov, could you please take a look on patch code ? [2]
> > > >
> > > > Pavel Tupitsyn, could you lend a hand to help completing .NET part
> (two
> > > new
> > > > public API methods are added as a part of working on [3], java code
> in
> > > > branch [2])
> > > >
> > > > [1] https://issues.apache.org/jira/browse/IGNITE-6827
> > > >
> > > > [2] https://github.com/gridgain/apache-ignite/tree/ignite-6827-2
> > > >
> > > > [3] https://issues.apache.org/jira/browse/IGNITE-7910
> > > >
> > > > --
> > > >
> > > > Best regards,
> > > > Alexei Scherbakov
> > > >
> > >
> >
>