You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2017/02/28 08:51:59 UTC

kylin git commit: KYLIN-2474 check lookup table after build snapshot

Repository: kylin
Updated Branches:
  refs/heads/KYLIN-2474 [created] b0d5930bd


KYLIN-2474 check lookup table after build snapshot


Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/b0d5930b
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/b0d5930b
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/b0d5930b

Branch: refs/heads/KYLIN-2474
Commit: b0d5930bdf32414fe52e1893785bbf64131464f4
Parents: e875e87
Author: Li Yang <li...@apache.org>
Authored: Tue Feb 28 16:51:45 2017 +0800
Committer: Li Yang <li...@apache.org>
Committed: Tue Feb 28 16:51:45 2017 +0800

----------------------------------------------------------------------
 .../apache/kylin/cube/cli/DictionaryGeneratorCLI.java   | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kylin/blob/b0d5930b/core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java
----------------------------------------------------------------------
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java b/core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java
index 2e5a38e..e8c53f7 100644
--- a/core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java
@@ -32,6 +32,7 @@ import org.apache.kylin.dict.DictionaryProvider;
 import org.apache.kylin.dict.DistinctColumnValuesProvider;
 import org.apache.kylin.metadata.MetadataManager;
 import org.apache.kylin.metadata.model.DataModelDesc;
+import org.apache.kylin.metadata.model.JoinDesc;
 import org.apache.kylin.metadata.model.TableDesc;
 import org.apache.kylin.metadata.model.TableRef;
 import org.apache.kylin.metadata.model.TblColRef;
@@ -77,16 +78,25 @@ public class DictionaryGeneratorCLI {
 
         // snapshot
         Set<String> toSnapshot = Sets.newHashSet();
+        Set<TableRef> toCheckLookup = Sets.newHashSet();
         for (DimensionDesc dim : cubeSeg.getCubeDesc().getDimensions()) {
             TableRef table = dim.getTableRef();
-            if (cubeSeg.getModel().isLookupTable(table))
+            if (cubeSeg.getModel().isLookupTable(table)) {
                 toSnapshot.add(table.getTableIdentity());
+                toCheckLookup.add(table);
+            }
         }
 
         for (String tableIdentity : toSnapshot) {
             logger.info("Building snapshot of " + tableIdentity);
             cubeMgr.buildSnapshotTable(cubeSeg, tableIdentity);
         }
+        
+        for (TableRef lookup : toCheckLookup) {
+            logger.info("Checking snapshot of " + lookup);
+            JoinDesc join = cubeSeg.getModel().getJoinsTree().getJoinByPKSide(lookup);
+            cubeMgr.getLookupTable(cubeSeg, join);
+        }
     }
 
     private static ReadableTable decideInputTable(DataModelDesc model, TblColRef col, DistinctColumnValuesProvider factTableValueProvider) {