You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Olga Smola <ol...@gmail.com> on 2012/06/29 11:33:27 UTC

Review Request: CS-15392: Incorrect results when edit user.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5658/
-----------------------------------------------------------

Review request for cloudstack and Brian Federle.


Description
-------

Fix for http://bugs.cloudstack.org/browse/CS-15392


This addresses bug CS-15392.


Diffs
-----

  ui/scripts/accounts.js 6f30963 

Diff: https://reviews.apache.org/r/5658/diff/


Testing
-------


Thanks,

Olga Smola


RE: Review Request: CS-15392: Incorrect results when edit user.

Posted by Sanjay Tripathi <sa...@citrix.com>.
Hi Olga, 
I reviewed your code and patch works fine. 
Assigned the ticket to Brian for the final review.

Thanks and Regards,
Sanjay Tripathi

-----Original Message-----
From: Olga Smola [mailto:noreply@reviews.apache.org] On Behalf Of Olga Smola
Sent: Friday, June 29, 2012 3:03 PM
To: Brian Federle
Cc: cloudstack; Olga Smola
Subject: Review Request: CS-15392: Incorrect results when edit user.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5658/
-----------------------------------------------------------

Review request for cloudstack and Brian Federle.


Description
-------

Fix for http://bugs.cloudstack.org/browse/CS-15392


This addresses bug CS-15392.


Diffs
-----

  ui/scripts/accounts.js 6f30963 

Diff: https://reviews.apache.org/r/5658/diff/


Testing
-------


Thanks,

Olga Smola


Re: Review Request: CS-15392: Incorrect results when edit user.

Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5658/#review8990
-----------------------------------------------------------

Ship it!


Ship It!

- Brian Federle


On June 29, 2012, 9:33 a.m., Olga Smola wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5658/
> -----------------------------------------------------------
> 
> (Updated June 29, 2012, 9:33 a.m.)
> 
> 
> Review request for cloudstack and Brian Federle.
> 
> 
> Description
> -------
> 
> Fix for http://bugs.cloudstack.org/browse/CS-15392
> 
> 
> This addresses bug CS-15392.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/accounts.js 6f30963 
> 
> Diff: https://reviews.apache.org/r/5658/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olga Smola
> 
>