You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Hiroaki Kawai <ka...@stratosphere.co.jp> on 2012/09/19 02:56:49 UTC
Review Request: add logging for debugging.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7153/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
add logging for debugging.
The default value for local.storage.path does not exists by
default in CentOS 6. By default, this results in NullPointerException
silently. Without this log message, administrator can't figure out
the reason at all.
Diffs
-----
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java d6236a0d6038bbf251450a424ea0089c01739e00
Diff: https://reviews.apache.org/r/7153/diff/
Testing
-------
Thanks,
Hiroaki Kawai
Re: Review Request: add logging for debugging.
Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7153/#review11680
-----------------------------------------------------------
The default path is /var/lib/libvirt/images/, which should be there if libvirt is installed. Anyway, I'll check it in.
- edison su
On Sept. 19, 2012, 12:56 a.m., Hiroaki Kawai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7153/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2012, 12:56 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> add logging for debugging.
>
> The default value for local.storage.path does not exists by
> default in CentOS 6. By default, this results in NullPointerException
> silently. Without this log message, administrator can't figure out
> the reason at all.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java d6236a0d6038bbf251450a424ea0089c01739e00
>
> Diff: https://reviews.apache.org/r/7153/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hiroaki Kawai
>
>
Re: Review Request: add logging for debugging.
Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7153/#review11681
-----------------------------------------------------------
Ship it!
Ship It!
- edison su
On Sept. 19, 2012, 12:56 a.m., Hiroaki Kawai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7153/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2012, 12:56 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> add logging for debugging.
>
> The default value for local.storage.path does not exists by
> default in CentOS 6. By default, this results in NullPointerException
> silently. Without this log message, administrator can't figure out
> the reason at all.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java d6236a0d6038bbf251450a424ea0089c01739e00
>
> Diff: https://reviews.apache.org/r/7153/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hiroaki Kawai
>
>