[GitHub] [qpid-proton] alanconway commented on a change in pull request #231: WIP: Fix memory leak in go message unmarshal

[GitBox <gi...@apache.org>]

alanconway commented on a change in pull request #231: WIP: Fix memory leak in go message unmarshal
URL: https://github.com/apache/qpid-proton/pull/231#discussion_r399227856
 
 

 ##########
 File path: go/pkg/amqp/url_test.go
 ##########
 @@ -32,8 +32,9 @@ func ExampleParseURL() {
 		"amqps://host",
 		"/path",
 		"",
-		":1234",
-                // Taken out because the go 1.4 URL parser isn't the same as later
+		// Taken out because url.Parse error formatting changed in 1.13
 
 Review comment:
   The "taken out" lines can just be deleted - they're not valid URLs, those forms were only ever supported for backwards compat and I'm pretty sure aren't needed anymore.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org