You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by jinfengni <gi...@git.apache.org> on 2017/09/13 18:14:07 UTC

[GitHub] drill pull request #941: DRILL-5775: Expand * into list of column/column fam...

GitHub user jinfengni opened a pull request:

    https://github.com/apache/drill/pull/941

    DRILL-5775: Expand * into list of column/column family for  MapR-DB b…

    …inary table groupscan.
    
     Move common code to HBaseUtils, so it's shared by both HBaseGroupScan and BinaryTableGroupScan
     The issue was exposed by existing unit tests in contrib/format-maprdb; no new unit tests added.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jinfengni/incubator-drill DRILL-5775

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/941.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #941
    
----
commit 4ff7ef2bdefbdf92c813a07c4f5bfff19acb1e8a
Author: Jinfeng Ni <jn...@apache.org>
Date:   2017-09-06T21:48:54Z

    DRILL-5775: Expand * into list of column/column family for  MapR-DB binary table groupscan.
    
     Move common code to HBaseUtils, so it's shared by both HBaseGroupScan and BinaryTableGroupScan
     The issue was exposed by existing unit tests in contrib/format-maprdb; no new unit tests added.

----


---

[GitHub] drill issue #941: DRILL-5775: Expand * into list of column/column family for...

Posted by prasadns14 <gi...@git.apache.org>.

Github user prasadns14 commented on the issue:

    https://github.com/apache/drill/pull/941
  
    Yes, this PR is now obsolete. All the cases are covered as part of DRILL-5830 and DRILL-5775


---

[GitHub] drill issue #941: DRILL-5775: Expand * into list of column/column family for...

Posted by paul-rogers <gi...@git.apache.org>.

Github user paul-rogers commented on the issue:

    https://github.com/apache/drill/pull/941
  
    Is this PR obsolete after DRILL-5830 and the other DRILL-5775? If so can we close this one? Otherwise, if this one addresses a case not covered by the others, can we revise this PR to cover just that other case, on top of latest master? Thanks!


---

[GitHub] drill issue #941: DRILL-5775: Expand * into list of column/column family for...

Posted by paul-rogers <gi...@git.apache.org>.

Github user paul-rogers commented on the issue:

    https://github.com/apache/drill/pull/941
  
    This fix is based on a change made in DRILL-5546. As described in DRILL-5830, the HBase part of that fix was a bit redundant. It turns out that HBase, via the project rel improvements in DRILL-5546, already expanded the wildcard into columns using the 'DrillHBaseTable.getRowType()' method. (You understand the details better than I...)
    
    I wonder if we can do the same for MapR-DB binary? That way, we have just one common path for projection push down.


---