You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by ka...@apache.org on 2021/05/09 15:03:36 UTC
[submarine] branch master updated: SUBMARINE-820. Fix github action
error
This is an automated email from the ASF dual-hosted git repository.
kaihsun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git
The following commit(s) were added to refs/heads/master by this push:
new ffc415f SUBMARINE-820. Fix github action error
ffc415f is described below
commit ffc415f9b68c1d36554e0c59076554c90b03e69f
Author: ByronHsu <by...@gmail.com>
AuthorDate: Sun May 9 23:03:26 2021 +0800
SUBMARINE-820. Fix github action error
### What is this PR for?
[This commit](https://github.com/actions/virtual-environments/commit/7a712168c20dcbccb1286056c0b5c0bd765f5bba) of Ubuntu runner at 20210504 updates Maven from 3.6.3 to 3.8.1, and causes our task to fail. I fix Maven version at 3.6.3 to solve this problem.
### What type of PR is it?
[Bug Fix]
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
---
.github/workflows/master.yml | 19 ++++++++++++++++++-
.../submarine/ml/pytorch/input/libsvm_dataset.py | 1 +
website/docs/devDocs/BuildFromCode.md | 2 +-
website/docs/devDocs/Development.md | 2 +-
4 files changed, 21 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml
index fb03794..2fed76f 100644
--- a/.github/workflows/master.yml
+++ b/.github/workflows/master.yml
@@ -12,6 +12,14 @@ jobs:
uses: actions/setup-java@v1
with:
java-version: '1.8'
+ - name: Set up Maven 3.6.3
+ uses: stCarolas/setup-maven@v4
+ with:
+ maven-version: 3.6.3
+ - name: Check version
+ run: |
+ mvn --version
+ java -version
- uses: actions/cache@v1
with:
path: ~/.m2/repository/com
@@ -56,9 +64,18 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- - uses: actions/setup-java@v1
+ - name: Set up JDK 1.8
+ uses: actions/setup-java@v1
with:
java-version: '1.8'
+ - name: Set up Maven 3.6.3
+ uses: stCarolas/setup-maven@v4
+ with:
+ maven-version: 3.6.3
+ - name: Check version
+ run: |
+ mvn --version
+ java -version
- uses: actions/cache@v1
with:
path: ~/.m2/repository/com
diff --git a/submarine-sdk/pysubmarine/submarine/ml/pytorch/input/libsvm_dataset.py b/submarine-sdk/pysubmarine/submarine/ml/pytorch/input/libsvm_dataset.py
index bb33697..dc35c4a 100644
--- a/submarine-sdk/pysubmarine/submarine/ml/pytorch/input/libsvm_dataset.py
+++ b/submarine-sdk/pysubmarine/submarine/ml/pytorch/input/libsvm_dataset.py
@@ -30,6 +30,7 @@ from typing import List, Tuple
class LIBSVMDataset(Dataset):
def __init__(self, data_uri: str, sample_offset: np.ndarray):
+ super().__init__()
self.data_uri = data_uri
self.sample_offset = sample_offset
diff --git a/website/docs/devDocs/BuildFromCode.md b/website/docs/devDocs/BuildFromCode.md
index f9eb0aa..ecb3018 100644
--- a/website/docs/devDocs/BuildFromCode.md
+++ b/website/docs/devDocs/BuildFromCode.md
@@ -19,7 +19,7 @@ title: How to Build Submarine
## Prerequisites
+ JDK 1.8
-+ Maven 3.3 or later ( 3.6.2 is known to fail, see SUBMARINE-273 )
++ Maven 3.3 or later ( < 3.8.1 )
+ Docker
## Quick Start
diff --git a/website/docs/devDocs/Development.md b/website/docs/devDocs/Development.md
index d849c53..d391685 100644
--- a/website/docs/devDocs/Development.md
+++ b/website/docs/devDocs/Development.md
@@ -44,7 +44,7 @@ From [This Video](https://youtu.be/32Na2k6Alv4), you will know how to deal with
### Prerequisites
- JDK 1.8
-- Maven 3.3 or later ( 3.6.2 is known to fail, see SUBMARINE-273 )
+- Maven 3.3 or later ( < 3.8.1 )
- Docker
### Setting up checkstyle in IDE
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org